Skip to content

ci: name the plugin jobs for product groups #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LKSNDRTMLKV wants to merge 3 commits into
base: main
Choose a base branch
from
Open

ci: name the plugin jobs for product groups #402

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
64f51a1
ci: name the plugin jobs for product groups
LKSNDRTMLKV Oct 5, 2026
9cd5fbb
Merge branch 'main' into ci/name-product-group-plugin-jobs
LKSNDRTMLKV Oct 8, 2026
71bdcd2
Merge remote-tracking branch 'origin/main' into ci/name-product-group…
LKSNDRTMLKV Oct 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ jobs:
run: cargo deny check bans licenses sources

plugins:
name: Sector plugin tests
name: Product group plugin tests
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7
Expand All @@ -165,14 +165,14 @@ jobs:
# --workspace` above never reaches them. This mirrors `just
# test-plugins` so a plugin regression fails CI, not only a local
# `just check`.
- name: Sector plugin tests
- name: Product group plugin tests
run: just test-plugins
# The same exclusion keeps them out of `cargo fmt --all` and `cargo
# clippy --workspace`, so plugin code had no formatting check and no lint
# at all — seven of ten crates were unformatted when this was added.
- name: Sector plugin formatting
- name: Product group plugin formatting
run: just fmt-check-plugins
- name: Sector plugin lint
- name: Product group plugin lint
run: just lint-plugins
# Each loop above asserts it did some work. This proves that assertion
# fails on an empty match, because the failure that keeps recurring here
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/wasm-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,8 @@ jobs:
working-directory: crates/dpp-domain
run: cargo build --target wasm32-unknown-unknown --release

sector-plugins:
name: WASM build — sector plugins
product-group-plugins:
name: WASM build — product group plugins
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7
Expand Down
2 changes: 1 addition & 1 deletion docs/regulatory/CONFORMITY.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,7 @@ Product group-specific compliance logic runs as sandboxed Wasm modules

The `check` recipe in `justfile` is the local gate, and its dependency list is
the list of what it runs — formatting, lints and tests for the workspace and
for the sector plugins, doc-tests, the doc build, the lockfile check and
for the product group plugins, doc-tests, the doc build, the lockfile check and
`cargo audit`. It is not restated step by step here, because the four-step copy
this section used to carry had fallen behind it. GitHub Actions
(`.github/workflows/`) covers the same ground in separate jobs and adds what
Expand Down
Loading