Skip to content

fix(test): drop the shared test Postgres volume #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
LKSNDRTMLKV wants to merge 1 commit into from
Closed

fix(test): drop the shared test Postgres volume #456

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion scripts/shared-test-pg.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,11 @@ container="odal-shared-test-pg-$$"
port="${ODAL_TEST_PG_PORT:-55432}"

cleanup() {
docker rm -f "$container" > /dev/null 2>&1 || true
# `-v`, or the server's data stays behind. `postgres:17` declares its data
# directory a volume, and an explicit `docker rm` keeps a container's
# anonymous volumes even when `--rm` started it. Each run then left one
# orphaned volume holding every database it cloned, 1-10 GB apiece.
docker rm -f -v "$container" > /dev/null 2>&1 || true
}
trap cleanup EXIT

Expand Down
Loading