Skip to content

[authentication/2.6.2] Activate enrollment and durably promote client credentials - #73

Merged
omry merged 1 commit into
pr71from
pr73
Oct 27, 2026
Merged

[authentication/2.6.2] Activate enrollment and durably promote client credentials#73
omry merged 1 commit into
pr71from
pr73

Conversation

@omry

@omry omry commented Oct 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Owner

Connect public pairing to the existing transactional activation path. Authenticate the exact committed receipt before publishing the complete private enrolled bundle, and retain same-selector recovery after ambiguous replies or interrupted publication.

Add process-kill and real Python/Go regressions for durable recovery and original-deadline reply loss or delay. Update operator guidance and release notes.

Validation: 1,610 Python unit tests passed (43 skipped), 49 Python/Go integration tests passed, Go test/vet, Pyrefly, Black and website build passed. Local DBB and fresh history-aware general reviews are clean for this candidate; native platform and installed-CLI acceptance remain separate delivery gates.

@omry
omry changed the base branch from main to pr71 October 26, 2026 20:21
@omry
omry added this pull request to stack #54 October 26, 2026 20:25
@omry

omry commented Oct 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Owner Author

PR-cycle state — maintained automatically. Do not edit by hand.

Mechanical PR-cycle state (JSON) 
{
  "approval": {
    "candidate_revision_fingerprint": "sha256:b1a313864f5d9b53f3fe932a92515d39aa6d767828ce02a4bb9784b9c9fef481",
    "evidence": {
      "attestations": [
        {
          "baseline_identity": "sha256:95080c8129b4da2db4db318d829532ce16d721ef805c4a756c90a714c0262483",
          "closure_identity": "sha256:c8806380d7d9c6a65c5f4691b765a080a48cdb0b3d10beac8280e4626ac0839d",
          "document_identity": "sha256:b6511414b3a9b485542df83c8f7abfc499dc8d06e522819b48e162a562d21c57",
          "sidecar_identity": "sha256:79c904f72e578226e1651232379c453990fac14a2735deda6b872acf2cd1d28c"
        },
        {
          "baseline_identity": "sha256:ad1ec634421f4d4b16b5cb61c07844e945fa11d0737e7e59757b3b3aabbf21ce",
          "closure_identity": "sha256:c8806380d7d9c6a65c5f4691b765a080a48cdb0b3d10beac8280e4626ac0839d",
          "document_identity": "sha256:c576091af919c3ec99f0e0edb5795cf4e7bd37a44415ae24742393822317ad3d",
          "sidecar_identity": "sha256:3c969d1c7722b7db806221b23c15d19e577c5e6ad472ba56f7714af25d9cba19"
        },
        {
          "closure_identity": "sha256:c8806380d7d9c6a65c5f4691b765a080a48cdb0b3d10beac8280e4626ac0839d",
          "document_identity": "sha256:d56e92a7cb01f131ba499650c4a5d7b2c8d17adf2cdc7d612eee7c5f53d07929",
          "sidecar_identity": "sha256:b02245b52befcecf939bd2373a16912cad483a5a100c7f5733856cd39b4921b5"
        }
      ],
      "candidate_revision_fingerprint": "sha256:b1a313864f5d9b53f3fe932a92515d39aa6d767828ce02a4bb9784b9c9fef481",
      "check_conclusions": [
        {
          "conclusion": "SUCCESS",
          "name": "Gitar",
          "run_id": 121841673427
        },
        {
          "conclusion": "SUCCESS",
          "name": "Platform Linux arm64",
          "run_id": 121841707904
        },
        {
          "conclusion": "SUCCESS",
          "name": "Platform Linux x64",
          "run_id": 121841707793
        },
        {
          "conclusion": "SUCCESS",
          "name": "Platform Windows arm64",
          "run_id": 121841707804
        },
        {
          "conclusion": "SUCCESS",
          "name": "Platform Windows x64",
          "run_id": 121841708024
        },
        {
          "conclusion": "SUCCESS",
          "name": "Platform macOS arm64",
          "run_id": 121841707796
        },
        {
          "conclusion": "SUCCESS",
          "name": "Platform macOS x64",
          "run_id": 121841707999
        },
        {
          "conclusion": "SUCCESS",
          "name": "Python 3.10",
          "run_id": 121841707528
        },
        {
          "conclusion": "SUCCESS",
          "name": "Python 3.11",
          "run_id": 121841708160
        },
        {
          "conclusion": "SUCCESS",
          "name": "Python 3.12",
          "run_id": 121841708126
        },
        {
          "conclusion": "SUCCESS",
          "name": "Python 3.14",
          "run_id": 121841707631
        },
        {
          "conclusion": "SUCCESS",
          "name": "Python lint",
          "run_id": 121841707337
        },
        {
          "conclusion": "SUCCESS",
          "name": "Website",
          "run_id": 121841707539
        }
      ],
      "delivery_deferral_ledger_digest": "sha256:4f53cda18c2baa0c0354bb5f9a3ecbe5ed12ab4d8e11ba873c2f11161202b945",
      "finding_dispositions_digest": "sha256:9305246a4aadfdb4555b38dff5506e7c959722886d170198cbf07b8ba1d14e66",
      "operation_identity": "sha256:c6764b63f3ebeab0774a4a74fb72b497d94e40f48d29cfa71442511a772920d9",
      "review_request": {
        "body_digest": "sha256:78762b207b64093ed1bfdd88119b39c326678d378458ff16fb3beed5f0c39d15",
        "id": 6427192749
      },
      "review_result": {
        "body_digest": "sha256:4d26fb3db8bafc74dff63a117d24c2b39b38e0743787b473f01fab59c01c2245",
        "id": 6427221480
      }
    },
    "evidence_fingerprint": "sha256:9c911cc9e57d793878928ef789d8f6b4a2ce4297ed4fa036ee5c1402a660c694",
    "head_sha": "8ebb7a6519f469cf8b76409fa74abbedb1083150",
    "operation_identity": "sha256:c6764b63f3ebeab0774a4a74fb72b497d94e40f48d29cfa71442511a772920d9",
    "review_request_id": 6427192749,
    "review_result_id": 6427221480,
    "status": "approved-evidence-recorded"
  },
  "candidate_revision_fingerprint": "sha256:b1a313864f5d9b53f3fe932a92515d39aa6d767828ce02a4bb9784b9c9fef481",
  "check_conclusions": [
    {
      "conclusion": "SUCCESS",
      "name": "Gitar",
      "run_id": 121841673427
    },
    {
      "conclusion": "SUCCESS",
      "name": "Platform Linux arm64",
      "run_id": 121841707904
    },
    {
      "conclusion": "SUCCESS",
      "name": "Platform Linux x64",
      "run_id": 121841707793
    },
    {
      "conclusion": "SUCCESS",
      "name": "Platform Windows arm64",
      "run_id": 121841707804
    },
    {
      "conclusion": "SUCCESS",
      "name": "Platform Windows x64",
      "run_id": 121841708024
    },
    {
      "conclusion": "SUCCESS",
      "name": "Platform macOS arm64",
      "run_id": 121841707796
    },
    {
      "conclusion": "SUCCESS",
      "name": "Platform macOS x64",
      "run_id": 121841707999
    },
    {
      "conclusion": "SUCCESS",
      "name": "Python 3.10",
      "run_id": 121841707528
    },
    {
      "conclusion": "SUCCESS",
      "name": "Python 3.11",
      "run_id": 121841708160
    },
    {
      "conclusion": "SUCCESS",
      "name": "Python 3.12",
      "run_id": 121841708126
    },
    {
      "conclusion": "SUCCESS",
      "name": "Python 3.14",
      "run_id": 121841707631
    },
    {
      "conclusion": "SUCCESS",
      "name": "Python lint",
      "run_id": 121841707337
    },
    {
      "conclusion": "SUCCESS",
      "name": "Website",
      "run_id": 121841707539
    }
  ],
  "check_observations": [
    {
      "checks": [
        {
          "conclusion": "SUCCESS",
          "name": "Gitar",
          "run_id": 121841673427,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/arbiter/runs/121841673427"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Platform Linux arm64",
          "run_id": 121841707904,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/arbiter/actions/runs/40399631519/job/121841707904"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Platform Linux x64",
          "run_id": 121841707793,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/arbiter/actions/runs/40399631519/job/121841707793"
        },
        {
          "name": "Platform Windows arm64",
          "run_id": 121841707804,
          "run_status": "in_progress",
          "status": "pending",
          "url": "https://github.com/omry/arbiter/actions/runs/40399631519/job/121841707804"
        },
        {
          "name": "Platform Windows x64",
          "run_id": 121841708024,
          "run_status": "in_progress",
          "status": "pending",
          "url": "https://github.com/omry/arbiter/actions/runs/40399631519/job/121841708024"
        },
        {
          "name": "Platform macOS arm64",
          "run_id": 121841707796,
          "run_status": "in_progress",
          "status": "pending",
          "url": "https://github.com/omry/arbiter/actions/runs/40399631519/job/121841707796"
        },
        {
          "name": "Platform macOS x64",
          "run_id": 121841707999,
          "run_status": "in_progress",
          "status": "pending",
          "url": "https://github.com/omry/arbiter/actions/runs/40399631519/job/121841707999"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Python 3.10",
          "run_id": 121841707528,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/arbiter/actions/runs/40399631519/job/121841707528"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Python 3.11",
          "run_id": 121841708160,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/arbiter/actions/runs/40399631519/job/121841708160"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Python 3.12",
          "run_id": 121841708126,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/arbiter/actions/runs/40399631519/job/121841708126"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Python 3.14",
          "run_id": 121841707631,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/arbiter/actions/runs/40399631519/job/121841707631"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Python lint",
          "run_id": 121841707337,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/arbiter/actions/runs/40399631519/job/121841707337"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Website",
          "run_id": 121841707539,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/arbiter/actions/runs/40399631519/job/121841707539"
        }
      ],
      "head_sha": "8ebb7a6519f469cf8b76409fa74abbedb1083150",
      "id": "sha256:59a83d349d9bbd14a5834af31188dcf031cccf34ca4e563773bf8e40a8e62278",
      "required_checks": [
        "Gitar",
        "Platform Linux arm64",
        "Platform Linux x64",
        "Platform Windows arm64",
        "Platform Windows x64",
        "Platform macOS arm64",
        "Platform macOS x64",
        "Python 3.10",
        "Python 3.11",
        "Python 3.12",
        "Python 3.14",
        "Python lint",
        "Website"
      ],
      "status": "pending"
    },
    {
      "checks": [
        {
          "conclusion": "SUCCESS",
          "name": "Gitar",
          "run_id": 121825008350,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/arbiter/runs/121825008350"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Platform Linux arm64",
          "run_id": 121825001301,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/arbiter/actions/runs/40394833562/job/121825001301"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Platform Linux x64",
          "run_id": 121825001180,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/arbiter/actions/runs/40394833562/job/121825001180"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Platform Windows arm64",
          "run_id": 121825000958,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/arbiter/actions/runs/40394833562/job/121825000958"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Platform Windows x64",
          "run_id": 121825001029,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/arbiter/actions/runs/40394833562/job/121825001029"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Platform macOS arm64",
          "run_id": 121825001064,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/arbiter/actions/runs/40394833562/job/121825001064"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Platform macOS x64",
          "run_id": 121825001016,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/arbiter/actions/runs/40394833562/job/121825001016"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Python 3.10",
          "run_id": 121825001066,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/arbiter/actions/runs/40394833562/job/121825001066"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Python 3.11",
          "run_id": 121825001315,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/arbiter/actions/runs/40394833562/job/121825001315"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Python 3.12",
          "run_id": 121825000866,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/arbiter/actions/runs/40394833562/job/121825000866"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Python 3.14",
          "run_id": 121825000906,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/arbiter/actions/runs/40394833562/job/121825000906"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Python lint",
          "run_id": 121825000633,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/arbiter/actions/runs/40394833562/job/121825000633"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Website",
          "run_id": 121825000202,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/arbiter/actions/runs/40394833562/job/121825000202"
        }
      ],
      "head_sha": "d6bcb9928a780069c71b00c31ffbe52cb8b33060",
      "id": "sha256:7f6c2e7e4800479a09d6776ecbd766b8b69f10e88dc81e4161cd802afbb60ba9",
      "required_checks": [
        "Gitar",
        "Platform Linux arm64",
        "Platform Linux x64",
        "Platform Windows arm64",
        "Platform Windows x64",
        "Platform macOS arm64",
        "Platform macOS x64",
        "Python 3.10",
        "Python 3.11",
        "Python 3.12",
        "Python 3.14",
        "Python lint",
        "Website"
      ],
      "status": "success"
    },
    {
      "checks": [
        {
          "conclusion": "SUCCESS",
          "name": "Gitar",
          "run_id": 121841673427,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/arbiter/runs/121841673427"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Platform Linux arm64",
          "run_id": 121841707904,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/arbiter/actions/runs/40399631519/job/121841707904"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Platform Linux x64",
          "run_id": 121841707793,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/arbiter/actions/runs/40399631519/job/121841707793"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Platform Windows arm64",
          "run_id": 121841707804,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/arbiter/actions/runs/40399631519/job/121841707804"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Platform Windows x64",
          "run_id": 121841708024,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/arbiter/actions/runs/40399631519/job/121841708024"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Platform macOS arm64",
          "run_id": 121841707796,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/arbiter/actions/runs/40399631519/job/121841707796"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Platform macOS x64",
          "run_id": 121841707999,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/arbiter/actions/runs/40399631519/job/121841707999"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Python 3.10",
          "run_id": 121841707528,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/arbiter/actions/runs/40399631519/job/121841707528"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Python 3.11",
          "run_id": 121841708160,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/arbiter/actions/runs/40399631519/job/121841708160"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Python 3.12",
          "run_id": 121841708126,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/arbiter/actions/runs/40399631519/job/121841708126"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Python 3.14",
          "run_id": 121841707631,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/arbiter/actions/runs/40399631519/job/121841707631"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Python lint",
          "run_id": 121841707337,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/arbiter/actions/runs/40399631519/job/121841707337"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Website",
          "run_id": 121841707539,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/arbiter/actions/runs/40399631519/job/121841707539"
        }
      ],
      "head_sha": "8ebb7a6519f469cf8b76409fa74abbedb1083150",
      "id": "sha256:ac2e13a276359ff557875635644d52469795501de0f2940194b9845a12577722",
      "required_checks": [
        "Gitar",
        "Platform Linux arm64",
        "Platform Linux x64",
        "Platform Windows arm64",
        "Platform Windows x64",
        "Platform macOS arm64",
        "Platform macOS x64",
        "Python 3.10",
        "Python 3.11",
        "Python 3.12",
        "Python 3.14",
        "Python lint",
        "Website"
      ],
      "status": "success"
    },
    {
      "checks": [
        {
          "conclusion": "SUCCESS",
          "name": "Gitar",
          "run_id": 121825008350,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/arbiter/runs/121825008350"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Platform Linux arm64",
          "run_id": 121825001301,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/arbiter/actions/runs/40394833562/job/121825001301"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Platform Linux x64",
          "run_id": 121825001180,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/arbiter/actions/runs/40394833562/job/121825001180"
        },
        {
          "name": "Platform Windows arm64",
          "run_id": 121825000958,
          "run_status": "in_progress",
          "status": "pending",
          "url": "https://github.com/omry/arbiter/actions/runs/40394833562/job/121825000958"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Platform Windows x64",
          "run_id": 121825001029,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/arbiter/actions/runs/40394833562/job/121825001029"
        },
        {
          "name": "Platform macOS arm64",
          "run_id": 121825001064,
          "run_status": "in_progress",
          "status": "pending",
          "url": "https://github.com/omry/arbiter/actions/runs/40394833562/job/121825001064"
        },
        {
          "name": "Platform macOS x64",
          "run_id": 121825001016,
          "run_status": "in_progress",
          "status": "pending",
          "url": "https://github.com/omry/arbiter/actions/runs/40394833562/job/121825001016"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Python 3.10",
          "run_id": 121825001066,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/arbiter/actions/runs/40394833562/job/121825001066"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Python 3.11",
          "run_id": 121825001315,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/arbiter/actions/runs/40394833562/job/121825001315"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Python 3.12",
          "run_id": 121825000866,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/arbiter/actions/runs/40394833562/job/121825000866"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Python 3.14",
          "run_id": 121825000906,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/arbiter/actions/runs/40394833562/job/121825000906"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Python lint",
          "run_id": 121825000633,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/arbiter/actions/runs/40394833562/job/121825000633"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Website",
          "run_id": 121825000202,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/arbiter/actions/runs/40394833562/job/121825000202"
        }
      ],
      "head_sha": "d6bcb9928a780069c71b00c31ffbe52cb8b33060",
      "id": "sha256:b4b0dab5607776510460ef33c917a77656385dccf463183d543950f8f8d1f85b",
      "required_checks": [
        "Gitar",
        "Platform Linux arm64",
        "Platform Linux x64",
        "Platform Windows arm64",
        "Platform Windows x64",
        "Platform macOS arm64",
        "Platform macOS x64",
        "Python 3.10",
        "Python 3.11",
        "Python 3.12",
        "Python 3.14",
        "Python lint",
        "Website"
      ],
      "status": "pending"
    }
  ],
  "delivery_deferral_ledger_digest": "sha256:4f53cda18c2baa0c0354bb5f9a3ecbe5ed12ab4d8e11ba873c2f11161202b945",
  "delivery_deferrals": [],
  "findings": [
    {
      "disposition": "Truth fix verified: receipt-only timeout is capped at10seconds for prepared and enrolled reconciliation; 15second configured new-enrollment/prepared/enrolled resume pass real Python/Go and full7, old-source negative control fails, published exact amended head, thread resolved.",
      "evidence": [
        "https://github.com/omry/arbiter/pull/73#discussion_r4382192843",
        "/home/omry/.local/state/awd/swe-review-authority/runs/run_2cxrbaaem3mby3fxyc6d5ftecm-l01a02-f01-f02/pr73-cycle/round2/probes/old-source-15s.log",
        "sha256:21268cca88299995c3a10b2849d210560845e7c69bf638a5fae14a7536524a9b",
        "Fixed head: 8ebb7a6519f469cf8b76409fa74abbedb1083150",
        "/home/omry/.local/state/awd/swe-review-authority/runs/run_2cxrbaaem3mby3fxyc6d5ftecm-l01a02-f01-f02/pr73-cycle/round2/correction-scope-verification.json",
        "/home/omry/.local/state/awd/swe-review-authority/runs/run_2cxrbaaem3mby3fxyc6d5ftecm-l01a02-f01-f02/pr73-cycle/round2/verify-correction-result.json",
        "/home/omry/.local/state/awd/swe-review-authority/runs/run_2cxrbaaem3mby3fxyc6d5ftecm-l01a02-f01-f02/pr73-cycle/round2/sync-apply-result.json",
        "https://github.com/omry/arbiter/pull/73#discussion_r4382367245",
        "/home/omry/.local/state/awd/swe-review-authority/runs/run_2cxrbaaem3mby3fxyc6d5ftecm-l01a02-f01-f02/pr73-cycle/round2/probes/fixed-source-15s.log"
      ],
      "head_sha": "d6bcb9928a780069c71b00c31ffbe52cb8b33060",
      "id": "GH-73-4382192843",
      "invariant": "Every supported positive configured connect timeout permits authenticated exact committed receipt recovery, bounded by the existing control maximum.",
      "locations": [
        "client/go-cli/internal/cli/enrollment.go:60"
      ],
      "proposed_paths": [
        "client/go-cli/internal/cli/enrollment.go",
        "client/go-cli/internal/cli/enrollment_test.go"
      ],
      "rationale": "Independent test-only Go overlay with valid15s setting failed real Python/Go normal enrollment confirmation; DialControl immediately rejects values above10seconds. Both prepared and enrolled fallback paths forward the same uncapped configuration.",
      "response_urls": [
        "https://github.com/omry/arbiter/pull/73#discussion_r4382367245"
      ],
      "severity": "medium",
      "source": "github-review-comment",
      "status": "fixed",
      "thread_ids": [
        "PRRT_kwDOSmRaHM6wcVgT"
      ]
    },
    {
      "disposition": "Representation fix verified: release fragment is server/news/73.feature.md with original bytes and mode preserved in published exact amended head.",
      "evidence": [
        "/home/omry/.local/state/awd/swe-review-authority/runs/run_2cxrbaaem3mby3fxyc6d5ftecm-l01a02-f01-f02/pr73-cycle/scope-and-source-verification.json",
        "Fixed head: 8ebb7a6519f469cf8b76409fa74abbedb1083150",
        "/home/omry/.local/state/awd/swe-review-authority/runs/run_2cxrbaaem3mby3fxyc6d5ftecm-l01a02-f01-f02/pr73-cycle/round2/correction-scope-verification.json",
        "/home/omry/.local/state/awd/swe-review-authority/runs/run_2cxrbaaem3mby3fxyc6d5ftecm-l01a02-f01-f02/pr73-cycle/round2/verify-correction-result.json",
        "/home/omry/.local/state/awd/swe-review-authority/runs/run_2cxrbaaem3mby3fxyc6d5ftecm-l01a02-f01-f02/pr73-cycle/round2/sync-apply-result.json"
      ],
      "head_sha": "d6bcb9928a780069c71b00c31ffbe52cb8b33060",
      "id": "LOCAL-73-NEWS-001",
      "invariant": "Release fragments use an existing issue or PR number when one exists.",
      "locations": [
        "server/news/+enrollment-activation.feature.md"
      ],
      "proposed_paths": [
        "server/news/+enrollment-activation.feature.md",
        "server/news/73.feature.md"
      ],
      "rationale": "PR73 exists now; the prepublication orphan filename must use the actual number.",
      "response_urls": [],
      "severity": "low",
      "source": "local-review",
      "status": "fixed"
    }
  ],
  "pr": {
    "base_ref": "pr71",
    "base_sha": "04d468578c9219e87546944ca5bc9c64dc0a9ef8",
    "body_digest": "sha256:b39742c3c152b990ca794368da801a45300357906736a67c2c988f6c0215b417",
    "body_identity_version": 2,
    "diff_digest": "sha256:96aef93f1fcc586aa3716ecc54e76a515b24c257165e0792f33186c45936a652",
    "head_ref": "pr73",
    "head_sha": "8ebb7a6519f469cf8b76409fa74abbedb1083150",
    "pr": 73,
    "repository": "omry/arbiter",
    "scope_authority": [
      {
        "digest": "sha256:b6511414b3a9b485542df83c8f7abfc499dc8d06e522819b48e162a562d21c57",
        "path": "docs/authentication/high-level-design.md"
      },
      {
        "digest": "sha256:c576091af919c3ec99f0e0edb5795cf4e7bd37a44415ae24742393822317ad3d",
        "path": "docs/authentication/implementation-plan.md"
      },
      {
        "digest": "sha256:d56e92a7cb01f131ba499650c4a5d7b2c8d17adf2cdc7d612eee7c5f53d07929",
        "path": "docs/authentication/requirements.md"
      }
    ],
    "title_digest": "sha256:25ea8557ca1dee19e196becffc536ca8dc2b7291c4d1752b36fe9bc30cb6902d"
  },
  "record_version": 10,
  "review_observations": [
    {
      "base_ref": "pr71",
      "base_sha": "04d468578c9219e87546944ca5bc9c64dc0a9ef8",
      "evidence_digest": "sha256:46bbda55f6ab13ee8559a4d8a7064b5974d93541b241c33c4657986098dd06a3",
      "head_sha": "d6bcb9928a780069c71b00c31ffbe52cb8b33060",
      "id": "sha256:cdb2b245d226246335f26b9aafb4240c1888e1383941fbc84c584d301f0d648f",
      "poll": {
        "completed_at": "2026-10-26T20:36:04.115Z",
        "elapsed_seconds": 95.26,
        "observations": 2,
        "started_at": "2026-10-26T20:34:20.603Z"
      },
      "request_comment_id": 6426721856,
      "status": "timeout"
    }
  ],
  "review_requests": [
    {
      "base_established_at": "2026-10-26T20:21:00Z",
      "base_ref": "pr71",
      "base_sha": "04d468578c9219e87546944ca5bc9c64dc0a9ef8",
      "body_digest": "sha256:760deba08351a29cb9b860e47cf5f20b228097ca20dbaa9a3090fbe6219d1a84",
      "created_at": "2026-10-26T20:35:58Z",
      "head_sha": "d6bcb9928a780069c71b00c31ffbe52cb8b33060",
      "id": 6426721856,
      "kind": "regular-review"
    },
    {
      "base_established_at": "2026-10-26T20:21:00Z",
      "base_ref": "pr71",
      "base_sha": "04d468578c9219e87546944ca5bc9c64dc0a9ef8",
      "body_digest": "sha256:78762b207b64093ed1bfdd88119b39c326678d378458ff16fb3beed5f0c39d15",
      "created_at": "2026-10-26T20:59:42Z",
      "head_sha": "8ebb7a6519f469cf8b76409fa74abbedb1083150",
      "id": 6427192749,
      "kind": "regular-review"
    }
  ],
  "review_results": [
    {
      "base_ref": "pr71",
      "base_sha": "04d468578c9219e87546944ca5bc9c64dc0a9ef8",
      "body_digest": "sha256:95721889ecc262e3cd6b535f703a3fb4b76a378687964c870e82116427dadd24",
      "commit_id": "d6bcb9928a780069c71b00c31ffbe52cb8b33060",
      "id": 5658632206,
      "inline_message_ids": [
        4382192843
      ],
      "request_comment_id": 6426721856,
      "result_kind": "findings",
      "status": "result",
      "submitted_at": "2026-10-26T20:37:45Z",
      "unresolved_thread_ids": [
        "PRRT_kwDOSmRaHM6wcVgT"
      ]
    },
    {
      "base_ref": "pr71",
      "base_sha": "04d468578c9219e87546944ca5bc9c64dc0a9ef8",
      "body_digest": "sha256:4d26fb3db8bafc74dff63a117d24c2b39b38e0743787b473f01fab59c01c2245",
      "commit_id": "8ebb7a6519f469cf8b76409fa74abbedb1083150",
      "id": 6427221480,
      "inline_message_ids": [],
      "request_comment_id": 6427192749,
      "result_kind": "clean",
      "status": "result",
      "submitted_at": "2026-10-26T21:01:09Z",
      "unresolved_thread_ids": []
    }
  ],
  "revision_fingerprint": "sha256:b1a313864f5d9b53f3fe932a92515d39aa6d767828ce02a4bb9784b9c9fef481",
  "rounds": [
    {
      "applied_fix_paths": [],
      "disposition_changes": [],
      "effective_diff_digest": "sha256:db494e2148bbfcea2918784fec6da4f6f1f4adca581dd7cbabf606ceda4e551f",
      "finding_ids": [],
      "invariants": [],
      "outcome": "timeout",
      "proposed_fix_paths": [],
      "resulting_head": "d6bcb9928a780069c71b00c31ffbe52cb8b33060",
      "review_observation_id": "sha256:cdb2b245d226246335f26b9aafb4240c1888e1383941fbc84c584d301f0d648f",
      "review_request_id": 6426721856,
      "review_result_id": null,
      "reviewed_head": "d6bcb9928a780069c71b00c31ffbe52cb8b33060",
      "root_cause": "No attributable remote review result was observed before the bounded helper timeout. Required native CI was still pending. No finding disposition or correction is authorized by this non-result.",
      "round": 1,
      "unresolved_current_slice_findings": 0,
      "unresolved_design_blockers": 0
    },
    {
      "applied_fix_paths": [
        "client/go-cli/internal/cli/enrollment.go",
        "client/go-cli/internal/cli/enrollment_test.go",
        "server/news/+enrollment-activation.feature.md",
        "server/news/73.feature.md"
      ],
      "disposition_changes": [
        "GH-73-4382192843",
        "LOCAL-73-NEWS-001"
      ],
      "effective_diff_digest": "sha256:96aef93f1fcc586aa3716ecc54e76a515b24c257165e0792f33186c45936a652",
      "finding_ids": [
        "GH-73-4382192843",
        "LOCAL-73-NEWS-001"
      ],
      "invariants": [
        "Supported configured connect timeouts must permit bounded authenticated receipt recovery",
        "Existing PR numbers identify release fragments"
      ],
      "outcome": "corrected-head-needs-review",
      "proposed_fix_paths": [
        "client/go-cli/internal/cli/enrollment.go",
        "client/go-cli/internal/cli/enrollment_test.go",
        "server/news/+enrollment-activation.feature.md",
        "server/news/73.feature.md"
      ],
      "resulting_head": "8ebb7a6519f469cf8b76409fa74abbedb1083150",
      "review_observation_id": null,
      "review_request_id": 6426721856,
      "review_result_id": 5658632206,
      "reviewed_head": "d6bcb9928a780069c71b00c31ffbe52cb8b33060",
      "root_cause": "The CLI forwarded a valid timeout above the receipt control dial maximum to both reconciliation branches. The original prepublication release fragment still used an orphan name after PR73 was created. Minimal bounded cap and byte-preserving rename verified.",
      "round": 2,
      "unresolved_current_slice_findings": 0,
      "unresolved_design_blockers": 0
    },
    {
      "applied_fix_paths": [],
      "disposition_changes": [
        "GH-73-4382192843",
        "LOCAL-73-NEWS-001"
      ],
      "effective_diff_digest": "sha256:96aef93f1fcc586aa3716ecc54e76a515b24c257165e0792f33186c45936a652",
      "finding_ids": [],
      "invariants": [
        "Current-head required platform checks must finish successfully before approval"
      ],
      "outcome": "same-head-needs-retry",
      "proposed_fix_paths": [],
      "resulting_head": "8ebb7a6519f469cf8b76409fa74abbedb1083150",
      "review_observation_id": null,
      "review_request_id": 6427192749,
      "review_result_id": 6427221480,
      "reviewed_head": "8ebb7a6519f469cf8b76409fa74abbedb1083150",
      "root_cause": "Attributable corrected-head review is clean and all accepted fixes are verified. Native CI remains pending in the retained exact-head evidence; no correction or synchronization is required.",
      "round": 3,
      "unresolved_current_slice_findings": 0,
      "unresolved_design_blockers": 0
    },
    {
      "applied_fix_paths": [],
      "disposition_changes": [],
      "effective_diff_digest": "sha256:96aef93f1fcc586aa3716ecc54e76a515b24c257165e0792f33186c45936a652",
      "finding_ids": [],
      "invariants": [
        "Exact current candidate has clean attributable review, current full local validation and all required CI including six-native execution"
      ],
      "outcome": "clean",
      "proposed_fix_paths": [],
      "resulting_head": "8ebb7a6519f469cf8b76409fa74abbedb1083150",
      "review_observation_id": null,
      "review_request_id": 6427192749,
      "review_result_id": 6427221480,
      "reviewed_head": "8ebb7a6519f469cf8b76409fa74abbedb1083150",
      "root_cause": "Previously pending native CI completed successfully; unchanged reviewed candidate needs no further correction.",
      "round": 4,
      "unresolved_current_slice_findings": 0,
      "unresolved_design_blockers": 0
    }
  ],
  "schema": "awd:swe:pr-cycle-state",
  "version": 2
}

@omry
omry marked this pull request as ready for review October 26, 2026 20:32
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 26, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-26T21:01:11.379129Z 8ebb7a6 Manual request
🔒 Security Review ✅ Completed 2026-10-26T20:36:28.303089Z d6bcb99 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@omry

omry commented Oct 26, 2026

Copy link
Copy Markdown
Owner Author

@codex review

Exact head: d6bcb99

chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Oct 26, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d6bcb9928a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread client/go-cli/internal/cli/enrollment.go Outdated
@omry
[authentication/2.6.2] Activate enrollment and durably promote client…
8ebb7a6 
… credentials

Connect public pairing to the existing transactional activation path. Authenticate the exact committed receipt before publishing the complete private enrolled bundle, and retain same-selector recovery after ambiguous replies or interrupted publication.

Add process-kill and real Python/Go regressions for durable recovery and original-deadline reply loss or delay. Update operator guidance and release notes.

Validation: 1,610 Python unit tests passed (43 skipped), 49 Python/Go integration tests passed, Go test/vet, Pyrefly, Black and website build passed. Local DBB and fresh history-aware general reviews are clean for this candidate; native platform and installed-CLI acceptance remain separate delivery gates.
@gitar-bot

gitar-bot Bot commented Oct 26, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

🔴 High risk · Pairing now durably commits approved client identities, credentials, and grants; a mistaken approval could persist unintended service permissions.

Connects public pairing to the existing transactional activation path, authenticating the committed receipt before publishing the complete private enrolled bundle and preserving same-selector recovery after ambiguous replies or interrupted publication. No issues found.

Verification

Rules No rules evaluated

Functional validation Not enabled

Set up

For more verification details, comment gitar display:verbose.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing compact verification results.

Comment with these commands to change the behavior for this request:

Auto-apply Compact 
gitar auto-apply:on         

gitar display:verbose

Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source

@omry

omry commented Oct 26, 2026

Copy link
Copy Markdown
Owner Author

@codex review

Exact head: 8ebb7a6

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 26, 2026

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Hooray!

Reviewed commit: 8ebb7a6519

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@omry omry added the approved PR passed review and required checks label Oct 26, 2026
@omry omry mentioned this pull request Oct 27, 2026
Merged
@omry
omry merged commit 4a2adec into main Oct 27, 2026
14 checks passed
@omry
omry deleted the pr73 branch October 27, 2026 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments

Assignees

No one assigned

Labels

approved PR passed review and required checks

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@omry