Repository navigation
Conversation
Add a --controller-concurrency flag taking comma-separated name=count pairs so each controller's worker count can be tuned independently. Values feed controller-runtime's GroupKindConcurrency; unspecified controllers keep their default. Invalid input fails fast at startup. The Helm chart exposes this via manager.concurrency with equivalent validation at template-render time. Signed-off-by: sleungcy-sap <sleungcy@gmail.com>
Author
Contributor
|
@sleungcy can you please fix the linter issues? :) |
Signed-off-by: sleungcy-sap <sleungcy@gmail.com>
Signed-off-by: sleungcy-sap <sleungcy@gmail.com>
Signed-off-by: sleungcy-sap <sleungcy@gmail.com>
Contributor
|
@sleungcy Would you be able to add to the readme to explain these values? |
Signed-off-by: sleungcy-sap <sleungcy@gmail.com>
Author
|
@Skarlso please review, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Adds a
--controller-concurrencyflag so each controller's worker count can betuned independently, instead of all controllers sharing the default of one
worker. Busy controllers (e.g.
componentVersion,resource) can be scaled upwithout over-provisioning the rest.
--controller-concurrencytakes comma-separatedname=countpairs, e.g.componentVersion=4,resource=2. Unspecified controllers keep their default.Valid names:
componentVersion,resource,snapshot,localization,configuration,fluxDeployer.GroupKindConcurrency.startup.
manager.concurrency(a map), with equivalentvalidation at template-render time. Omitted/empty map emits no flag.
Which issue(s) this PR is related to