Repository navigation
Backport #154 to lyrical - #156
Merged
Merged
Conversation
Signed-off-by: HappySamuel <18137963+HappySamuel@users.noreply.github.com> Assisted-by: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit c9f7201)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: HappySamuel <18137963+HappySamuel@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
Fixes #146 on
lyrical:rewind_tasknever rewinds. Depending on the build, the fleet adapter either hangs or the task skips ahead.The cherry-pick applies cleanly. Before #154,
Task.cppandtest_Sequence.cppwere identical onjazzy,lyricalandmain, so this is the same change as onmain. The commit carries(cherry picked from commit c9f7201...).Testing
rmf_taskandrmf_task_sequenceonlyricaldiffer frommainbefore Fix Task::Active::rewind() so it actually rewinds #154 only by the GoToZone event (Add GoToZone task-sequence event #136) and version/dependency bumps, so the Fix Task::Active::rewind() so it actually rewinds #154 results onmainapply here: alltest_rmf_task_sequencetests pass, plus the rmf_demos trials in Fix Task::Active::rewind() so it actually rewinds #154.jazzy(Backport #154 to jazzy #155 ) also passes all tests.GenAI Use
We follow OSRA's policy on GenAI tools
Generated-by: Claude Code (Claude Opus 5.5) was used to cherry-pick the change, run the tests and draft this description. I reviewed the changes and results.
🤖 Generated with Claude Code