Skip to content

ci: Enhance integration test workflow with PR triggers - #2638

Merged
tylerbenson merged 1 commit into
mainfrom
Integration-tests
Oct 15, 2026
Merged

tylerbenson merged 1 commit into
mainfrom
Integration-tests

Conversation

@thompson-tomo

@thompson-tomo thompson-tomo commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Add pull request trigger for integration tests and default language input.

Note this e2e testing will only work on renovate pr's due to needing access to secrets which can not be done on pr's from forks.

Add pull request trigger for integration tests and default language input.
@tylerbenson

Copy link
Copy Markdown
Member

are you saying I should just merge this even though it failed?

@thompson-tomo

Copy link
Copy Markdown
Contributor Author

@tylerbenson yes as it is a known issue arm & ruby doesn't work. Also this branch can't be updated even if tge issue was fixed.

@thompson-tomo
thompson-tomo changed the base branch from main to renovate/lock-file-maintenance-ruby October 14, 2026 01:27
@thompson-tomo
thompson-tomo changed the base branch from renovate/lock-file-maintenance-ruby to main October 14, 2026 01:28
@github-actions github-actions Bot added ruby Pull requests that update Ruby code docker labels Oct 14, 2026
@tylerbenson

Copy link
Copy Markdown
Member

hmm. there's a conflict and it says the Integration-tests branch is protected. You able to resolve the conflict?

@github-project-automation github-project-automation Bot moved this from Todo to Need more Approval in Lambda Triage Oct 14, 2026
@github-actions github-actions Bot removed ruby Pull requests that update Ruby code docker labels Oct 15, 2026
@thompson-tomo

thompson-tomo commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor Author

@tylerbenson the branch is protected because i couldn't create it in my fork as if i did that it would result in the tests not running due to the actions requiring access to secrets. As such the only way to push to this branch is via pr's.

However I have been able to resolve the conflicts by reverting the pr which merged main via a branch containing a cherrypick and in the process it has improved the diff view.

@tylerbenson
tylerbenson merged commit 73a2ba0 into main Oct 15, 2026
92 of 95 checks passed
@tylerbenson
tylerbenson deleted the Integration-tests branch October 15, 2026 15:42
@github-project-automation github-project-automation Bot moved this from Need more Approval to Done in Lambda Triage Oct 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants