fix(sdk): catch and log unhandled exceptions in MultiSpanProcessor

[somuai]

Description

Fixes #5624

Per the OpenTelemetry specification:

• OnEnd(Span): "This method MUST be called synchronously within the Span.End() API, therefore it should not block or throw an exception."
• OnStart(Span, Context): "This method MUST be called synchronously within the Tracer.StartSpan API, therefore it should not block or throw an exception."
• Error handling: "OpenTelemetry implementations MUST NOT throw unhandled exceptions at runtime. API methods that accept external callbacks MUST handle all errors."

Previously, SynchronousMultiSpanProcessor and ConcurrentMultiSpanProcessor did not catch exceptions raised by underlying SpanProcessor instances during on_start, _on_ending, on_end, shutdown, and force_flush.

When a span processor raised in on_end during context manager exit (Span.__exit__), the exception escaped and replaced or suppressed the application's actual exception. Furthermore, a failure in an earlier processor in the list prevented subsequent processors from being called.

This change wraps calls to underlying processors in try...except Exception: blocks and logs failures via logger.exception(...), ensuring that:

1. Application exceptions are never replaced or suppressed by processor failures.
2. All registered span processors are invoked even if one throws.
3. Thread pool executor submission failures (such as during interpreter shutdown) are handled gracefully.

Type of change

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

• Added test_on_end_exception_does_not_raise to MultiSpanProcessorTestBase (runs against both Synchronous and Concurrent processors).
• Added test_on_start_exception_does_not_raise to MultiSpanProcessorTestBase.
• Added test_on_ending_exception_does_not_raise to MultiSpanProcessorTestBase.
• Added test_shutdown_exception_does_not_raise to MultiSpanProcessorTestBase.
• Added test_on_end_exception_does_not_replace_application_exception verifying that application exceptions inside with tracer.start_as_current_span(...) are properly propagated and never replaced.
• Verified all 35 tests in opentelemetry-sdk/tests/trace/test_span_processor.py pass.
• Verified ruff check passes with 0 errors.

Does This PR Require a Contrib Repo Change?

• No.

Checklist:

• Followed the style guidelines of this project
• Changelogs have been updated
• Unit tests have been added
• Documentation has been updated

[opentelemetry-pr-dashboard]

Pull request dashboard status

Waiting on reviewers · refreshed 2026-09-08 03:42 UTC

Review the latest changes.

Status above doesn't look right?

• Just replied or pushed? Anything around or after the refresh time above may not be picked up yet — give it a few minutes.
• Anything look wrong? Report it with what you expected; it helps us improve the dashboard.

[chrikrah]

I read this against the issue and ran the repro on main first, so the notes below are from the code
rather than from the description. The shape looks right to me: guarding every callback rather than
only on_end covers the case the issue's own suggested diff misses, where a ConcurrentMultiSpanProcessor
is installed at the top level and the exception escapes from future.result().

Two things I could not find a test for, both behaviour this pull request changes:

1. force_flush. A processor that raises now sets all_flushed = False and the method returns False
   instead of propagating. The other four callbacks each got a test; this one did not, and it is the
   only one of the five with a return value a caller acts on.
2. The submit side of _submit_and_await. If self._executor.submit raises, the processor is dropped
   from futures and the call continues. That is reachable at interpreter exit, where
   concurrent.futures.thread shuts its executor down in its own atexit hook before
   TracerProvider.shutdown runs, and submit then raises RuntimeError: cannot schedule new futures after shutdown.

One question rather than a request. force_flush reports failure through its return value, but
shutdown() returns nothing, so a processor that fails to shut down is now invisible to the caller.
Given the issue is about failures that happen quietly, is that asymmetry deliberate?

One thing worth stating because a reviewer might otherwise ask: the new tests sit on
MultiSpanProcessorTestBase, so both TestSynchronousMultiSpanProcessor and
TestConcurrentMultiSpanProcessor inherit them. That matters here, because the two classes fail
differently before the fix. The synchronous loop stops at the first raiser, so later processors never
run, while the concurrent one submits every future before awaiting any and only loses the results
after the first failure.

[somuai]

Thank you @chrikrah for the detailed and thorough review!

I have addressed each of the points in commit 8c3371e:

1. force_flush exception coverage: Added test_force_flush_exception_does_not_raise_and_returns_false to MultiSpanProcessorTestBase. It validates that when an underlying processor's force_flush raises an exception, the multi-processor does not propagate the exception, logs it, continues invoking subsequent processors, and returns False. Because it sits on the base test class, both TestSynchronousMultiSpanProcessor and TestConcurrentMultiSpanProcessor inherit and execute it. Additionally, updated ConcurrentMultiSpanProcessor.force_flush to ensure all_flushed = False if self._executor.submit fails during submission.
2. Submit side of _submit_and_await: Added test_executor_submit_exception_does_not_raise to TestConcurrentMultiSpanProcessor. It explicitly shuts down the underlying executor to simulate interpreter exit / post-shutdown states and validates that on_start, _on_ending, on_end, shutdown, and force_flush catch the resulting RuntimeError("cannot schedule new futures after shutdown") gracefully without raising, with force_flush returning False.
3. force_flush vs shutdown return asymmetry: The asymmetry is intentional and stems from the OpenTelemetry Specification:
   • The OpenTelemetry Trace SDK specification defines SpanProcessor.shutdown() with a void / None return type. Altering it to return a boolean would break interface parity with SpanProcessor and third-party processor implementations.
   • Conversely, the specification explicitly specifies SpanProcessor.force_flush([timeoutMillis]) as returning a boolean indicating success.
   • Catching and logging the exception with logger.exception in shutdown() ensures the failure is captured in diagnostics without deviating from the SDK interface specification.

[chrikrah]

Both land. Checked out 8c3371e and reverted only sdk/trace/__init__.py to its parent, keeping the tests:

with the change      3 passed
production reverted  1 failed, 2 passed

The one that fails is test_executor_submit_exception_does_not_raise, on RuntimeError('cannot schedule new futures after shutdown'), so the new all_flushed = False is covered.

test_force_flush_exception_does_not_raise_and_returns_false passes either way, in both subclasses. That path already swallowed a raising force_flush, so it guards existing behaviour rather than covering this diff. Both are worth keeping. Only test_executor_submit_exception_does_not_raise covers the change.