Skip to content

feat: use shared otlp types - #2236

Open
thompson-tomo wants to merge 27 commits into
open-telemetry:mainfrom
thompson-tomo:otlp_consolidation
Open

thompson-tomo wants to merge 27 commits into
open-telemetry:mainfrom
thompson-tomo:otlp_consolidation

Conversation

@thompson-tomo

@thompson-tomo thompson-tomo commented Jul 11, 2026 •

Copy link
Copy Markdown
Contributor

Progresses: #2170

This ensures all otlp exporters use the otlp-common package which has a dependency on the new types-otlp gem which is generated based on proto.

It was considered to put the types in common however that makes for difficult versioning. But more significantly by separating them, it provides an architecture which will enable us to address the current jruby limitation.

Follow up steps will be:

  • introduce otel-types-java and have common switch to this on jruby if necessary to get exporters to work on jruby
  • automating the types to be auto updated just like we do with semconv

@thompson-tomo
thompson-tomo marked this pull request as ready for review July 12, 2026 14:53
@thompson-tomo
thompson-tomo force-pushed the otlp_consolidation branch 6 times, most recently from cad2098 to 87cae52 Compare July 15, 2026 02:44
@github-actions

Copy link
Copy Markdown
Contributor

👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the keep label to hold stale off permanently, or do nothing. If you do nothing this pull request will be closed eventually by the stale bot

@thompson-tomo
thompson-tomo force-pushed the otlp_consolidation branch 2 times, most recently from 0847e29 to 1644ce4 Compare September 9, 2026 04:07
Comment thread .github/workflows/ci-semconv.yml Resolved
Comment thread types/otlp/Rakefile Resolved
Comment thread semantic_conventions/otel-spec.yaml Resolved
@thompson-tomo

thompson-tomo commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor Author

@mwear & @xuan-cao-swi just checking to see if you have any additional feedback? It would be great if possible to get it in the next release alongside the centralised encoding which is already requiring a manual bump of the gemspec dependency in 2 out of 3 affected gems.

@mwear mwear left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry this dropped of my radar. Just few more comments / questions.

Comment thread .github/workflows/release-request.yml Resolved
Comment thread .github/workflows/release-request.yml Resolved
Comment thread .github/renovate.json5 Resolved
Comment thread .github/workflows/release-request.yml Resolved
thompson-tomo and others added 2 commits October 9, 2026 03:00
Co-authored-by: Matthew Wear <matthew.wear@gmail.com>
@thompson-tomo

Copy link
Copy Markdown
Contributor Author

No worries @mwear all the changes made sense so have added them.

@thompson-tomo
thompson-tomo requested a review from mwear October 8, 2026 16:32
@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the keep label to hold stale off permanently, or do nothing. If you do nothing this pull request will be closed eventually by the stale bot

@github-actions github-actions Bot added the stale label Nov 9, 2026
@thompson-tomo

Copy link
Copy Markdown
Contributor Author

@mwear just following up on this.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants