Repository navigation
feat: use shared otlp types - #2236
thompson-tomo wants to merge 27 commits into
Conversation
ca6206d to
14904de
Compare
cad2098 to
87cae52
Compare
|
👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the |
87cae52 to
e292d4e
Compare
bfc5834 to
cd2366e
Compare
0847e29 to
1644ce4
Compare
Co-authored-by: Matthew Wear <matthew.wear@gmail.com>
|
@mwear & @xuan-cao-swi just checking to see if you have any additional feedback? It would be great if possible to get it in the next release alongside the centralised encoding which is already requiring a manual bump of the gemspec dependency in 2 out of 3 affected gems. |
mwear
left a comment
There was a problem hiding this comment.
Sorry this dropped of my radar. Just few more comments / questions.
Co-authored-by: Matthew Wear <matthew.wear@gmail.com>
|
No worries @mwear all the changes made sense so have added them. |
|
👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the |
|
@mwear just following up on this. |
Progresses: #2170
This ensures all otlp exporters use the otlp-common package which has a dependency on the new types-otlp gem which is generated based on proto.
It was considered to put the types in common however that makes for difficult versioning. But more significantly by separating them, it provides an architecture which will enable us to address the current jruby limitation.
Follow up steps will be:
automating the types to be auto updated just like we do with semconv