Conversation
open-workflow-specification/specification#1191 Signed-off-by: Cristiano Gavião <cvgaviao@gmail.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The schema, runtime implementation, and integration test consistently support the new working-directory property.
Review effort: Lite
Findings: None
What changed in this PR
Adds support for configuring a shell command’s working directory through the workflow schema and ProcessBuilder.
Changes:
- Adds the
shell.directoryschema property. - Resolves and applies the directory when executing shell commands.
- Adds a Linux integration test using
pwd.
| File | Description |
|---|---|
types/src/main/resources/schema/workflow.yaml |
Defines the shell working-directory property. |
impl/core/src/main/java/io/serverlessworkflow/impl/executors/RunShellExecutorBuilder.java |
Builds a resolver for the directory. |
impl/core/src/main/java/io/serverlessworkflow/impl/executors/RunShellExecutor.java |
Applies the directory to ProcessBuilder. |
impl/test/src/test/java/io/serverlessworkflow/impl/test/RunShellExecutorTest.java |
Tests directory execution behavior. |
impl/test/src/test/resources/workflows-samples/run-shell/pwd-directory.yaml |
Provides the directory test workflow. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
open-workflow-specification/specification#1191
Many thanks for submitting your Pull Request ❤️!
What this PR does / why we need it:
Some shell scripts use the directory where they started (the working directory) to calculate other paths relative to it.
So, we can't always use the directory where the workflow application was started as the script's working directory. If we do, the script will fail.
Java's java.lang.ProcessBuilder has an explicit method to set the working directory: directory(File directory).
Special notes for reviewers:
Additional information (if needed):