Repository navigation
Conversation
Contributor
|
/review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the nearpush side of #2: a built-in
auth-proxysender and the approval-display contract written down as a docs page.What's inside
crates/nearpushd/assets/icons/auth-proxy.svg— an original shield-with-keyhole mark for theauth-proxysender, drawn for this repo in the same rounded-square framing as the kiro icon.crates/nearpushd/src/assets.rs— registersauth-proxyinBUILTIN_ICONSnext tokiro; the existingicon_resolution_ordertest now asserts the new builtin resolves asIconSource::Builtin. User overrides in~/.config/nearpush/icons/still win, as for every sender.docs/auth-proxy.md— the integration contract from Integration: display auth-proxy approval requests as allow. cards (notification layer for require_approval) #2, in the shape ofdocs/kiro.md: nearpush is the display layer only; a parked auth-proxy request becomes anallow.card via loopbacknearpush send --sender auth-proxy --url <approval-plane link>; executed → dismiss +all_set; denied or expired → dismiss via loopbackPOST /v1/dismisswith the push token, so a dead request never lingers as actionable. The approval itself happens only on the approval plane — there is deliberately no approve action anywhere in nearpush.README.md— the/icons/<sender>entry now listsauth-proxyalongsidekiroas a built-in icon.Refs #2, openabdev/auth-proxy#5, openabdev/auth-proxy#6. Companion caller-side PR: openabdev/auth-proxy#7.