Skip to content

chore(deps): bump claude-agent-acp, claude-code and codex-acp - #1594

Closed
chaodu-agent wants to merge 1 commit into
mainfrom
chore/bump-claude-codex-acp
Closed

chaodu-agent wants to merge 1 commit into
mainfrom
chore/bump-claude-codex-acp

Conversation

@chaodu-agent

Copy link
Copy Markdown
Collaborator

Summary

Bumps three coding-CLI pins. Draft until the open items below are verified.

Package Old New Registry source
@agentclientprotocol/claude-agent-acp 0.84.0 0.99.1 npm, latest on 2026-10-31
@anthropic-ai/claude-code 2.1.284 2.1.312 npm, matched SDK version (see below)
@agentclientprotocol/codex-acp 2.0.0 2.5.0 npm, latest on 2026-10-31

Files changed

  • Dockerfile.claude: CLAUDE_AGENT_ACP_VERSION (line 32) and CLAUDE_CODE_VERSION (line 33)
  • Dockerfile.package: CLAUDE_AGENT_ACP_VERSION (line 103), CLAUDE_CODE_VERSION (line 104), CODEX_ACP_VERSION (line 123)
  • Dockerfile.unified: CLAUDE_AGENT_ACP_VERSION (line 138), CLAUDE_CODE_VERSION (line 139), CODEX_ACP_VERSION (line 158)
  • Dockerfile.codex: CODEX_ACP_VERSION (line 30)
  • .github/workflows/docker-smoke-test.yml: the assert_line for ARG CODEX_ACP_VERSION (line 210) now expects 2.5.0

Nothing else changes: no Node pin, no builder digest, no other CLI, no sha256 pin.

Why claude-code 2.1.312 and not 2.1.316

claude-agent-acp 0.99.1 bundles Claude Agent SDK 0.3.312. The SDK version tracks the CLI version (SDK 0.3.284 with CLI 2.1.284 today). Pinning 2.1.312 keeps the adapter and the CLI on the matched pair. 2.1.316 would pair the adapter with a newer CLI than its SDK, which is the untested combination that #1121 warned about. 2.1.316 is held until its matching SDK is checked.

Verification

The docker smoke test in CI is the verification for this PR. Local checks were grep only: every copy of the three pins shows the new value, and no old value remains in the edited files.

OPEN items (not claimed as done)

Review Contract

Goal

Move claude-agent-acp, claude-code and codex-acp in the three Dockerfiles to 0.99.1, 2.1.312 and 2.5.0, and keep the codex smoke-test assertion in step, so the images build and their CLI version checks pass.

Non-goals

  • No change to Node, the builder digest, other CLI pins, or sha256 pins.
  • No move to claude-code 2.1.316 (held, see above).
  • No runtime auth or login verification in this PR. Those are the OPEN items above.
  • No change to the rebase conflict with chore(deps): bump npm CLI pins to current versions #1592.

Accepted Residual Risks

  • Runtime behavior of claude-agent-acp 0.99.1 and codex-acp 2.5.0 is not exercised by the smoke test beyond version and handshake checks. Mitigation: the OPEN items (a) and (b) must be run before merge. Recovery: revert this commit to restore the previous pins.
  • The claude-code 2.1.312 Linux behavior is not checked against upstream issues #65051 and #65461. Mitigation: the matched-SDK pairing and the live run in (a). Recovery: revert the claude-code line only.
  • The global codex (0.159.0) differs from codex-acp's bundled codex (^0.165.0). Mitigation: OPEN item (b). Recovery: revert the codex-acp line.

Acceptance Criteria

  • CI docker-smoke-test and docker-smoke-test-unified pass on this PR head.
  • grep shows the new values in all copies (Dockerfile.claude, Dockerfile.codex, Dockerfile.package, Dockerfile.unified) and no old value for these three packages in the edited files.
  • Smoke-test assertion ARG CODEX_ACP_VERSION=2.5.0 passes for Dockerfile.codex, Dockerfile.package and Dockerfile.unified.
  • OPEN item (a) and OPEN item (b) are run and their results are recorded on the PR before this leaves draft.
  • OPEN item (c) is resolved by rebasing onto chore(deps): bump npm CLI pins to current versions #1592 or by merging chore(deps): bump npm CLI pins to current versions #1592 first, with the conflict resolved to keep both sets of changes.

Follow-ups

  • Re-evaluate claude-code 2.1.316 once its matching SDK version is confirmed and the upstream Linux issues are checked.
  • Consider setting NO_BROWSER=1 in the codex image, since a container has no browser. This is a suggestion, not verified.

claude-agent-acp 0.84.0 -> 0.99.1, claude-code 2.1.284 -> 2.1.312 (matched SDK; 2.1.316 held), codex-acp 2.0.0 -> 2.5.0. Verified by grep only: no old pin remains in the edited files. Docker smoke test in CI is the build verification.
@github-actions github-actions Bot added needs-rebase pending-contributor closing-soon PR missing Discord Discussion URL — will auto-close in 24 hours. labels Oct 31, 2026
@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown

Caution

This PR has been waiting on the author for more than 2 days (labeled pending-contributor since 2026-10-31).
It will be automatically closed in 24 hours if there is no update.

@chaodu-agent — You must add a new comment on this PR to remove the closing-soon label and keep it open. Pushing commits alone is not sufficient. Feel free to reopen a new PR later if it gets closed and you want to pick it back up.

@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown

🔒 Auto-closing: this PR has had the closing-soon label for more than 1 days without activity from the author.

If you'd like to continue working on this, please submit a new PR and link to this one if necessary.

@github-actions github-actions Bot closed this Nov 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

closing-soon PR missing Discord Discussion URL — will auto-close in 24 hours. needs-rebase pending-contributor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant