Repository navigation
chore(deps): bump claude-agent-acp, claude-code and codex-acp - #1594
Closed
chaodu-agent wants to merge 1 commit into
Closed
chaodu-agent wants to merge 1 commit into
chaodu-agent wants to merge 1 commit into
Conversation
claude-agent-acp 0.84.0 -> 0.99.1, claude-code 2.1.284 -> 2.1.312 (matched SDK; 2.1.316 held), codex-acp 2.0.0 -> 2.5.0. Verified by grep only: no old pin remains in the edited files. Docker smoke test in CI is the build verification.
|
Caution This PR has been waiting on the author for more than 2 days (labeled @chaodu-agent — You must add a new comment on this PR to remove the |
|
🔒 Auto-closing: this PR has had the If you'd like to continue working on this, please submit a new PR and link to this one if necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps three coding-CLI pins. Draft until the open items below are verified.
Files changed
Dockerfile.claude:CLAUDE_AGENT_ACP_VERSION(line 32) andCLAUDE_CODE_VERSION(line 33)Dockerfile.package:CLAUDE_AGENT_ACP_VERSION(line 103),CLAUDE_CODE_VERSION(line 104),CODEX_ACP_VERSION(line 123)Dockerfile.unified:CLAUDE_AGENT_ACP_VERSION(line 138),CLAUDE_CODE_VERSION(line 139),CODEX_ACP_VERSION(line 158)Dockerfile.codex:CODEX_ACP_VERSION(line 30).github/workflows/docker-smoke-test.yml: theassert_lineforARG CODEX_ACP_VERSION(line 210) now expects2.5.0Nothing else changes: no Node pin, no builder digest, no other CLI, no sha256 pin.
Why claude-code 2.1.312 and not 2.1.316
claude-agent-acp 0.99.1 bundles Claude Agent SDK 0.3.312. The SDK version tracks the CLI version (SDK 0.3.284 with CLI 2.1.284 today). Pinning 2.1.312 keeps the adapter and the CLI on the matched pair. 2.1.316 would pair the adapter with a newer CLI than its SDK, which is the untested combination that #1121 warned about. 2.1.316 is held until its matching SDK is checked.
Verification
The docker smoke test in CI is the verification for this PR. Local checks were grep only: every copy of the three pins shows the new value, and no old value remains in the edited files.
OPEN items (not claimed as done)
CLAUDE_CODE_OAUTH_TOKENauth. Related history: openab-claude:0.8.2 — CLAUDE_CODE_OAUTH_TOKEN exported by /opt/start-openab.sh no longer reaches claude-agent-acp (regressed by CLAUDE_CODE_VERSION bump 2.1.116 → 2.1.124) #707 and adapter issue docs(platforms): schema-driven platform facts knowledge base with CI conformance #1295.NO_BROWSER=1. The login path runs the globalcodex(0.159.0) while codex-acp bundles@openai/codex ^0.165.0.CODEX_ACP_VERSIONlines in the same Dockerfiles and the samedocker-smoke-test.ymlassertion area, and merges first. Expect a conflict on the codex lines.Review Contract
Goal
Move claude-agent-acp, claude-code and codex-acp in the three Dockerfiles to 0.99.1, 2.1.312 and 2.5.0, and keep the codex smoke-test assertion in step, so the images build and their CLI version checks pass.
Non-goals
Accepted Residual Risks
Acceptance Criteria
docker-smoke-testanddocker-smoke-test-unifiedpass on this PR head.grepshows the new values in all copies (Dockerfile.claude, Dockerfile.codex, Dockerfile.package, Dockerfile.unified) and no old value for these three packages in the edited files.ARG CODEX_ACP_VERSION=2.5.0passes for Dockerfile.codex, Dockerfile.package and Dockerfile.unified.Follow-ups
NO_BROWSER=1in the codex image, since a container has no browser. This is a suggestion, not verified.