Repository navigation
ci: Fix the publish loop guard and push before publishing - #517
Merged
Merged
Conversation
- Loop guard: skip runs started by openactive[bot] and add [skip ci] to the version bump commit. The previous guard checked for hello@openactive.io, but the bot has committed as 207210293+openactive[bot] since May 2025, so every bump commit started another publish. - Push the version bump before publishing, so a rejected push stops the run before anything reaches npm. Remove the postpublish git push. - Scope the dispatch token to the target repository; without owner and repositories the App token only covers this repository. - Keep publishing with the repo-level NPM_TOKEN2. - Run one publish at a time, and update actions to current versions. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
3.0.4 is already published on npm, but the version bump commit never reached GitHub because the push after publishing failed. Without this, the next release would try to publish 3.0.4 again and npm would reject it. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
hkir-dev
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes the publish workflow safe to rerun, fixes its loop guard, and brings
package.jsonback in line with npm.Changes
Publish workflow (
publish-to-npm.yaml)if:checked forhello@openactive.io, but the bot has committed as207210293+openactive[bot]since May 2025, so a successful push of the version bump would start another publish. The job now skips runs started byopenactive[bot], and the bump commit carries[skip ci], so the guard no longer depends on an email address.masterbeforenpm publish. If the push is rejected, the job stops and nothing is published, so npm cannot get ahead of GitHub. Thepostpublish: git pushscript is removed, andpublish-patchfollows the same order.ownerandrepositories,create-github-app-tokenonly covers the current repository, so dispatching todata-model-validator-siteandopenactive-test-suitecould not work. The token is now requested for each target repository.permissionsreduced tocontents: read(pushes use the App token), andrepository-dispatchupdated to v3.Version
package.jsonset to 3.0.4, which is already on npm but whose version bump never reachedmaster. Without this, the next release would try to publish 3.0.4 again.Verification
actionlint: no issues.npm version patch -m "%s [skip ci]"produces the commit message3.0.5 [skip ci], authored byopenactive[bot].When merged
Merging starts a publish: tests, bump to 3.0.5, push, publish, then dispatch to the validator site and the test suite. 3.0.5 contains the same validator code as 3.0.4. If the push to
masteris rejected, the run stops before publishing and nothing changes.