Skip to content

fix(sessions): reject blank SQLite branch names - #5179

Merged
jbeckwith-oai merged 1 commit into
mainfrom
codex/fix-blank-branch-names
Sep 25, 2026
Merged

jbeckwith-oai merged 1 commit into
mainfrom
codex/fix-blank-branch-names

Conversation

@jbeckwith-oai

Copy link
Copy Markdown
Collaborator

Summary

Reject empty and whitespace-only names before AdvancedSQLiteSession creates or switches to a branch. Both creation methods now reject names that delete_branch() cannot remove, while preserving automatic naming with None and exact padded names.

The fix adds a two-line guard, updates the method docstrings, and covers both creation entry points. Existing stored branches are unchanged.

Test plan

  • All six new regression cases fail without the guard and pass with it.
  • AdvancedSQLiteSession tests: 160 passed, including automatic and padded branch-name coverage.
  • Full verification: formatting, lint, mypy, and Pyright passed; 10,858 tests passed and 60 skipped, including configured native-macOS sandbox exclusions.
  • Independent implementation review completed with no actionable findings; final diff matches the reviewed content.

Issue number

Fixes #5178

Checks

  • I've added new tests, if relevant
  • I've run .agents/skills/code-change-verification/scripts/run.sh
  • I've confirmed all verification steps pass
  • I've completed an independent Codex code review before submitting this PR

@jbeckwith-oai
jbeckwith-oai requested review from a team, rm-openai and seratch as code owners September 25, 2026 21:52
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-25T21:54:06.301958Z fb5e288 PR opened
🔒 Security Review ✅ Completed 2026-09-25T21:54:47.674715Z fb5e288 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@seratch seratch changed the title fix(memory): reject blank SQLite branch names fix(sessions): reject blank SQLite branch names Sep 25, 2026
@jbeckwith-oai
jbeckwith-oai merged commit 588826c into main Sep 25, 2026
22 checks passed
@jbeckwith-oai
jbeckwith-oai deleted the codex/fix-blank-branch-names branch September 25, 2026 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AdvancedSQLiteSession creates branches that delete_branch can never remove (blank branch_name)

2 participants