fix(sandbox): preserve nested paths in workspace snapshots - #5189
Merged
Merged
Conversation
jbeckwith-oai
requested review from
a team,
rm-openai and
seratch
as code owners
September 27, 2026 16:54
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
seratch
approved these changes
Sep 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes silent loss of nested durable files in Daytona, Blaxel, and E2B tar snapshots. Excluding an ephemeral
data/directory currently also dropsapp/data/; archive exclusions now use only the workspace-rooted./datapattern.Workspace fingerprints use the same corrected matching for newly saved snapshots. Existing
workspace_tar_sha256_v1records are compared using their original exclusions before deciding whether to clear a preserved live workspace, preventing an upgrade from replacing surviving files with an incomplete legacy snapshot. The next save writes the corrected archive and a v2 fingerprint together.This change targets the Linux tar backends in the issue. BSD tar has different exclusion semantics; its pre-existing fingerprint behavior is unchanged. The fix cannot recover bytes already omitted from an old snapshot after the live sandbox is lost.
Test plan
The new Linux tar regressions are skipped on this macOS host and run in Linux CI. Native macOS sandbox tests run in the repository's dedicated CI job.
Issue number
Closes #5184
Checks
.agents/skills/code-change-verification/scripts/run.sh