Repository navigation
ci: bump actions, move golangci-lint to lint.yml - #1329
Merged
Merged
Conversation
This also gets rid of the "Node.js 20 is deprecated" warnings. Since v6, actions/setup-go sets GOTOOLCHAIN=local for all subsequent steps, so we no longer need to set it explicitly. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
kolyshkin
requested review from
AkihiroSuda,
crosbymichael,
cyphar,
dqminh,
giuseppe,
hqhq,
mrunalp,
thaJeztah,
tianon and
utam0k
as code owners
October 13, 2026 16:19
kolyshkin
force-pushed
the
golangci-lint-yml
branch
from
October 13, 2026 16:20
b82c916 to
5d558f2
Compare
The "test" target depends on .golint, which was removed by commit 15d2a5a ("Switch Go linting to use golangci-lint"), so "make test" fails with: make: *** No rule to make target '.golint', needed by 'test'. Stop. Since CI does not use it, and it makes little sense locally, remove it. The .govet target is redundant, since golangci-lint's govet linter runs all the "go vet" analyzers (and also checks schema/validate, which .govet does not). Remove it, and its use from CI. Remove HOST_GOLANG_VERSION and ALLOWED_GO_VERSION variables, which were only used by the (removed) .golint target. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Add a "lint" target which runs golangci-lint for both the main module and schema/validate. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Running golangci-lint for every Go version in the build matrix is redundant, as the results are the same. Move it to a separate job in lint.yml, so it runs once. Pin the Go version to the one golangci-lint v2.14 is built with (1.27), rather than using "stable", so that a new Go release does not unexpectedly break the linter; bump both versions together. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
kolyshkin
force-pushed
the
golangci-lint-yml
branch
from
October 13, 2026 16:25
5d558f2 to
8806527
Compare
thaJeztah
reviewed
Oct 13, 2026
AkihiroSuda
approved these changes
Oct 14, 2026
Member
|
Nice one GitHub, nice; schrödingers state; 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump actions/checkout and actions/setup-go to v7. This gets rid of
the "Node.js 20 is deprecated" warnings. Since setup-go v6 sets
GOTOOLCHAIN=localitself, drop it from build.yml.Makefile: remove
test,.govet, and unused variables. Thetesttarget depends on
.golint, which was removed in 2023, somake testis broken; it is not used by CI either.
.govetis redundant, sincegolangci-lint's govet linter runs all the
go vetanalyzers (andalso checks schema/validate).
Makefile: add
linttarget, which runs golangci-lint for both themain module and schema/validate.
Move golangci-lint from build.yml (where it runs for every Go version
in the matrix) to a single job in lint.yml, which runs
make lint.The Go version is pinned to 1.27, which golangci-lint v2.14 is built
with; the two should be bumped together.