Conversation
|
I would rather address this by moving to new terminology and marking old flags as deprecated (old wording in a tooltip).
Deprecated flags can be dropped in next major version. |
Retain legacy flags and INI compatibility; synchronize dialog terminology and add CPU configuration tests. AI-assisted contribution.
|
@qu1ck Updated in 716d0c1. Added --no-filter-excluded and --filter-excluded; the old --*blacklist-virtual flags are deprecated aliases and remain supported. Existing INI keys, default filtering and last-option-wins behavior are preserved. The checkbox now reads “Filter excluded components”; its tooltip retains the old wording and explains modern KiCad exclusion versus the Virtual attribute used by older KiCad/other parsers. FormBuilder and generated Python match. Seven CPU unit tests and headless CLI --help pass. I couldn't test the KiCad/wxPython GUI or KiCad integration locally. This is an AI-assisted contribution. |
AI-assisted contribution related to #561, updated in response to maintainer feedback. Current implementation: 716d0c1.
Summary
--no-filter-excludedand--filter-excluded, with help explaining modern KiCad's Exclude from BOM setting and the Virtual attribute used by older KiCad versions and other parsers.--no-blacklist-virtualand--blacklist-virtualsupported as deprecated aliases, with help naming their replacements.Validation
--helprendered successfully. The existing module-import test was also invoked directly in headless CLI mode.main()with PCB parsing and output generation stubbed, checking INI loading and mixed flag ordering.git diff --checkpassed.Verification limits
KiCad/pcbnew and wxPython were unavailable locally. KiCad 8/9 board integration, actual GUI rendering and the full upstream hatch/pytest suite were not run locally. wxFormBuilder source/generated text was synchronized manually and checked statically; wxFormBuilder regeneration was not run.
The immediately checked upstream Test workflow for this head stopped at
action_requiredwith zero jobs executed. Full upstream CI remains unverified.