OCPBUGS-115007: Remove BootImageSkewEnforcement feature gate from Default API

[proietfb]

As part of OCPBUGS-105412 this PR has the meaning of removing BootImageSkewEnforcement default api gate.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@proietfb: This pull request references Jira Issue OCPBUGS-115007, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.1.0) matches configured target version for branch (5.1.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

As part of OCPBUGS-105412 this PR has the meaning of removing BootImageSkewEnforcement default api gate.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Hello @proietfb! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Advanced

Run ID: acafa028-7029-413e-8b70-3ce9d4a3465b

📥 Commits

Reviewing files that changed from the base of the PR and between 6733660 and 93c1e0d.

📒 Files selected for processing (10)

• features.md
• features/features.go
• payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-DevPreviewNoUpgrade.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-TechPreviewNoUpgrade.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-DevPreviewNoUpgrade.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-TechPreviewNoUpgrade.yaml

💤 Files with no reviewable changes (10)

• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-TechPreviewNoUpgrade.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-DevPreviewNoUpgrade.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-DevPreviewNoUpgrade.yaml
• features/features.go
• features.md
• payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-TechPreviewNoUpgrade.yaml

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.

---

📝 Walkthrough

Walkthrough

The change removes BootImageSkewEnforcement from the feature gate registry and feature gate documentation. It also removes the gate from the enabled lists in all 4.10 HyperShift and SelfManagedHA profiles: Default, DevPreviewNoUpgrade, OKD, and TechPreviewNoUpgrade.

Merge Risk: ⚪ Minimal · up to 93c1e

This change removes BootImageSkewEnforcement from the registry, documentation, and listed 4.10 profiles. No unresolved production or correctness risk is identified, so it is mergeable with normal checks.

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the removal of the BootImageSkewEnforcement feature gate from the Default API. It matches the primary objective of the changeset.
Description check	✅ Passed	The description directly relates the changeset to removing the BootImageSkewEnforcement default API gate and references the associated issue.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The pull request only deletes the BootImageSkewEnforcement declaration, documentation row, and manifest entries. The authoritative diff contains no added lines and no changes to Ginkgo test titles s…
Test Structure And Quality	✅ Passed	PASS: The custom check is not applicable. The pull request changes only feature-gate documentation, Go registration data, and YAML manifests. The authoritative diff contains no Ginkgo test code or cha…
Microshift Test Compatibility	✅ Passed	The pull request adds no Ginkgo tests and changes no test files. The diff only removes the BootImageSkewEnforcement feature gate from documentation, Go registration, and feature-gate manifests. Ther…
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The pull request changes only feature-gate documentation, Go registration data, and YAML manifests. The authoritative diff contains no added Go test files or Ginkgo constructs such as It, Describe, Co…
Topology-Aware Scheduling Compatibility	✅ Passed	PASS. The authoritative PR diff contains only deletions of the BootImageSkewEnforcement feature-gate declaration, documentation row, and feature-gate manifest entries. The changed lines add no deplo…
Ote Binary Stdout Contract	✅ Passed	PASS: The pull request only removes a feature-gate declaration, documentation, and YAML entries. The authoritative diff contains no additions and does not change any OTE process-level code such as mai…
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The pull request adds no Ginkgo e2e tests or other test files. The authoritative diff contains only deletions from feature documentation, feature-gate registration, and YAML manifests. Therefore, the …
No-Weak-Crypto	✅ Passed	PASS. The authoritative PR diff changes only 10 feature-gate documentation, registration, and YAML manifest files. It contains 33 deletions and no additions. The deleted content only removes `BootImag…
Container-Privileges	✅ Passed	The pull request only deletes the BootImageSkewEnforcement feature-gate declaration and entries from feature-gate lists. The review-scoped diff has 33 deletions and no additions. It contains no privil…
No-Sensitive-Data-In-Logs	✅ Passed	PASS. The reviewed range contains 10 modified files and 33 deletions, with zero added lines. The diff only removes the BootImageSkewEnforcement feature-gate declaration and manifest/documentation en…

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[proietfb]

/hold

Hold until openshift/machine-config-operator#6522 has been merged

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@proietfb: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/verify	93c1e0d	link	true	/test verify
ci/prow/images	93c1e0d	link	true	/test images
ci/prow/integration	93c1e0d	link	true	/test integration

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.