Skip to content

CORENET-7538: Add EgressIPNodeSelector feature gate - #3032

Merged
openshift-ci[bot] merged 1 commit into
openshift:masterfrom
tssurya:add-egressip-node-selector-feature-gate
Sep 11, 2026
Merged

CORENET-7538: Add EgressIPNodeSelector feature gate#3032
openshift-ci[bot] merged 1 commit into
openshift:masterfrom
tssurya:add-egressip-node-selector-feature-gate

Conversation

@tssurya

@tssurya tssurya commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Introduce the EgressIPNodeSelector feature gate for the ovn-kubernetes networking component, enabled in DevPreviewNoUpgrade and TechPreviewNoUpgrade feature sets.

Enhancement: ovn-kubernetes/ovn-kubernetes#6801

Introduce the EgressIPNodeSelector feature gate for the
ovn-kubernetes networking component, enabled in DevPreviewNoUpgrade
and TechPreviewNoUpgrade feature sets.

Enhancement: ovn-kubernetes/ovn-kubernetes#6801

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 10, 2026
@openshift-ci-robot

openshift-ci-robot commented Sep 10, 2026

Copy link
Copy Markdown

@tssurya: This pull request references CORENET-7538 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.1.0" version, but no target version was set.

Details

In response to this:

Introduce the EgressIPNodeSelector feature gate for the ovn-kubernetes networking component, enabled in DevPreviewNoUpgrade and TechPreviewNoUpgrade feature sets.

Enhancement: ovn-kubernetes/ovn-kubernetes#6801

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Hello @tssurya! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 10, 2026
Comment thread features/features.go
@everettraven

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change
/test minor-e2e-upgrade-minor

@openshift-ci

openshift-ci Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: everettraven

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 10, 2026
@tssurya

tssurya commented Sep 10, 2026

Copy link
Copy Markdown
Contributor Author

/lgtm /approve

btw @everettraven did I mention that your response time on PRs in this repo always amazes me? :) I guess you and Joel both rock and not sure how you can have such a good turn around time on some of these PRs. thanks for the review

@tssurya

tssurya commented Sep 10, 2026

Copy link
Copy Markdown
Contributor Author

/test images

@tssurya

tssurya commented Sep 10, 2026

Copy link
Copy Markdown
Contributor Author

/verified by CI

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Sep 10, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@tssurya: This PR has been marked as verified by CI.

Details

In response to this:

/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@tssurya

tssurya commented Sep 10, 2026

Copy link
Copy Markdown
Contributor Author

/retest-required

1 similar comment
@tssurya

tssurya commented Sep 10, 2026

Copy link
Copy Markdown
Contributor Author

/retest-required

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 6733660 and 2 for PR HEAD 1ce44c8 in total

@tssurya

tssurya commented Sep 11, 2026

Copy link
Copy Markdown
Contributor Author

/retest-required

1 similar comment
@tssurya

tssurya commented Sep 11, 2026

Copy link
Copy Markdown
Contributor Author

/retest-required

@tssurya

tssurya commented Sep 11, 2026

Copy link
Copy Markdown
Contributor Author

/test e2e-azure

@openshift-ci

openshift-ci Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

@tssurya: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci
openshift-ci Bot merged commit c1fd425 into openshift:master Sep 11, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants