Skip to content

OCPBUGS-114428: Bump google.golang.org/protobuf to v1.36.12 - #558

Open
redhat-chai-bot wants to merge 1 commit into
openshift:mainfrom
redhat-chai-bot:bot/ocpbugs-114428-protobuf-v1.36.12
Open

redhat-chai-bot wants to merge 1 commit into
openshift:mainfrom
redhat-chai-bot:bot/ocpbugs-114428-protobuf-v1.36.12

Conversation

@redhat-chai-bot

@redhat-chai-bot redhat-chai-bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Bump google.golang.org/protobuf to v1.36.12. Dependency-only; no builder or unrelated changes. Validation passed; changes are limited to go.mod and go.sum.


AI-generated. Review for accuracy.

@Prashanth684 requested in Slack thread

Warning

Content scanning did not attest this change.
The scanner could not produce a verdict for the pushed content (never_attempted), so it has not been checked for credentials or malware.
Content scanning currently fails open, so this did not hold the change request for review — please review the diff with that in mind.

Summary by CodeRabbit

  • Chores
    • Updated the indirect Protocol Buffers dependency to version 1.36.12.

@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Sep 14, 2026
@coderabbitai

coderabbitai Bot commented Sep 14, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: a200961b-6e0a-4167-b1c0-be4529165d09

📥 Commits

Reviewing files that changed from the base of the PR and between c71e860 and 66091ce.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • go.mod

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

The pull request updates the indirect google.golang.org/protobuf dependency from v1.36.2 to v1.36.12 in go.mod.

Changes

Protobuf dependency update

Layer / File(s) Summary
Update protobuf requirement
go.mod
The indirect google.golang.org/protobuf requirement changes from v1.36.2 to v1.36.12.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 66091

The protobuf dependency update introduces no identified current-head risk and is ready to merge after normal checks.

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely identifies the tracked protobuf dependency update to version v1.36.12.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The review-scoped diff changes only go.mod and go.sum. It updates google.golang.org/protobuf from v1.36.2 to v1.36.12 and adds the matching checksums. No Go test files or Ginkgo test declaration…
Test Structure And Quality ✅ Passed PASS — the reviewed range changes only go.mod and go.sum. It updates google.golang.org/protobuf from v1.36.2 to v1.36.12 and adds the matching checksums. No Ginkgo test code or test behavior cha…
Microshift Test Compatibility ✅ Passed PASS: The pull request changes only go.mod and go.sum. The diff contains no Go files or test-like paths, and it adds no Ginkgo e2e tests. Therefore, the MicroShift test compatibility check is not appl…
Single Node Openshift (Sno) Test Compatibility ✅ Passed PASS: The review-scoped diff changes only go.mod and go.sum. It updates google.golang.org/protobuf from v1.36.2 to v1.36.12 and adds the matching checksums. No Go source files or new Ginkgo tests were…
Topology-Aware Scheduling Compatibility ✅ Passed PASS: The authoritative pull-request diff changes only go.mod and go.sum. It updates google.golang.org/protobuf from v1.36.2 to v1.36.12 and adds the corresponding checksums. No deployment m…
Ote Binary Stdout Contract ✅ Passed PASS. The pull request changes only go.mod and go.sum, updating google.golang.org/protobuf from v1.36.2 to v1.36.12. It adds no process-level Go code, suite setup, logging configuration, or stdo…
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The pull request changes only go.mod and go.sum. It adds no Go files, Ginkgo tests, or test network behavior. Therefore, the IPv6 and disconnected network compatibility check is not applicable.
No-Weak-Crypto ✅ Passed The reviewed range changes only go.mod and go.sum: google.golang.org/protobuf moves from v1.36.2 to v1.36.12, with checksum updates. No changed source file adds weak crypto, custom crypto, or se…
Container-Privileges ✅ Passed The pull request changes only go.mod and go.sum. The diff updates google.golang.org/protobuf from v1.36.2 to v1.36.12 and adds its checksums. It does not change a Dockerfile, Kubernetes manifest…
No-Sensitive-Data-In-Logs ✅ Passed PASS. The review diff changes only the indirect google.golang.org/protobuf version in go.mod and its checksums in go.sum. No application source, logging calls, or log messages changed. The PR do…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

Some tools did not complete. Review the errors below.

🔧 golangci-lint (2.13.2)

level=error msg="Running error: context loading failed: no go files to analyze: running go mod tidy may solve the problem"


Comment @coderabbitai help to get the list of available commands.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Sep 14, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@redhat-chai-bot: This pull request references Jira Issue OCPBUGS-114428, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Bump google.golang.org/protobuf to v1.36.12. Dependency-only; no builder or unrelated changes. Validation passed; changes are limited to go.mod and go.sum.


AI-generated. Review for accuracy.

@Prashanth684 requested in Slack thread

[!WARNING]
Content scanning did not attest this change.
The scanner could not produce a verdict for the pushed content (never_attempted), so it has not been checked for credentials or malware.
Content scanning currently fails open, so this did not hold the change request for review — please review the diff with that in mind.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci

openshift-ci Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

@redhat-chai-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 66091ce link false /test security
ci/prow/okd-scos-images 66091ce link true /test okd-scos-images
ci/prow/images 66091ce link true /test images
ci/prow/verify-deps 66091ce link true /test verify-deps
ci/prow/unit 66091ce link true /test unit

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci

openshift-ci Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: redhat-chai-bot
Once this PR has been reviewed and has the lgtm label, please assign sayan-biswas for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants