Skip to content

tests: five adopt tests are weaker than they read: text on stdin, a stub gh written with write_text, GIT_ALLOW_PROTOCOL not cleared, two guard pairs that mask each other, and one name shape in the naming test #916

Closed

Description

@brettheap

Goal: each adopt test named here fails when the thing it guards is removed, on every OS and environment the suite runs in.

Filed by lane openRepoShape-3, from its triage of #457 at the v1.1.1 release commit 5017830. It groups #457's lines L4-54, L1-60, L1-62, L1-K6 and L2-91, one pull request's worth. None is a product bug.

State at 5017830. Read, not run.

Direction.

  • Feed bytes on stdin.
  • Write the stub as bytes.
  • monkeypatch.delenv("GIT_ALLOW_PROTOCOL", raising=False).
  • Give each guard a test that reaches it alone, or keep one guard of each pair.
  • Parametrize the naming test over openDo{c}x and Med{c}xScribe as well.

Size: M.

Lane: openreposhape-3 (openRepoShape-3)

Activity

  1. added this to the v1.2.0 milestone on Oct 18, 2026
  2. brettheap commented on Oct 20, 2026

    @brettheap
    ContributorAuthor

    CLAIMED — lane openRepoShape-3, session b30e8b49-f249-4668-adb1-1dbfa93c09e1@Eagle, 2026-10-20T17:22:46Z, for #916

    Logged in lanes/log/openRepoShape-3.md at 46585e5f7641627fc92916c0582f78b7f5034ee9.

    The three reads (lane-collision-protocol Rule 1):

    1. existing `CLAIMED —` comments on opensoft/openRepoShape#916:
       none
    2. `gh pr list --repo opensoft/openRepoShape --state all --search "#916"`, kept where the row or its body names `#916`:
       none
    3. `git ls-remote --heads git@github.com:opensoft/openRepoShape` branches naming `916` as a whole token:
       none
    
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions