Skip to content

test_update_shape_pin_source.py: the row that compares an in-process check with a subprocess one unsets LANES_LANE in its own process, as run blanks it for the child, so a lane in the shell no longer puts a --trailer on one answer (#1299) #1303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
brettheap wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

test_update_shape_pin_source.py: the row that compares an in-process check with a subprocess one unsets LANES_LANE in its own process, as run blanks it for the child, so a lane in the shell no longer puts a --trailer on one answer (#1299) #1303

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9012067
test_update_shape_pin_source.py: the row that compares an in-process …
Nov 10, 2026
64154fe
test_update_shape_pin_source.py: the comment on the row's `delenv("LA…
Nov 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions tests/test_update_shape_pin_source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,6 +431,16 @@ def opening(spec, *_pin_path):
return real(str(upstream_and_project["upstream"]))

monkeypatch.setattr(update_shape, "open_upstream", opening)
# THIS PROCESS READS `LANES_LANE`, THE CHILD READS A BLANK (#1299).
# `update_shape.main` prints its NEXT through `lane_trailer_argument`,
# which reads this process's environment. This module's `run` goes
# through `conftest.run_script`, which blanks the child's lane. In a
# shell that exports one, only the in-process NEXT ended
# `--trailer 'Lane: <lane>'`, and the two answers differed by that
# alone. Unset is no lane, as the blank is: the two read the same. With
# the guard in place the child gets no lane even without that blank,
# because `run_script` copies `os.environ` after the guard has run.
monkeypatch.delenv("LANES_LANE", raising=False)
code = update_shape.main(["check", "--root", str(root)])
out = capsys.readouterr().out
passed = run(root, "check", *upstream_of(upstream_and_project))
Expand Down
Loading