[brettheap]

Lane: openreposhape-5 (openRepoShape-5)
Claim: #307 (comment)

What was wrong

family.py init rendered templates/family-root/family.yaml from --id, --org, --name, --created-by, --created-on and --tracking-branch and pushed it. The holder reads that file with its own YAML reader and its own scripts/validate-family.py, and init asked neither anything. Every row of #307 reproduces on c7c02fa (the issue's own script, with a stub gh): --dry-run and the real run both exit 0 for all 15 rows, and

• --created-by ' ', --created-on 20261011 / 2026-W41-6 / tomorrow, --id null|true|false, --org null, --name 'Contoso Group' leave a holder whose validate-family.py exits 1 from its first commit. init cannot be run again over it (family-remote-exists, no --force).
• --tracking-branch true, 007, null, 2026 exit 0 with validate-family.py exit 0 (it has no rule about tracking_branch), the holder pushed on that branch, family.yaml reading back as True, 7, None, 2026, and update-shape.py apply --branch printing gh pr create --base True / --base 7 / --base main (for null) / --base 2026.

What changed

scripts/family.py asks two questions about the manifest init is about to write, right after the substitution table is built: before the plan is printed, before the --dry-run return, before _create_holder_remote (which is where gh repo create runs against GitHub). Both refuse, name the flag, and say nothing was created.

• family_manifest_misreads renders each line of the TEMPLATE that carries one of the values, reads it back with the holder's own reader (repo_shape.parse_yaml) and refuses a value that does not come back as the same text: family-manifest-misread. This is what catches --id null, --org null, --created-on 20261011 and the silent --tracking-branch true|007|null|2026. A line the refusal quotes is shown the way Python spells it where it holds a line break or an escape, so a value cannot forge a second line of the refusal.
• family_manifest_invalid renders the whole family.yaml and runs the validator the template ships over it, loaded from templates/family-root/scripts/validate-family.py (Report and _check_envelope), never re-implemented: family-manifest-invalid, in the validator's own words. This is what catches a blank --created-by, --created-on 2026-W41-6 / tomorrow and --name 'Contoso Group', and whatever the validator learns next. A misread is reported first and alone, because the validator's finding about it (id is None) is its consequence. A validator that is missing, broken, raising or exiting, whose Report has no findings, or that answers with a finding that is not text, is family-validator-unusable, not a traceback and not a zero.
• A value no flag supplied is named by where it came from (--id (not given, so --family lowercased)).
• init --help and docs/cli.md (regenerated, render-cli-reference.py --check ok) say what is held to what.

No template is edited. A refused value is refused, not quoted or corrected.

Fix round 1 (review of 14e2d68)

The first review found one broken test elsewhere in the suite and four claims no test guarded. This round is one commit on top of 14e2d68 (tests, plus one change to scripts/family.py for the validator that cannot be asked); the first commit is not amended.

• tests/test_stdout_encoding.py (the blocker). The family-init-dry-run row ran init --name <non-ASCII> --dry-run and asserted the name is printed in the plan. The holder's own validate-family.py refuses that name (naming-unclassified: a family holder is one CamelCase token), so init now refuses it before the plan prints. That is this PR working as intended, so the TEST changed and the refusal did not: the row drops --name. The plan still prints the non-ASCII --created-by on its created by line, so the constrained stdout still has a value to escape (created by 日本 ... under cp1252, the characters themselves under UTF-8), and the row still fails if family.py main stops calling escape_what_stdout_cannot_encode. On the first head the old row failed (1 failed); the row as it is now passes on this head, and on this head merged with origin/main.
• A validator that cannot be asked. The in-process call now sits in one try that also catches SystemExit and reads report.findings there, and a finding that is not text is refused by name. Three cases used to escape the refusal: a Report with no findings (an AttributeError traceback), a finding that is not a string (a TypeError from the regular expression) and a _check_envelope that calls sys.exit(0) (init exited 0, having printed and created nothing). Each is now family-validator-unusable, exit 2, nothing created; one test per case over a deliberately broken copy of the template, and one run at the command line for the exit.
• _line_shown. A value with a line break, an ESC and a would-be forged line (x\nFINDING forged: y\x1b[2J, and a CR, U+2028 and U+0085 variant) is one escaped sentence: asserted on family_manifest_misreads itself, through main and what it prints (in process, so no argv crosses to Windows), and at the command line (skipped on Windows before any call, since argv is UTF-16 there; the in-process rows hold it on every OS).
• Two more guarded hunks. The sys.path restore (also when the validator fails to load) and the comment-line skip each had a surviving mutant; each now has a test that kills it. The bytecode flag's restore is guarded by the same tests.
• The bytecode test asked the REAL template's __pycache__ before and after, so any stale validate-family*.pyc there failed it whatever the code did. It runs over a copy of the template made without a __pycache__, with the flag cleared first so that it is family_validator that must set it, and a control shows that importing the same file that way does write a .pyc.

How this composes with #259 (Brett ruled QUOTE)

The misread check never says which lines are bare: it renders the real template line and reads it back. So once fix/template-quoted-placeholders (233dc71) quotes id:, org:, created_on:, visibility: and tracking_branch:, --id null, --org null and --tracking-branch true|007|null|2026 read back exactly, the first question refuses nothing, and no edit is needed here. What the validator refuses stays refused: --created-on 20261011 becomes family-manifest-invalid (family-created-on) instead of a misread, and a blank --created-by and --name 'Contoso Group' are unchanged. Proved three ways, all in tests/test_family_init_values.py:

• the same values through a copy of the template with the placeholder forced quoted: accepted, and parse_yaml(render(...)) reads the exact text back;
• an end-to-end run of a forged one-commit checkout of scripts/, templates/ and contracts/ whose family.yaml is forced quoted: init exits 0, the holder's own validate-family.py exits 0, family.yaml reads back as typed, and the branch pushed is the typed one (a second forged checkout forced bare: refused, nothing created);
• the tests that read the real template's own quoting to say what to expect: run here with the real template as it is, and on a tree with templates/assembly-root/project.yaml and the two leg pins write eight text placeholders bare (id, elected_on, visibility, tracking_branch, the two leg paths and submodule_paths), so a checked value YAML reads as another type (007, 2026, true, null) is misread by the project or refused by the tool; quoting them reads every one back exactly and lets numeric branch names adopt #259's branch merged in (below), so the file stays green whichever of this and templates/assembly-root/project.yaml and the two leg pins write eight text placeholders bare (id, elected_on, visibility, tracking_branch, the two leg paths and submodule_paths), so a checked value YAML reads as another type (007, 2026, true, null) is misread by the project or refused by the tool; quoting them reads every one back exactly and lets numeric branch names adopt #259 lands first.

When #259 lands after this, 19 rows skip for good and one sentence goes unreached. With the template quoted, the 16 end-to-end rows of test_init_asks_the_holders_own_programs_before_anything_is_created whose quoted answer is "the run is fine" and the 3 of test_an_id_the_family_name_would_derive_is_named_by_where_it_came_from skip with a message that says why (the 8 test_a_quoted_value_is_held_as_typed rows un-skip and pass), and nothing fails. MANIFEST_MISREAD_REMEDIATION's "family.yaml writes a value like these unquoted" is then text no real template reaches; a template that writes one bare (the forged bare checkout the tests use) still does. Nothing is changed here for it: whichever of this and #259 lands second can drop the dead rows and reword that sentence in the same PR.

Same helpers as #314 (#261)?

#314's manifest_misreads / manifest_invalid are hard-wired to the assembly root (project.yaml, its templated list, validate-manifest.py's _findings) and are not on main, so this PR writes the smallest version the family needs, in scripts/family.py (not shape_materialize.py, which #266, #270, #314 and #316 all edit). They differ only in the template, the validator's entry point and the sentence that names the file; whichever of this PR and #314 lands second unifies them.

Evidence

Refreshed when this PR was opened (head abb27e6). Main has moved to 28bdc84: #345 landed as 3ae0109, #350 as 0f67f7b, and lane 3's single-repository.yaml as 28bdc84. The review's re-verify of abb27e6 ran on the head merged with 28bdc84: clean, with the six init, encoding, CLI-reference and family files at 305 passed / 9 skipped, and test_family.py with #345's test_family_dry_run.py at 126 passed. Merge-tree is also clean against #259's 3894aa8 (PR #395) and #314's 4b8da3d. The results below were taken before that.

• Reproduction, before and after, with the issue's script: on c7c02fa every row exits 0; on this branch all 13 failing rows now exit 2 on --dry-run and on the real run, with no holder, no remote directory and nothing pushed; the two controls (--tracking-branch main, --name ContosoGroup) are unchanged. --tracking-branch 2026 is refused too, as scaffold-project.py and adopt-project.py ask the project's YAML reader and validate-manifest.py about the manifest's values before anything exists, so --id null, --tracking-branch true and a blank --elected-by are refused (#258, #261) #314 does for the scaffold: it worked only because every reader calls str() on the number.
• tests/test_family_init_values.py: 125 tests, 103 of them fail on c7c02fa; on this branch 117 pass and 8 skip (the 8 rows that need the real template to be quoted, which they run against the day it is). On 14e2d68, the first head, the 4 tests of this round that guard a code change are the ones that fail (the three validator cases and the exit at the command line); the rest guard what 14e2d68 already did.
• Mutations: fifteen of the change in the first round (drop the call, move it after the --dry-run return, move it after the remote is created, empty either question, ignore the template's quoting, ignore the template's validator, drop the not-given naming, drop a finding no flag owns, write bytecode into the template, let a validator's SystemExit through at load, ask the validator first, drop the unusable-validator checks), and eight more in this round, each killed by a new test: _line_shown always in backticks (9 fail), the sys.path restore dropped (2), the bytecode flag's restore dropped (2), the comment skip dropped (1), findings read outside the try (1), the non-text check dropped (1), SystemExit let through the run (2, one a zero at the command line), and main without escape_what_stdout_cannot_encode (the family-init-dry-run row of test_stdout_encoding.py). The write-bytecode mutation is now killed by the new bytecode test.
• Targeted runs on the head of this branch (Linux, Python 3.12.3, git 2.43.0, git-filter-repo 2.47.0): test_family_init_values.py test_family.py test_stdout_encoding.py test_cli_reference.py: 276 passed, 9 skipped (the 8 rows that need a quoted template, and one Windows-only row).
• Merged with origin/main at 161c6c9 (which has shape_materialize.py: render substitutes in one pass and refuses only a placeholder its table lacks, so --elected-by '{{SPEC_PATH}}' is no longer recorded as spec and {{NOPE}} no longer refuses after the legs are pushed (#260) #316, family.py: add refuses member-path-registered when a .gitmodules section under another name already gives the mount path, and validate-family.py finds gitmodules-path-twice, so add no longer commits two sections for one path that a recursive clone resolves to the later one, and a holder that already has such a ghost section fails its own gate (#300) #317, family.py: add asks the holder's index for the mount path in any case, so an entry Members/Atlas/README is refused as member-path-taken before anything is cloned instead of leaving the member's 19 files staged under it, and a refused add says the holder is exactly as it was only when the whole index is as it was (#302) #318, adopt-project.py: a relative .gitmodules url the plan keeps in a leg is resolved from the source's remote and from the leg's, and where the two differ check finds it and execute refuses before any leg exists, so a recursive clone no longer fails after adoption verified (#190) #245 and tests/conftest.py: a session gh guard first on PATH answers the doctor's two machine-row probes as a gh with no login and fails any test whose other calls it refused, so no test reaches the operator's gh and the row is still tested, and refusing_network's four users assert on the calls its gh logged rather than on a stderr the preflight captures (#296) #349): test_family_init_values.py test_family.py test_family_add_refusals.py test_family_add_excludes.py test_family_member_path.py test_stdout_encoding.py test_cli_reference.py 407 passed, 9 skipped; test_shape_doctor.py 255 passed, 3 skipped (the PowerShell row, which needs a Windows host); test_update_shape_add.py test_update_shape_pr_base.py test_template_values_single_pass.py test_scaffold_ignored_shape_files.py 223 passed (the shared checkout's git identity blanked, as the lane's environment note says). Main then moved to 0f67f7b (validate-family.py: member-duplicate is decided from members: alone before the --no-members return and compares project: case-folded, so a family.yaml that names one row twice no longer passes the run a private family's CI falls back to, and rows IRRS and irrs are one finding naming both, since members/IRRS and members/irrs are one directory on macOS and Windows (#331) #350 landed, which changes the validator this reads, and a scaffold PR): test_family_init_values.py test_stdout_encoding.py test_cli_reference.py test_validate_family_duplicates.py on this branch merged with it: 197 passed, 9 skipped.
• Merge-tree (git merge-tree --write-tree), all clean: origin/main at 0f67f7b; family.py: bump --dry-run fetches the member, resolves --to and prints the old -> new row and its trailers without checking the member out or rewriting family.yaml, and remove --dry-run prints the row, gitlink, .gitmodules section and directory it would remove and changes nothing, so the module's EXIT CODES line is true of both (#326) #345 (abaaf3c); scaffold-project.py and adopt-project.py ask the project's YAML reader and validate-manifest.py about the manifest's values before anything exists, so --id null, --tracking-branch true and a blank --elected-by are refused (#258, #261) #314 (4b8da3d); and fix/template-quoted-placeholders (3894aa8, templates/assembly-root/project.yaml and the two leg pins write eight text placeholders bare (id, elected_on, visibility, tracking_branch, the two leg paths and submodule_paths), so a checked value YAML reads as another type (007, 2026, true, null) is misread by the project or refused by the tool; quoting them reads every one back exactly and lets numeric branch names adopt #259). This branch + origin/main + family.py: bump --dry-run fetches the member, resolves --to and prints the old -> new row and its trailers without checking the member out or rewriting family.yaml, and remove --dry-run prints the row, gitlink, .gitmodules section and directory it would remove and changes nothing, so the module's EXIT CODES line is true of both (#326) #345 + templates/assembly-root/project.yaml and the two leg pins write eight text placeholders bare (id, elected_on, visibility, tracking_branch, the two leg paths and submodule_paths), so a checked value YAML reads as another type (007, 2026, true, null) is misread by the project or refused by the tool; quoting them reads every one back exactly and lets numeric branch names adopt #259's branch together are clean too, and test_family_init_values.py test_family.py test_stdout_encoding.py test_cli_reference.py test_family_dry_run.py test_validate_family_duplicates.py test_template_text_placeholders.py there: 442 passed, 20 skipped (the 19 rows above, which skip because templates/assembly-root/project.yaml and the two leg pins write eight text placeholders bare (id, elected_on, visibility, tracking_branch, the two leg paths and submodule_paths), so a checked value YAML reads as another type (007, 2026, true, null) is misread by the project or refused by the tool; quoting them reads every one back exactly and lets numeric branch names adopt #259 quotes the template, and one Windows-only row). family.py: bump --dry-run fetches the member, resolves --to and prints the old -> new row and its trailers without checking the member out or rewriting family.yaml, and remove --dry-run prints the row, gitlink, .gitmodules section and directory it would remove and changes nothing, so the module's EXIT CODES line is true of both (#326) #345 changes cmd_bump, cmd_remove and build_parser, not cmd_init; validate-family.py: member-duplicate is decided from members: alone before the --no-members return and compares project: case-folded, so a family.yaml that names one row twice no longer passes the run a private family's CI falls back to, and rows IRRS and irrs are one finding naming both, since members/IRRS and members/irrs are one directory on macOS and Windows (#331) #350 (landed) added member-name checks to the validator and left _check_envelope and Report, the two names this change asks, as they are. scaffold-project.py and adopt-project.py ask the project's YAML reader and validate-manifest.py about the manifest's values before anything exists, so --id null, --tracking-branch true and a blank --elected-by are refused (#258, #261) #314 at 4b8da3d does not merge with origin/main by itself (adopt-project.py, from what landed after its last merge), so it is not composed with the rest, but it is clean against this branch alone. AGENTS.md, README and scaffold-project.py --help: say that a --spec-path or --code-path that is, holds or lies inside a file the shape writes, and a --pin of spec, code or shape or of one product twice, are refused before anything is created, and name those three in the pin refusal's remediation, so an agent briefed from AGENTS.md can say so before it runs the scaffold (#288) #309, validate-pins.py: a --pin-source value is PRODUCT=PATH only when the text before its first = names a declared neutral-product pin, so a bare stand-in under a=b/ recomputes the digest instead of falling to gh api and a skip, an explicit source that does not exist or is not a directory is the neutral-pin-source-unreadable finding instead of a FileNotFoundError traceback, and a value no pin used is noted (#295) #312, shape_materialize.py: render substitutes in one pass and refuses only a placeholder its table lacks, so --elected-by '{{SPEC_PATH}}' is no longer recorded as spec and {{NOPE}} no longer refuses after the legs are pushed (#260) #316, family.py: add refuses member-path-registered when a .gitmodules section under another name already gives the mount path, and validate-family.py finds gitmodules-path-twice, so add no longer commits two sections for one path that a recursive clone resolves to the later one, and a holder that already has such a ghost section fails its own gate (#300) #317, family.py: add asks the holder's index for the mount path in any case, so an entry Members/Atlas/README is refused as member-path-taken before anything is cloned instead of leaving the member's 19 files staged under it, and a refused add says the holder is exactly as it was only when the whole index is as it was (#302) #318 and validate-family.py: member-duplicate is decided from members: alone before the --no-members return and compares project: case-folded, so a family.yaml that names one row twice no longer passes the run a private family's CI falls back to, and rows IRRS and irrs are one finding naming both, since members/IRRS and members/irrs are one directory on macOS and Windows (#331) #350, which the first round merged against or named, have landed.
• --created-by '{{ORG}}': on c7c02fa init created the remote and then died with template-unsubstituted once the worktree was rendered. Merged with main, shape_materialize.py: render substitutes in one pass and refuses only a placeholder its table lacks, so --elected-by '{{SPEC_PATH}}' is no longer recorded as spec and {{NOPE}} no longer refuses after the legs are pushed (#260) #316's one-pass render writes the value as typed: init exits 0, family.yaml records created_by: "{{ORG}}" and the holder's own validate-family.py is green. This change does not touch it and does not refuse it. (On this branch alone, without shape_materialize.py: render substitutes in one pass and refuses only a placeholder its table lacks, so --elected-by '{{SPEC_PATH}}' is no longer recorded as spec and {{NOPE}} no longer refuses after the legs are pushed (#260) #316, the pre-flight render refuses it before anything exists, with the same template-unsubstituted text.)

Left out

• AGENTS.md, README.md, docs/handbook.html: no prose change (AGENTS.md, README and scaffold-project.py --help: say that a --spec-path or --code-path that is, holds or lies inside a file the shape writes, and a --pin of spec, code or shape or of one product twice, are refused before anything is created, and name those three in the pin refusal's remediation, so an agent briefed from AGENTS.md can say so before it runs the scaffold (#288) #309 has landed since; init --help carries the sentence).
• A calendar check of --created-on (2026-13-45 passes the validator's DATE_RE): the validator's rule, not copied here.
• A branch git itself refuses (a..b, x.lock): scaffold-project.py holds --tracking-branch only to checked_value's alphabet, so a name git refuses as a branch (~, a..b, x.lock, a trailing /) passes --dry-run and, against GitHub, dies at the first git init -b after gh repo create has made all three repositories #283.
• --org test+org passes validate-family.py; not claimed.
• --created-by with an ESC or OSC is printed raw by the plan's created by line on c7c02fa and here: not part of this change.
• No run against GitHub (the gh repo create ordering is proved in-process, with every step that would reach GitHub replaced by one that fails the test), none on macOS or Windows.

Closes #307

🤖 Generated with Claude Code

Summary by Sourcery

Preflight family.yaml with the holder's own reader and validator so invalid or misread values are refused before any family resources are created.

New Features:

• Validate the family manifest with the holder's own YAML reader and family validator before creating anything, including during dry runs.
• Report manifest values that are reinterpreted by YAML or rejected by the holder validator with actionable refusal messages.

Bug Fixes:

• Prevent family holders from being created or pushed with invalid metadata or values that read back as different types.
• Handle missing, broken, exiting, or malformed validators as explicit failures instead of silent success or tracebacks.

Enhancements:

• Preserve safe diagnostics for multiline and control-character inputs and identify values supplied by defaults rather than explicit flags.
• Document the new preflight validation behavior and init argument defaults in the CLI reference.

Documentation:

• Update the generated CLI documentation to describe manifest preflight validation and init option defaults.

Tests:

• Add comprehensive coverage for invalid and misread values, dry-run behavior, creation ordering, quoted templates, validator failures, diagnostic escaping, and environment cleanup.
• Adjust stdout encoding coverage to use a valid family name while retaining non-ASCII creator text coverage.

[brettheap]

(lane openRepoShape-5, 2026-10-12T15:46Z) @codex review

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

[sourcery-ai]

Sorry @brettheap, you've used your own review budget of 250,000 diff characters for the last 7 days.

You can request another review in 2 days and 3 hours by commenting @sourcery-ai review. Upgrade to get a review now.

[sourcery-ai]

Reviewer's Guide

The PR adds a template-relative manifest preflight to family.py init: it asks the holder’s own YAML reader and validator whether the rendered family.yaml is both faithfully represented and valid, refuses any unusable or invalid result before side effects (including under --dry-run), and documents and tests the behavior extensively.

Sequence diagram for family initialization manifest preflight

sequenceDiagram
    participant User
    participant FamilyInit as family.py init
    participant YAMLReader as Holder YAML reader
    participant Validator as Holder validate-family.py
    participant GitHub as GitHub remote

    User->>FamilyInit: init arguments
    FamilyInit->>FamilyInit: Build substitution values
    FamilyInit->>YAMLReader: Read rendered family.yaml values
    alt Value is misread
        YAMLReader-->>FamilyInit: Different value or YAML error
        FamilyInit-->>User: Refuse family-manifest-misread
    else Values are faithfully represented
        FamilyInit->>Validator: Validate rendered family.yaml
        alt Manifest is invalid or validator is unusable
            Validator-->>FamilyInit: Findings or unusable response
            FamilyInit-->>User: Refuse family-manifest-invalid or family-validator-unusable
        else Manifest is valid
            alt --dry-run
                FamilyInit-->>User: Print initialization plan
            else Real run
                FamilyInit->>GitHub: Create holder remote
                FamilyInit-->>User: Create and push holder
            end
        end
    end

Loading

Flow diagram for family manifest preflight decisions

flowchart TD
    A[Build init substitution values] --> B[Render and read manifest values]
    B -->|Reader changes value| C[Refuse family-manifest-misread]
    B -->|Values preserved| D[Run holder validate-family.py]
    D -->|Validator unavailable| E[Refuse family-validator-unusable]
    D -->|Findings returned| F[Refuse family-manifest-invalid]
    D -->|No findings| G{dry-run?}
    G -->|Yes| H[Print plan and stop]
    G -->|No| I[Create remote and push holder]

Loading

File-Level Changes

Change	Details	Files
Add preflight validation of the manifest before family holder creation, including dry runs.	Render the pending family manifest from the actual substitution table. Use the holder template's YAML reader to detect values that round-trip to a different type or text. Load and invoke the template-shipped validator rather than duplicating validation rules. Refuse before planning, worktree setup, remote creation, or GitHub access, with distinct refusal codes and remediation. Handle missing, broken, exiting, malformed, or non-text-reporting validators as explicit unusable-validator refusals. Preserve process state and avoid writing validator bytecode into the template tree.	scripts/family.py
Document the new init preflight behavior and clarify defaults and validation constraints.	Describe reader and validator checks for normal and dry-run invocations. Document defaults for id, name, creator, date, and tracking branch. Explain that invalid values are refused rather than corrected.	docs/cli.md
Add comprehensive coverage for manifest round-tripping, validation, ordering, and failure handling.	Cover issue reproductions across dry-run and real-run paths, including typed YAML-like values and validator-invalid values. Verify quoted-template compatibility and that validator rules remain authoritative. Test derived-default flag attribution, combined refusals, safe escaping of control/newline content, and no side effects. Exercise broken validators, SystemExit, invalid findings, sys.path/bytecode restoration, comment skipping, and GitHub-boundary ordering.	tests/test_family_init_values.py
Keep stdout encoding coverage aligned with validator-enforced family naming.	Remove the invalid multi-word name from the dry-run encoding fixture while retaining non-ASCII creator text coverage.	tests/test_stdout_encoding.py

Assessment against linked issues

Issue	Objective	Addressed	Explanation
#307	Before creating or pushing a family holder, including during --dry-run, check the rendered family.yaml with the holder template’s own YAML reader and refuse values that read back as a different value.	✅
#307	Before creating or pushing a holder, validate the rendered manifest using the validate-family.py shipped in the holder template, refusing values it rejects rather than creating a holder whose validation gate fails.	✅
#307	Add coverage for the reported invalid and misread values, verifying refusal occurs before creation in both dry-run and real init paths.	✅

Possibly linked issues

• family.py init exits 0 and pushes a holder its own validate-family.py refuses for --id null, --created-by ' ', --created-on 20261011 or --name 'Contoso Group', and puts --tracking-branch true on a branch its manifest reads back as True #307: The PR checks the rendered manifest with the holder’s reader and validator before creation, refusing the issue’s invalid and misread values.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[brettheap]

(lane openRepoShape-3, 2026-10-12T19:53:36Z) A v1.0.0 scope notice. Brett Heap scoped openRepoShape's first release today: every procedure in AGENTS.md works end to end for ordinary repositories on Linux, macOS and Windows. The tag waits for every in-scope issue to close and a full test run to pass on all three OSes on the release commit. This PR closes #307 (P2, parent #459): in scope, in the v1.0.0 milestone. Nothing changes in how it lands. Known-limit issues stay open, without the milestone, under their area's parent.

[sonarqubecloud]

Quality Gate passed

Issues
10 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.5% Duplication on New Code

See analysis details on SonarQube Cloud