[brettheap]

Lane: openreposhape-4 (openRepoShape-4)
Claim: #366 (comment)

What

family.py add refuses a --member whose owner or project does not begin with a letter or a digit, as member-malformed, before the member is read. MEMBER_RE took QUALIFIED_RE's shape (the validator's, in validate-family.py and validate-manifest.py); until now it shared the character class but not the first-character rule, so testorg/_Zed, testorg/.Zed, testorg/-Zed, _org/Zed and .org/Zed were mounted, pinned and committed with exit 0, and the holder's own validate-family.py then failed the commit as member-repository.

The rulings (the issue's three decisions):

1. MEMBER_RE takes QUALIFIED_RE's shape. _checked_member's ./.. clause is KEPT for its more specific sentence and read FIRST, so it is still reachable (only on a name with a /; a bare . is still the general sentence, which asks for the owner). Its remedy no longer offers .github as the example of a name with a dot, since .github is refused now; it says Ze.d.
2. One rule, pinned, not moved: family.py spells the pattern a third time, and tests/test_family_member_name.py READS every spelling (MEMBER_RE and every tracked module's QUALIFIED_RE outside tests/, parsed, never run) and fails when they differ. The constant stays out of repo_shape.py, a copied file that would reach an existing holder only through update-shape.py.
3. The validator's rule is unchanged.

The general member-malformed sentence now states the rule, and its remedy says why (a commit that wrote such a name would fail the gate the holder ships).

Behaviour that moves beside the five

• --member=-org/Zed (the one way a leading - reaches the owner) passed the old pattern and was refused later by checked_value as unsafe-value; it is member-malformed now. Exit 2, nothing read, either way.
• testorg/.github and testorg/... are refused (the issue named them; the validator refused both already).
• This narrows what family.py: bump and remove take the git pathspec from the manifest row's path: with no check and no --literal-pathspecs, so a hand-edited path: members/* makes remove --member Atlas exit 0 with ONE commit that unmounts every member while dropping only Atlas's row, and path: . makes it git rm -r -f the holder's own files and die on a FileNotFoundError, though validate-family.py already has a rule, member-path, for what path: must equal #299 (PR family.py: bump and remove refuse member-path when a row's path: is not members/<project> or its project: is not a directory name, and hand git every path literally, so a hand-edited path: members/* or project: . no longer makes remove unmount every member in one commit while dropping one row (#299) #315) deliberately left alone: its comment kept MEMBER_RE's class loose 'for .github', and its writer named this tightening as the follow-up. testorg/.github, and an owner of .github, are refused now; the validator refused both already, so no holder could keep such a row.
• tests/test_family_member_path.py: test_add_still_takes_a_name_that_contains_a_dot asserted .github was admitted, and the ./.. test's remedy string offered .github. Both are corrected; a.b stays admitted.

Tests

tests/test_family_member_name.py, members from local bare remotes (a bare copy of the family fixture's spare member under each name, so a refusal is for the NAME and never for a missing remote):

• add --member over the issue's five spellings plus -org/Zed and .github: member-malformed, exit 2, empty stdout, no gh call, no throwaway clone, and the holder byte for byte (HEAD, ls-files -s -z, status --porcelain=v1 -z, family.yaml, the rest of the snapshot).
• Controls: a name with an inner ., _ or - (and an owner with an inner .) still adds in ONE commit, the row names the argument verbatim, and the holder's validate-family.py passes.
• The pinned-equality test, and a corpus of names every spelling must judge alike.

Mutant: the old MEMBER_RE restored fails the seven refusal cases (six exit 0 with a committed row, and -org/... is unsafe-value, exit 2) and both pin tests, 9 of 13; the four controls pass.

Linux, /usr/bin/python3 -m pytest tests/test_family_member_name.py tests/test_family.py tests/test_family_add_refusals.py tests/test_family_member_path.py -q: 220 passed. CI's three OSes are the gate.

Closes #366

🤖 Generated with Claude Code

Summary by Sourcery

Align family.py add member-name validation with the holder validator so malformed repository names are refused before any member access or commit.

Bug Fixes:

• Reject member names whose owner or project begins with a non-alphanumeric character before reading or modifying the member repository, preventing commits that fail the holder’s validator.
• Preserve support for dots, underscores, and hyphens appearing after the first character of either name.

Enhancements:

• Keep the member-name pattern synchronized with the validator patterns through source-level equality and corpus tests.
• Retain specific handling for . and .. path segments while updating their guidance for the tightened naming rule.

Tests:

• Add coverage for malformed member names, side-effect-free refusal behavior, valid inner punctuation, validator compatibility, and consistency across all pattern spellings.

[sourcery-ai]

Sorry @brettheap, you've used your own review budget of 250,000 diff characters for the last 7 days.

You can request another review in 7 hours and 41 minutes by commenting @sourcery-ai review. Upgrade to get a review now.

[sourcery-ai]

Reviewer's Guide

family.py add now applies the holder validator’s leading-letter-or-digit repository naming rule before reading or mounting a member, while preserving valid internal punctuation and the specific ./.. diagnostics. New tests verify refusal side effects, successful controls, validator consistency across tracked copies, and regression coverage for the affected name corpus.

Sequence diagram for refusing malformed members before side effects

sequenceDiagram
    participant User
    participant Family as family.py
    participant Member as Member repository
    participant Git as Holder git state
    User->>Family: add --member owner/project
    Family->>Family: _checked_member(raw)
    alt owner/project begins with . _ or -
        Family-->>User: Refusal member-malformed
        Note over Family,Git: No member read, clone, gh call, or commit
    else valid leading characters
        Family->>Member: Read member metadata
        Family->>Git: Mount, pin, and commit row
        Git-->>User: Successful add
    end

Loading

Flow diagram for member name validation before reading

flowchart TD
    A["family.py add receives --member"] --> B["_checked_member parses owner/project"]
    B --> C{"owner or project is . or ..?"}
    C -->|Yes| D["Refuse member-malformed with directory-reference diagnostic"]
    C -->|No| E{"MEMBER_RE matches leading letter or digit on both names?"}
    E -->|No| F["Refuse member-malformed"]
    E -->|Yes| G["checked_value validates the member"]
    G --> H["Read and mount member"]

Loading

File-Level Changes

Change	Details	Files
Align member-name validation with the holder validators and reject invalid names before any repository access or mutation.	Require both owner and project to begin with an ASCII letter or digit while retaining letters, digits, dots, underscores, and hyphens afterward. Keep the dedicated ./.. directory-reference refusal ahead of the general malformed-name check. Expand the malformed-name diagnostic to explain the validator compatibility requirement and remediation. Preserve acceptance and successful single-commit behavior for names containing punctuation after the first character.	scripts/family.py tests/test_family_member_path.py
Add regression coverage for refusal side effects, accepted controls, and consistency of the naming rule across standard and holder validators.	Test seven invalid spellings, including leading punctuation and .github, for exit 2, empty stdout, no GitHub or clone activity, and byte-for-byte holder preservation. Use local bare remotes to ensure failures are caused by name validation rather than unavailable members. Verify dotted, underscored, and hyphenated names with valid initial characters still add, are recorded verbatim, and pass the holder validator. Parse tracked validator sources to pin MEMBER_RE and every QUALIFIED_RE spelling to the same regex, and exercise an accepted/rejected corpus.	tests/test_family_member_name.py

Assessment against linked issues

Issue	Objective	Addressed	Explanation
#366	Make family.py add reject owner or project names beginning with ., _, or - as member-malformed before reading the member, so it cannot commit a row that the holder’s validate-family.py rejects.	✅
#366	Preserve valid names containing ., _, or - after the first character, and retain the more specific refusal for . and .. path segments.	✅
#366	Keep MEMBER_RE aligned with the validator’s QUALIFIED_RE rule and add regression coverage for the refusals, valid controls, and consistency among the pattern definitions.	✅

Possibly linked issues

• family.py _checked_member's MEMBER_RE admits an owner or a project that begins with ., _ or - (testorg/_Zed, testorg/.Zed, testorg/-Zed, _org/Zed, .org/Zed), which the holder's own validate-family.py refuses with its QUALIFIED_RE, so add exits 0 with a commit whose new row its gate then reports as member-repository #366: The PR fixes the exact mismatch by requiring alphanumeric segment starts in MEMBER_RE and rejecting affected names before reading the member.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud