[brettheap]

Part of #913. Every section is done but U039, which needs a ruling (see "Left out"), so this does not close the issue.

What changed, by section

An unread visibility is taken as the run's, and the root is read twice (U163, U167; L2-92, L2-96)

• shape_materialize.repository_visibility_answer is the one gh repo view --json visibility reader now. It answers the visibility, REPOSITORY_NOT_FOUND for gh's own not-found answer (gh_said_not_found, exit 1 with the words on stderr, the reading scaffold-project.py and family.py init: the dry runs skip the target-exists and folder checks, and any gh repo view failure reads as "does not exist" #609 gives refuse_unless_not_found), or None for any other failure. repository_visibility is that reading with not-found taken as unread, so family.py and its callers see what they saw before. It runs the command with subprocess.run, as organisation_plan does, because the reading is of stderr alone.
• _leg_visibility reads the root once. Where the read failed (not where gh does not find the root, which is the ordinary --reuse-empty-repo run), it prints a leg twin of ROOT_VISIBILITY_UNREAD BEFORE the plan: with no --visibility, that a leg this run creates is created private and does not inherit the root's, and to pass --visibility before any leg exists; with one, that it cannot say whether the flag agrees with the root. Both name gh repo view <root> --json visibility.
• _leg_visibility returns the root's read with the legs' visibility, and _create_remotes takes it for a reused root instead of asking GitHub a second time.
• _reused_leg_visibility returns None for a leg whose read failed (it returned the run's visibility). _private_leg_note names each such leg in a NOTE of its own (_unread_legs_note: the question, what a private or internal answer needs, and the command that answers it), goes on naming the legs it could read as before, and asks the Free-plan note when a leg is closed OR unread, since an unread leg may be closed.
• Decided where the Direction left it open: the pre-plan NOTE is printed with an explicit --visibility too, because the issue's Goal says a failed read is said before anything is created; and the unread-leg NOTE follows L2-92's own Direction ("says which leg's visibility it could not read ... and goes on by the legs it could read").

Free-plan words for an internal root (U164; L2-93)

• free_plan_secrets_note answers an internal root whose organisation's plan is unread with FREE_PLAN_UNREAD_INTERNAL: GitHub gives internal visibility only to a repository of an organisation an enterprise account owns, which is not on the Free plan, so the plan is not what the hint hangs on. The NOTE is printed where it was and the plan is still asked, so nothing but the words changes. Adopt gets the same words through the shared function.

No credential NOTE for a public holder (U166; L2-95)

• init prints the credential NOTE for every holder on GitHub, public, private, internal or unread, worded about the members: a private or internal member a person adds needs a way for the holder, public or not, to read it. It went by the holder's visibility and gave that as the reason.
• Of the Direction's two options this takes the init one; add is lane 4's ground.

Test gap: the not-found-on-stdout-alone row (U168; L2-97)

• The row's stdout is gh: Not Found (HTTP 404) (the file's NOT_AN_ORGANISATION) with a newline, and the body row is as it was. Mutant M15 below is killed by it; main's row lets the same mutant live (control run below).

The plan names no tracking branch, and no visibility in local mode (U010; AT-scaffold N3)

• The scaffold's plan has a branch row (<branch>, the tracking branch each of the three is created on) and, under --local-remote-dir, a visibility row (<visibility>, which project.yaml records; a bare repository on disk has none). Against GitHub the visibility stays in the gh repo create --<visibility> row. Setup's step (5) shows the same plan.
• Decided: init's plan gets the same two rows (family.yaml, the holder is created on), since the issue's Goal names init's plan and lane 4 agreed lane 3 writes scaffold-project.py, family.py init and shape_materialize.py: the plan and the visibility NOTEs go by values GitHub did not give, misword an internal root, skip a public holder's credential NOTE, and name no tracking branch #913's init half.

A private repository the token cannot see reads as absent (U060; L2-61)

• Of the Direction's two options this takes the plan's words (a known-limit entry would be a release-notes file outside this change's files). The remotes row against GitHub says the run creates each repository gh does not find, and two lines under it (NOT_FOUND_WITH_THIS_TOKEN, shared by the scaffold and init) say that with this token a private repository it cannot see is not found either, and gh repo create then fails for it.

Left out

• "Needs a ruling: what visibility: records" (U039) is out of scope and untouched: project.yaml's and family.yaml's visibility: are still filled from the run's --visibility, and the template comments are unchanged.
• U166's add option (a NOTE from add for a private or internal member): add is lane 4's ground in scripts/family.py.
• No refusal code is added or changed, so no code documentation changes.
• adopt-project.py's docstring that names FREE_PLAN_UNREAD (around line 11634) is not in this change's files; it stays true of a private root.

Tests

Each ran under a stub gh first on PATH that exits 97, GH_TOKEN=bogus and an empty GH_CONFIG_DIR, as timeout 2400 /usr/bin/python3 -m pytest -q -p no:cacheprovider --basetemp=<scratch>/bt-<name> -o tmp_path_retention_policy=failed <files>, one at a time. The first eleven ran on the commit before its rebase onto 450279ca (the same diff; main's two new commits touch neither these files nor the code they run); the last two ran on the rebased head.

files	result
tests/test_plan_visibility_notes.py (new)	15 passed
tests/test_free_plan_hint_reads.py	62 passed
tests/test_scaffold_reuse_seeded_legs.py	30 passed
tests/test_dry_run_asks_remotes.py	32 passed
tests/test_dry_run_parity.py	104 passed
tests/test_reuse_visibility.py tests/test_free_plan_hint.py tests/test_adopt_free_plan_hint_root.py	35 passed
tests/test_family.py	112 passed
tests/test_scaffold_e2e.py tests/test_scaffold_pin_and_reuse.py tests/test_tracking_branch_ref.py tests/test_family_tracking_branch.py tests/test_family_init_values.py	416 passed, 19 skipped (the template-dependent pytest.skips of test_family_init_values.py)
tests/test_setup_project_py.py tests/test_github_limits_init_check_org.py tests/test_github_name_limits.py tests/test_scaffold_manifest_values.py	492 passed
tests/test_agents_md_codes.py tests/test_cli_reference.py tests/test_update_add_codes_documented.py tests/test_repo_hygiene.py	157 passed
tests/test_no_auto_maintenance.py	60 passed
rebased head: tests/test_plan_visibility_notes.py tests/test_free_plan_hint_reads.py tests/test_scaffold_reuse_seeded_legs.py tests/test_ruleset_hint_tracking_branch.py	130 passed
rebased head: the four docs guards and tests/test_no_auto_maintenance.py	217 passed

tests/test_shape_doctor.py was not run: neither shape-doctor.py nor a helper it imports changed.

Mutants

Each was applied to the committed head, run against the named tests with -k, and put back with git checkout. All 16 were killed.

mutant	killed by
M1 _reused_leg_visibility returns the run's visibility for an unread leg	test_plan_visibility_notes.py::test_a_reused_leg_it_could_not_read_is_said_to_be_unread (3 of 3 rows)
M2 no unread-leg NOTE	the same 3 rows
M3 the Free-plan note only for closed legs	the same test, [private-legs-under-a-public-run]
M4 no NOTE before the plan for an unread root	test_a_root_it_could_not_read_is_said_before_the_plan[default], [chosen]; test_a_real_run_reads_the_reused_root_once[unread]
M5 not-found not told apart (repository_visibility_answer returns None)	test_a_root_gh_does_not_find_or_reads_is_not_said_to_be_unread[not-found]; test_free_plan_hint_reads.py::test_a_visibility_read_is_one_of_three_not_found_or_unread[not-found]
M6 _create_remotes reads the root again	test_a_real_run_reads_the_reused_root_once[read], [unread]
M7 no scaffold branch row	test_the_plan_on_disk_names_the_branch_and_the_visibility[defaults-scaffold], [chosen-scaffold]; test_the_plan_on_github_says_not_found_is_what_this_token_sees[scaffold]
M8 no scaffold local visibility row	test_the_plan_on_disk_names_the_branch_and_the_visibility[defaults-scaffold], [chosen-scaffold]
M9 no init branch row	the same tests' family rows (3)
M10 no init local visibility row	test_the_plan_on_disk_names_the_branch_and_the_visibility[defaults-family], [chosen-family]
M11 no not-found lines in the scaffold's plan	test_the_plan_on_github_says_not_found_is_what_this_token_sees[scaffold]
M12 no not-found lines in init's plan	test_the_plan_on_github_says_not_found_is_what_this_token_sees[family]
M13 an internal root's unread plan told FREE_PLAN_UNREAD	test_free_plan_hint_reads.py::test_the_note_goes_by_both_answers[internal-unread-plan]
M14 init's NOTE only for a private or internal holder	test_init_notes_the_members_credential_for_every_reused_holder[public], [visibility-502], [visibility-404]; test_init_asks_nothing_of_a_holder_it_creates[public]; test_init_takes_a_holder_gh_cannot_be_asked_about_as_unread
M15 gh_said_not_found searches stdout too	test_the_plan_is_free_other_or_unread[not-found-on-stdout-alone]; test_a_visibility_read_is_one_of_three_not_found_or_unread[not-found-on-stdout-alone]
M16 repository_visibility keeps not-found	test_a_visibility_read_is_one_of_three_not_found_or_unread[not-found]

Control for M15: main's tests/test_free_plan_hint_reads.py with the same mutant, -k plan_is_free_other_or_unread: 11 passed, so main's row did not catch it.

Merges

git merge-tree --write-tree of this head (e016994872) with each, all clean (exit 0, no conflicted file):

• origin/main at 450279ca;
• family.py init: where the holder's own YAML reader refuses the manifest it would write, family-manifest-invalid names the value on the line it refuses, --org is '@x', and gives the reader's remedy, not the validator's (#929) #960 (family.py init: the whole-manifest YamlError refusal names no flag, and its remedy says the words are the validator's own when they are the reader's #929) at c6700b7f, family.py add: a commit that records the member's gitlink anywhere but members/<Project> is taken back and refused, naming the path git chose, and members: null, Null, NULL or ~ takes the first member as members: does (#920) #957 (family.py add: the commit is never checked for a gitlink at exactly members/<P>, and members: null is refused as a missing members: line #920) at 37faf298, family.py: a holder, a member or its object store this user cannot read is refused by name, exit 2, on every Python, never family-root-missing, member-uninitialized or "not on disk", and no rollback removes past it (#430) #955 (Every Path.is_file() / is_dir() / exists() guard in the shipped tools answers False to any OSError on Python 3.14 (3.12 and 3.13 raise PermissionError), so a directory this user cannot search reads as ABSENT: validate-pins.py skips its workflow @<sha> check, update-shape.py says copy-missing and update-pin-missing ("adopt the project") for files that are there, the doctor says DRIFTED (5 copy-missing), and bump-leg.py's remaining guards, and every other tool's, skip or misreport instead of refusing by name #430 slice G) at 991990cc, family.py: bump's fetch no longer moves the mount's own branches, works where the mount maps tags into origin/ instead of telling the person to fix the network, reads its refspecs with git config --list -z, and asks git remote get-url origin first, so a mount with no origin is not fetched from a path of that name (#905) #946 (family.py bump: its fetch can force-move a local branch through the mount's own refspec, fails on a tags-into-origin/ refspec with a network note, splits git config --list values, and fetches a path named origin #905) at 5d5d06bb: the open PRs that touch scripts/family.py or scripts/shape_materialize.py; none touches scaffold-project.py or the two test files;
• lane 3's pushed branches: l3-907-926-setup-step4-links at 8c5d6051, l3-917-yaml-reader at d3a2ee61, l3-939-941-package-standard at c1de4c86.

W909's, W911's and W915's branches in scaffold-project.py were not pushed when this was opened, so they were not merged against. This change's hunks there are remote_visibility, _leg_visibility, _print_plan_actions, _create_remotes, _reused_leg_visibility, _private_leg_note, a new _unread_legs_note, the scaffold's shape_materialize imports, and the two _scaffold lines that call _leg_visibility and _create_remotes. In scripts/family.py they are _print_init_plan, _finish_holder_remote and one import after the GitHub-limits group.

Fix round 1 (head f3802d6f)

RV969 found the head e016994872 READY: no MUST, two non-blocking SHOULDs and six NITs. This round makes SHOULDs 1 and 2 and NITs 1, 2, 4 and 5, in one commit on the same branch, as a fast-forward. Behaviour changes only in the two NOTEs' words (NITs 4 and 5).

• SHOULD 1. _private_leg_note returns first for a --local-remote-dir run and drops its three not local and guards, which was SonarCloud's S3776 at cognitive complexity 16 where 15 is allowed. Counted by hand under the rules that give the old text 16 (each if, each and/or sequence, each conditional expression, nesting added), the new text is 14. A local run still prints nothing from it: the two local-remote tests of test_scaffold_reuse_seeded_legs.py fail on the mutant that drops the return (below).
• SHOULD 2. test_a_reused_leg_it_could_not_read_is_said_to_be_unread has a fourth row, one-leg-not-found, whose spec leg's --json visibility read is gh's own not-found answer, visibility_errors={f"{PROJECT}-spec": "GraphQL: Could not resolve to a Repository"}, under --visibility public. The error text is a column of the table now (error, BAD_GATEWAY in the three rows that had it).
• NIT 1. The same test counts the unread-leg NOTE in result.stdout alone, so the NOTE on stderr no longer passes.
• NIT 2. The 115-character docstring line of tests/test_free_plan_hint_reads.py is wrapped.
• NIT 4. scripts/family.py's members' NOTE says "a member you add that is, or has a leg that is, private or internal" where it said "a private or internal member you add": a public member with private legs needs the credential too, since the holder's validate runs --recursive. Only tests/test_free_plan_hint_reads.py's member_note pinned the old words, and it is changed with it.
• NIT 5. _unread_legs_note ends "cannot check them out" for two legs and "cannot check it out" for one (it said "it" for both). The test's unread_legs helper builds the same.
• Not in this round: NIT 3 (adopt-project.py's docstring) and NIT 6 (shape_materialize.py:1970) are lane 3's follow-ups, outside this PR's files.

Tests, under the stub gh, GH_TOKEN=bogus, an empty GH_CONFIG_DIR and GIT_SSH_COMMAND=false, one at a time, as above, on the committed bytes:

files	result
tests/test_plan_visibility_notes.py tests/test_free_plan_hint_reads.py tests/test_scaffold_reuse_seeded_legs.py	108 passed
tests/test_family.py tests/test_family_init_values.py	218 passed, 19 skipped
tests/test_dry_run_parity.py	104 passed
tests/test_agents_md_codes.py tests/test_cli_reference.py tests/test_repo_hygiene.py	151 passed
tests/test_no_auto_maintenance.py	60 passed

Mutants of this round, each applied to the committed text, run with -k reused_leg on the named files, and put back:

mutant	killed by
the unread-leg NOTE printed on stderr (RV969's survivor)	test_a_reused_leg_it_could_not_read_is_said_to_be_unread, all 4 rows
a not-found leg read taken at the run's visibility (RV969's survivor; _reused_leg_visibility returns args.visibility for not-found)	test_a_reused_leg_it_could_not_read_is_said_to_be_unread[one-leg-not-found] (the other 3 rows pass, as they should)
the two-leg NOTE ending "cannot check it out" again	the same test, [private-legs-under-a-public-run] and [public-legs-under-a-private-run]
_private_leg_note without its early return for a local remote	the gh guard at teardown of test_three_empty_repositories_are_all_reused_with_the_flag and test_legs_holding_the_seed_are_reused_at_their_commits (test_scaffold_reuse_seeded_legs.py): the local run then asks gh api orgs/testorg --jq .plan.name
init's members' NOTE in its old words	test_init_notes_the_members_credential_for_every_reused_holder, all 5 rows

Merges, git merge-tree --write-tree of the new head f3802d6fd452ffbd7deb9b92f4f286342ba2c8ab with each, all clean (exit 0, no conflicted file): origin/main at 293ef2a5, #971 (l3-915-scaffold-git-prompts) at e40af32d, and #972 (l3-911-930-scaffold-init-flags) at 0094731b.

Lane: openreposhape-3 (openRepoShape-3)
🤖 Generated with Claude Code

[sourcery-ai]

Reviewer's Guide

The PR refines GitHub visibility handling across scaffold and family initialization, explicitly distinguishing unread repositories from not-found ones, reusing a single root read, improving plan and credential diagnostics, and adding comprehensive regression tests for the resulting behavior.

Sequence diagram for scaffold visibility planning and remote creation

sequenceDiagram
    participant Scaffold as scaffold-project.py
    participant Visibility as shape_materialize.repository_visibility_answer
    participant GitHub as GitHub gh CLI
    participant Plan as Plan output
    participant Remotes as Remote creation

    Scaffold->>Visibility: repository_visibility_answer(root)
    Visibility->>GitHub: gh repo view root --json visibility
    GitHub-->>Visibility: visibility, REPOSITORY_NOT_FOUND, or failure
    Visibility-->>Scaffold: root_seen
    alt root read failed
        Scaffold->>Plan: Print unread-root NOTE before plan
    else root not found
        Scaffold->>Plan: Treat root as ordinary create run
    end
    Scaffold->>Plan: Print branch and remote visibility rows
    Scaffold->>Remotes: _create_remotes(root_seen)
    Remotes->>GitHub: Create or reuse root and legs
    Remotes-->>Scaffold: Standing visibility per repository

Loading

Sequence diagram for unread reused-leg diagnostics

sequenceDiagram
    participant Scaffold as scaffold-project.py
    participant Visibility as shape_materialize.repository_visibility
    participant GitHub as GitHub gh CLI
    participant Notes as Diagnostic notes

    Scaffold->>Visibility: _reused_leg_visibility(leg)
    Visibility->>GitHub: gh repo view leg --json visibility
    GitHub-->>Visibility: visibility or unread result
    alt visibility unread
        Visibility-->>Scaffold: None
        Scaffold->>Notes: _unread_legs_note(leg)
        Scaffold->>Notes: free_plan_secrets_note(...)
    else visibility available
        Visibility-->>Scaffold: leg visibility
        Scaffold->>Notes: Credential and Free-plan notes as applicable
    end

Loading

Flow diagram for family init plan and holder credentials

flowchart TD
    Init[family.py init] --> Plan[_print_init_plan]
    Plan --> Local{--local-remote-dir}
    Local -->|yes| LocalRows[Print visibility and branch rows]
    Local -->|no| GitHubRows[Print gh repo create visibility and not-found token limits]
    LocalRows --> Holder[_finish_holder_remote]
    GitHubRows --> Holder
    Holder --> Credential[Print members credential NOTE for every GitHub holder]
    Credential --> PlanHint[Add Free-plan hint when applicable]

Loading

File-Level Changes

Change	Details	Files
Separated repository visibility reads into explicit not-found, known-visibility, and unread outcomes, while avoiding duplicate root reads during scaffold reuse.	Added a subprocess-based visibility reader that distinguishes GitHub not-found responses from other failures and retained a compatibility wrapper treating not-found as unread. Reported unread reused roots before the plan and propagated the single root read into remote creation. Represented unread reused legs as unknown and added leg-specific diagnostics instead of substituting the run visibility. Adjusted Free-plan hint selection for unread internal repositories.	scripts/shape_materialize.py scaffold-project.py
Expanded scaffold and family initialization plans to expose the tracking branch, local visibility semantics, and token-specific not-found behavior.	Added branch rows to both plans. Added visibility rows for local bare-repository mode. Clarified GitHub remote-creation rows with the meaning of repositories not found by the current token.	scaffold-project.py scripts/family.py
Made family initialization credential guidance describe member access rather than holder visibility and emit it for every GitHub-backed holder.	Print the members' credential NOTE for public, private, internal, and unread holders. Preserved Free-plan guidance while using the holder's actual or unread visibility.	scripts/family.py
Added regression coverage for visibility state handling, plan output, notes, internal-plan wording, and stdout-only not-found cases.	Added end-to-end plan and NOTE assertions for scaffold reuse and family initialization. Updated visibility and Free-plan reader tests for subprocess results and explicit not-found classification. Covered branch/local-visibility plan rows and all 16 listed mutants.	tests/test_plan_visibility_notes.py tests/test_free_plan_hint_reads.py

Possibly linked issues

• scaffold-project.py, family.py init and shape_materialize.py: the plan and the visibility NOTEs go by values GitHub did not give, misword an internal root, skip a public holder's credential NOTE, and name no tracking branch #913: Link: the PR implements the issue’s specified sections and identifies itself as part of scaffold-project.py, family.py init and shape_materialize.py: the plan and the visibility NOTEs go by values GitHub did not give, misword an internal root, skip a public holder's credential NOTE, and name no tracking branch #913; U039 remains explicitly out of scope.
• #tracking issue: The PR directly updates scaffold and family init plans and shared helpers within this issue’s tracked area.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[brettheap]

(lane openRepoShape-3, 2026-10-18T18:55:03Z) RV969's independent review of #969 at e0169948: READY. No MUST; two non-blocking SHOULDs and six NITs. RV969 is lane 3's opus reviewer, under ruling 8. It probed with a stub gh whose visibility read answers public, private, internal, GraphQL not-found, gh: Not Found (HTTP 404) or HTTP 502.

Each section against its Direction:

• U163/U167:
  • not-found and failed reads are told apart;
  • repository_visibility still maps not-found to None, so family.py behaves as before;
  • a real reuse run reads the root once (main: twice), and each leg once;
  • the NOTE before the plan is right with and without --visibility;
  • a leg whose read fails gets its own NOTE;
  • the Free-plan note is asked when a leg is closed or unread.
  • On main, unread public legs were called private (L2-92 reproduced).
• U164: the internal-root sentence is true, since internal repositories exist only in enterprise-owned organisations, which are not on Free. It is also useful. Adopt prints it through free_plan_secrets_note (checked in process).
• U166: init prints the members' NOTE for every holder on GitHub, a public one included.
• U168: the new row passes on main's reader, which is correct, and kills M15, which main's row let live (control: 11 passed).
• U010: under --local-remote-dir, the dry-run and real-run plans are byte-identical for the scaffold and init. project.yaml, family.yaml and the bare HEAD agree with the new rows.
• U060: the plan's wording is true.

family.py: the hunks are init's (_print_init_plan, _finish_holder_remote), plus one module-level import. None touches a hunk of #946, #955, #957 or #960.

SHOULD (not blocking):

1. scaffold-project.py:1601: _private_leg_note gets a new SonarCloud S3776, cognitive complexity 16 where 15 is allowed. Put if local: return at the top and drop the three not local and at :1647, :1661 and :1663. With that change, the three related test files pass (107 passed).
2. scaffold-project.py:1590-1592: no test pins a reused leg that gh does not find on the visibility read. The mutant "return the run's visibility for not-found" survives 124 tests. Add a row with visibility_errors={f"{PROJECT}-spec": "GraphQL: Could not resolve to a Repository"} to test_a_reused_leg_it_could_not_read_is_said_to_be_unread.

NIT:

1. tests/test_plan_visibility_notes.py:190 counts the unread-leg NOTE in stdout plus stderr, so a stderr mutant survives. Count it in result.stdout.
2. tests/test_free_plan_hint_reads.py:263 is a 115-character line. Re-wrap it.
3. adopt-project.py:11634-11636 still says adopt's words are unchanged. That is no longer true for an internal root with an unread plan. A follow-up, outside this PR's files.
4. scripts/family.py:2985: a public member with private legs needs the credential too, since the holder's validate runs --recursive. Say "a member you add that is, or has a leg that is, private or internal".
5. scaffold-project.py:1691: the two-leg NOTE ends "cannot check it out"; "them" reads better.
6. shape_materialize.py:1970: an internal root on a "free" plan still gets FREE_PLAN_HINT, which calls it private. This predates the PR; optional.

Tests, at the head, one at a time under a stub gh:

Files	Result
plan_visibility_notes + free_plan_hint_reads	77 passed
dry_run_parity + reuse_visibility	106 passed
family + family_init_values	218 passed, 19 skipped
scaffold_e2e	46 passed
the docs guards	151 passed
no_auto_maintenance	60 passed
scaffold_reuse_seeded_legs + dry_run_asks_remotes + free_plan_hint + adopt_free_plan_hint_root	95 passed
on the head merged with main 2f5cabf5: the PR's two test files	77 passed

Mutants:

• M5, M6, M13 and M15, re-made: all killed.
• RV969's own, killed:
  • the NOTE only when no leg is closed;
  • the NOTE before the plan for a not-found root;
  • the NOTE before the plan on stderr.
• Survivors: the unread-leg NOTE on stderr (NIT 1), and a not-found leg taken at the run's visibility (SHOULD 2).

Merges: git merge-tree --write-tree is clean in every case.

• Against: origin/main 2f5cabf5; family.py: bump's fetch no longer moves the mount's own branches, works where the mount maps tags into origin/ instead of telling the person to fix the network, reads its refspecs with git config --list -z, and asks git remote get-url origin first, so a mount with no origin is not fetched from a path of that name (#905) #946, family.py: a holder, a member or its object store this user cannot read is refused by name, exit 2, on every Python, never family-root-missing, member-uninitialized or "not on disk", and no rollback removes past it (#430) #955, family.py add: a commit that records the member's gitlink anywhere but members/<Project> is taken back and refused, naming the path git chose, and members: null, Null, NULL or ~ takes the first member as members: does (#920) #957 and family.py init: where the holder's own YAML reader refuses the manifest it would write, family-manifest-invalid names the value on the line it refuses, --org is '@x', and gives the reader's remedy, not the validator's (#929) #960; and the l3-907-926, l3-911-930 (0094731b), l3-915 (e40af32d), l3-917 (e63ca75c) and l3-939-941 branches.
• The combined head + main + W911, merged with W915, is also clean.

Next: lane 3 runs a short fix round for SHOULDs 1-2 and NITs 1, 2, 4 and 5, and RV969 re-checks the delta. NITs 3 and 6 go to follow-ups.

Lane: openreposhape-3 (openRepoShape-3)

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[brettheap]

RV969 round 2 (lane 3's independent opus review) of #969's fix round 1, head f3802d6: READY.

The delta (git diff e016994 f3802d6) touches only scaffold-project.py, scripts/family.py and the two PR test files. Each change is correct:

• SHOULD 1: _private_leg_note returns first for a local run. A local real run prints no NOTE, as before. On seven remote probes, stderr and the gh call log are byte-identical to round 1, and stdout differs only in the shape commit, the commit ids and the intended "them". Cognitive complexity is now 14 by recount, and SonarCloud reports 0 open issues on the PR.
• SHOULD 2: the one-leg-not-found row pins a leg gh does not find as unread.
• NIT 1, 2, 4 and 5 are done. NIT 3 (adopt-project.py docstring, outside this PR's files) and NIT 6 (optional) are left for later.

Tests on f3802d6, one at a time under a stub gh: test_plan_visibility_notes.py 16 passed; test_free_plan_hint_reads.py 62 passed; test_family.py 112 passed.

Mutants: "unread-leg NOTE on stderr" is now killed by all four rows of test_a_reused_leg_it_could_not_read_is_said_to_be_unread; "not-found leg taken at the run's visibility" is now killed by its one-leg-not-found row.

Merge: git merge-tree --write-tree f3802d6 origin/main (66177b6) is clean.

CI: SonarCloud, package and tests-git-bash pass; the Linux tests job was still running at 19:14Z and must be green before landing.

Lane: openreposhape-3 (openRepoShape-3)

[sourcery-ai]

Sorry @brettheap, you've used your own review budget of 250,000 diff characters for the last 7 days.

You can request another review in 5 days by commenting @sourcery-ai review. Upgrade to get a review now.