Repository navigation
Pin openRepoShape at v1.1.1, 5017830 on its main: four of the eight mounted files moved; no test expectation moved - #15
Conversation
…ounted files moved; no test expectation moved Brett Heap ruled openRepoShape v1.1.1 on 2026-10-22 (opensoft/openRepoTools#186). This is the code leg's pin, the one the suite mounts. The assembly root then points its `code` gitlink at the commit this change leaves on main. What moves, and nothing else: contracts/openreposhape-pin.yaml commit: 190133d5e704e380c430f87ca9c4e31746de0012 -> 50178305e4229275d18e71c2152403b4e9d3004e tree_sha256: 7a66972c7de193c050f77f97bffa13d8543c28d74f61ea210644e65aa3f37912 -> 204d73aabf2379554600234d4b36dc08d3c3a1da422395dec44637b5ca7a5184 upstream/openRepoShape (gitlink, 160000) 190133d5e704 -> 50178305e422 tests/test_install_payload_source.py (one docstring line) openRepoShape:547 at 190133d -> openRepoShape:745 at 5017830 v1.1.1 is an annotated tag, dereferenced locally: git rev-parse v1.1.1 'v1.1.1^{commit}' -> fd9316bb8e4f99d13a678b4bfc3846b4759ecbb7 (tag) -> 50178305e4229275d18e71c2152403b4e9d3004e On openRepoShape's main, as the pinned standard's rule 2 requires: git merge-base --is-ancestor 50178305e422 origin/main # exit 0 main is bd3e9c1485d3, 121 commits past it; v1.1.0..v1.1.1 is 70 commits. Bump run as contracts/openreposhape-pin.yaml states, the edit before the add: git -C upstream/openRepoShape fetch origin 50178305e4229275d18e71c2152403b4e9d3004e git -C upstream/openRepoShape checkout 50178305e4229275d18e71c2152403b4e9d3004e python3 -c "...from repo_shape import tree_digest; print(tree_digest('upstream/openRepoShape', 'HEAD'))" -> 204d73aabf2379554600234d4b36dc08d3c3a1da422395dec44637b5ca7a5184 git add contracts/openreposhape-pin.yaml upstream/openRepoShape The digest is recomputed, not adjusted, with the pinned checkout's own scripts/repo_shape.py. 190133d's helper and 5017830's helper print the same two numbers on both trees (7a66972c... for 190133d, 204d73aa... for 5017830, 366 records), so sorted-ls-tree-r-v1 means the same on both sides, and v1.1.1's change to repo_shape.py touches no tree_digest line. A reading of the forge's recursive tree listing on 2026-11-02 gave the same 204d73aa... independently. Only `commit:` and `digests.tree_sha256` change in the pin file. Nothing under upstream/openRepoShape was edited. Four of the eight files the suite mounts change at v1.1.1: scripts/repo_shape.py templates/assembly-root/scripts/bootstrap.py templates/family-root/scripts/bootstrap.py templates/family-root/scripts/siblings.py The two Makefiles and the two .gitignore files are byte-identical at both commits, and so is every file under templates/workspace-root/. The docstring of test_r01_composed_the_documented_one_liners_resolve_through_the_root_entry_point cited openRepoShape's --install pointer as openRepoShape:547 at 190133d. At the pinned 5017830 the same line is 745, and its bytes are unchanged: cmp <(git show 190133d:openRepoShape | sed -n 547p) \ <(git show 5017830:openRepoShape | sed -n 745p) # equal So only the citation moves with the pin, in the form opensoft/openRepoTools#233 used for 280 -> 547; the test's pipeline string is untouched. Every line that names 190133d or v1.1.0 as dated provenance (release.yml, the two release requirement locks, test_release_workflow.py, and the notes on v1.1.0's parse_yaml and layout) stays as it is. Part of opensoft/openRepoTools#186. Lane: openRepoTools-1 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Reviewer's GuideConfigurationUpdate the openRepoShape pin’s commit and tree digest together so the mounted revision and its recorded identity stay in sync.
Revise the release workflow’s provenance comments to describe the current pin while retaining the v1.1.0 adaptation history.
TestsUpdate the source citation for openRepoShape’s unchanged install-pointer line at the new pinned revision.
Clarify that the release-workflow test models the workflow at the commit currently named by the pin.
Lock files and vendored codeMove the mounted openRepoShape submodule gitlink to the pinned v1.1.1 commit.
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Lane openRepoTools-1, 2026-11-08T13:32:45Z: independent review of this PR, a check of the tree, not a landing word. The verdict is LAND after fixes, and the fixes are to text only. The review was run by a separate agent with no part in writing this PR. It ran on Sonnet 5.5 and worked only from fresh clones and from GitHub. What it checked, on the head
Findings and what was done with them:
Not yet checked: CI. Lane: openRepoTools-1 |
…eader keeps its v1.1.0 provenance Review finding S2, in #15 comment 6722132903: two comments still said, in the present tense, that `upstream/openRepoShape` is pinned at 190133d (v1.1.0), which stopped being true when this PR moved the pin to 50178305 (v1.1.1). Comments only. .github/workflows/release.yml, the header's first paragraph. The header was adapted from openRepoShape v1.1.0's own release.yml at 190133d, and that stays as dated provenance in the past tense: the commit `upstream/openRepoShape` "was pinned at when this was adapted". It now adds, as a dated fact, that the pin moved to 5017830, v1.1.1, whose release.yml differs from 190133d's in comment lines only. "190133d" and "openRepoShape v1.1.0" stay in the header, where HEADER_SECTIONS and HEADER_CARRIES in tests/test_release_workflow.py require them, the first one before every other section. tests/test_release_workflow.py, the comment above MODEL. It now says what the test reads: openRepoShape's own release.yml, in the pinned submodule, at whatever commit contracts/openreposhape-pin.yaml names. 5017830 (v1.1.1) is named as the commit the pin moved to from 190133d (v1.1.0), a dated fact that needs no edit at the next bump. The claim that the two upstream workflows differ in comment lines only was checked, not assumed: git -C upstream/openRepoShape diff 190133d 50178305 -- .github/workflows/release.yml shows 40 changed lines, every one a comment, and the file parses to the same data at both commits. Nothing else moves. In both files every changed line starts with `#` after its indent; the Python module's AST, docstrings included, is equal before and after; release.yml parses to the same data before and after. Part of opensoft/openRepoTools#186. Lane: openRepoTools-1 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…t would land on (part of opensoft/openRepoTools#186) Brett's answer of 16:21Z, relayed by lane 3 in opensoft/openRepoTools#165 (comment 6723967774), lands code#15 now, in v1.2.0, with the code leg's order first ready, first landed. The merge is clean, and B's change stays its five paths. Lane: openRepoTools-1 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
|
LANDING — lane openRepoTools-1, session df82f553-7803-49c4-8ddf-3f9acdcb8ee0@Eagle, 2026-11-08T19:29:21Z, PR #15 into opensoft/openRepoTools-code main → into main; head ce266b1; openRepoShape v1.1.1's code-leg pin (B, #186), on Brett Heap's dialog answer 'Land B now (Recommended)' (19:26:48Z); merge commit |
….1's pin) into the code-leg slice 1a (opensoft/openRepoTools#198) Main moved from 577110e to e393958 when #15 landed at 19:30:50Z: the pin of upstream/openRepoShape moved from 190133d (v1.1.0) to 5017830 (v1.1.1). The merge brings five files, +12 -8: - upstream/openRepoShape: the submodule pointer, 190133d -> 5017830; - contracts/openreposhape-pin.yaml: the pinned commit and its tree_sha256; - .github/workflows/release.yml: the header says the pin moved, and keeps its v1.1.0 provenance (comment lines only); - tests/test_release_workflow.py: the MODEL comment says the same (comment lines only); - tests/test_install_payload_source.py: one docstring names the pointer as openRepoShape:745 at 5017830. Why: this slice lands alone, by merge commit, as #16. Its landed tree must equal a tree CI tested green, so the slice takes the new main in place and is tested there. Slice 1a stood on 577110e, the previous main, and would otherwise be tested on a main that is no longer the one it lands on. The merge is clean: no hunk was resolved by hand. git merge-tree of e393958 into 903d751 gave tree 14d48cf before the merge was made. Lane: openreposhape-2 (openRepoShape-2) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>



Lane: openRepoTools-1
Claim: opensoft/openRepoTools#186 (comment)
What changes
This PR moves the code leg's pin on openRepoShape from v1.1.0 to v1.1.1, in one commit:
contracts/openreposhape-pin.yaml:commit:moves from190133d5e704e380c430f87ca9c4e31746de0012to50178305e4229275d18e71c2152403b4e9d3004e.digests.tree_sha256moves from7a66972c7de193c050f77f97bffa13d8543c28d74f61ea210644e65aa3f37912to204d73aabf2379554600234d4b36dc08d3c3a1da422395dec44637b5ca7a5184.upstream/openRepoShapemoves from190133d5e704to50178305e422, together with the pin file.tests/test_install_payload_source.py, one docstring line:--installpointer changes fromopenRepoShape:547 at 190133dtoopenRepoShape:745 at 5017830.cmpequal).Nothing else moves in this commit.
190133d:.github/workflows/release.yml:6-7andtests/test_release_workflow.py:144-145.7e1df87eon this branch fixes both (review finding S2): they now say that the pin moved to5017830(v1.1.1).190133dthattests/test_release_workflow.py'sHEADER_SECTIONScheck needs inrelease.yml's header.parse_yamland layout.Why
Two rulings of Brett Heap's govern this, on opensoft/openRepoTools#186:
190133d). v1.1.1 is a pin bump after the cutover.").This PR moves the code leg's mounted pin. opensoft/openRepoTools#348 moves the root's shape copies.
v1.1.1is the annotated tagfd9316bb8e4f99d13a678b4bfc3846b4759ecbb7. It peels to50178305…, which is an ancestor of openRepoShape'smain(bd3e9c1485d3, 121 commits later). The pinned-standard rule allows only a commit onmain, and this one is.How the values were made
The bump follows the procedure in the pin file's header, with the edit before the
git add:50178305…inupstream/openRepoShape.repo_shape.tree_digest.The digest is recomputed, never adjusted:
sorted-ls-tree-r-v1means the same on both sides.204d73aa…independently.Four of the eight files the suite mounts change at v1.1.1:
scripts/repo_shape.pytemplates/assembly-root/scripts/bootstrap.pytemplates/family-root/scripts/bootstrap.pytemplates/family-root/scripts/siblings.pyThe two Makefiles and the two
.gitignorefiles are byte-identical at both commits.Order
PR C waits for this PR. The root's PR C points the assembly's
codegitlink andcontracts/code-pin.yamlat the commit this PR leaves onmain. C'sexact-pinsjob then runs the composed suite at that commit, withupstream/openRepoShapeat v1.1.1. That run also covers the nine composed-acceptance tests that skip below.The order on the code leg:
mainat577110e4.HOLD. Whichever lands second merges the newmainin place and re-runs before it lands.main577110e4in place, asce266b1d, with no force-push. The merge is clean, and the PR's change is still its five paths.ce266b1d.codepin, together with T017's bump where both are ready.No release
Nothing here is tagged or published. The leg's
release/v1.1branch and its tagv1.1.0stay at2a057a6d.This PR would still ship in v1.2.0 if it lands before that tag (review finding S3).
mainat v1.2.0's tag ships in v1.2.0.Local tests
Setup:
mainat2a057a6d, with this commit on top and the submodule checked out at50178305. These ran before the merge of577110e4; the PR's CI runs on the merge,ce266b1d;OPENREPOTOOLS_COMPOSED=0), in a clean environment;Results:
tests/test_upstream_pin.py: 15 passed in 0.07s. It checks:tests/test_install_payload_source.py: 100 passed, 9 skipped in 167.96s.tests/test_park_resume_commands.py: 223 passed in 45.79s. It builds real estates from the four changed mounted files.The rest of the suite is CI's job.
CI
The four required
tests.ymljobs areguard-launch-mode,tests,tests-no-submoduleandpackage.This PR touches no shell file: it changes one YAML file, one Python test file and the gitlink. So SonarCloud's charge on
lanes-edit.shdoes not apply to it.Landing
This PR lands only on Brett Heap's word.
🤖 Generated with Claude Code