Skip to content

Validate active Kimi hook declarations in doctor - #70

Merged
bigboateng merged 2 commits into
mainfrom
fix/kimi-hook-readiness
Oct 13, 2026
Merged

bigboateng merged 2 commits into
mainfrom
fix/kimi-hook-readiness

Conversation

@bigboateng

@bigboateng bigboateng commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Change contract

When: A user runs pitot doctor --host kimi to check their hook configuration.
Before: Comments, echoed command text, or fields from different hook entries could produce a ready result. Equivalent single-quoted TOML could be reported missing, and the matcher was not checked.
After: Doctor parses TOML and validates each hook entry. A valid PreToolUse rule must cover Bash and declare a recognized direct pitot hook kimi command. Invalid configuration and routing that requires manual verification have distinct diagnostics and fail the check.

Boundaries preserved

  • Doctor inspects configuration without editing it or executing hook commands.
  • Existing probe time and output limits remain in place; failed, partial or truncated probes cannot establish readiness.
  • Other host checks and the generated Kimi snippet retain their behavior.

Evidence

Scenario or check Expected result Observed result
Canonical hooks, equivalent TOML, literal POSIX paths and runtime arguments Recognize supported declarations Passed controlled CLI and Go regressions
Comments, unrelated values, cross-entry fields and echoed commands Do not report readiness Passed controlled CLI and Go regressions
Invalid TOML, hook types, events, peer entries and timeouts Report invalid configuration without exposing parser source text Passed
Wrappers, unsupported matcher syntax and Windows expansions/escapes Report unverified routing Passed, including nine Windows ambiguity controls
Go suite, race checks, static checks, formatting and maintenance tests Pass Passed; 198 maintenance tests, one existing platform-specific skip
Fresh native agent and runtime captures Pass on the reviewed source Passed: 33 agent cells and 3 runtimes (capture run)
Pull request CI Pass on the final revision Passed: all 49 checks on 2bb7fdcf53d9 (PR checks); the current report shows 33 agent cells and 3 runtimes passing

Failure and recovery

Invalid, missing or unverified routing returns a failing diagnostic. Users can inspect their configuration and verify indirect commands manually; no configuration migration or automatic rewrite is performed.

Remaining limits

Readiness describes the inspected hook declaration and bounded agent probe. It does not establish hook execution or a live controller connection. Arbitrary shell scripts, regular expressions and Windows command interpretation require manual verification. Kimi's documented hook failure behavior remains fail-open.

@github-actions

Copy link
Copy Markdown

Pitot coding-agent E2E

Intelligence Flow is the verification source; Pitot's public README carries the latest main status.

Agent Ubuntu macOS Windows Result Evidence
Claude ✅ Pass · real CLI 2.1.296 · native · binary-observed anthropic messages ✅ Pass · real CLI 2.1.296 · native · binary-observed anthropic messages ✅ Pass · real CLI 2.1.296 · native · binary-observed anthropic messages ✅ Passing All platforms are required
Cursor ✅ Pass · real CLI 2026.10.01-e373342 · native · binary-observed cursor connect proto ✅ Pass · real CLI 2026.10.01-e373342 · native · binary-observed cursor connect proto ✅ Pass · real CLI 2026.10.01-e373342 · native · binary-observed cursor connect proto ✅ Passing All platforms are required
Codex ✅ Pass · real CLI 0.162.1 · native · binary-observed openai responses ✅ Pass · real CLI 0.162.1 · native · binary-observed openai responses ✅ Pass · real CLI 0.162.1 · native · binary-observed openai responses ✅ Passing All platforms are required
Devin ✅ Pass · real CLI 3000.11.3 · native · binary-observed devin connect proto ✅ Pass · real CLI 3000.11.3 · native · binary-observed devin connect proto ✅ Pass · real CLI 3000.11.3 · native · binary-observed devin connect proto ✅ Passing All platforms are required
DeepSeek Harness ✅ Pass · real CLI 0.2.0-rc.2 · native · binary-observed openai chat ✅ Pass · real CLI 0.2.0-rc.2 · native · binary-observed openai chat ✅ Pass · real CLI 0.2.0-rc.2 · native · binary-observed openai chat ✅ Passing All platforms are required
GitHub Copilot CLI ✅ Pass · real CLI 1.0.95 · native · binary-observed openai chat ✅ Pass · real CLI 1.0.95 · native · binary-observed openai chat ✅ Pass · real CLI 1.0.95 · native · binary-observed openai chat ✅ Passing All platforms are required
Gemini ✅ Pass · real CLI 0.63.0 · native · binary-observed gemini generate content ✅ Pass · real CLI 0.63.0 · native · binary-observed gemini generate content ✅ Pass · real CLI 0.63.0 · native · binary-observed gemini generate content ✅ Passing All platforms are required
Kimi Code ✅ Pass · real CLI 2.1.1 · native · binary-observed openai chat ✅ Pass · real CLI 2.1.1 · native · binary-observed openai chat ✅ Pass · real CLI 2.1.1 · native · binary-observed openai chat ✅ Passing All platforms are required
OpenCode ✅ Pass · real CLI 2.0.27 · native · binary-observed openai responses ✅ Pass · real CLI 2.0.27 · native · binary-observed openai responses ✅ Pass · real CLI 2.0.27 · native · binary-observed openai responses ✅ Passing All platforms are required
Pi ✅ Pass · real CLI 1.1.0 · native · binary-observed openai chat ✅ Pass · real CLI 1.1.0 · native · binary-observed openai chat ✅ Pass · real CLI 1.1.0 · native · binary-observed openai chat ✅ Passing All platforms are required
Qwen Code ✅ Pass · real CLI 0.25.1 · native · binary-observed openai chat ✅ Pass · real CLI 0.25.1 · native · binary-observed openai chat ✅ Pass · real CLI 0.25.1 · native · binary-observed openai chat ✅ Passing All platforms are required

Runtime capabilities

Capability Ubuntu macOS Windows Result
pitot request ✅ Pass · real runtime allow/deny ✅ Pass · real runtime allow/deny ✅ Pass · real runtime allow/deny ✅ Passing

Source commit: 2bb7fdcf53d9

@bigboateng
bigboateng merged commit 3477ee1 into main Oct 13, 2026
49 checks passed
@bigboateng
bigboateng deleted the fix/kimi-hook-readiness branch October 13, 2026 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant