Repository navigation
Validate active Kimi hook declarations in doctor - #70
Merged
Merged
Conversation
Pitot coding-agent E2EIntelligence Flow is the verification source; Pitot's public README carries the latest
Runtime capabilities
Source commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change contract
When: A user runs
pitot doctor --host kimito check their hook configuration.Before: Comments, echoed command text, or fields from different hook entries could produce a ready result. Equivalent single-quoted TOML could be reported missing, and the matcher was not checked.
After: Doctor parses TOML and validates each hook entry. A valid
PreToolUserule must coverBashand declare a recognized directpitot hook kimicommand. Invalid configuration and routing that requires manual verification have distinct diagnostics and fail the check.Boundaries preserved
Evidence
2bb7fdcf53d9(PR checks); the current report shows 33 agent cells and 3 runtimes passingFailure and recovery
Invalid, missing or unverified routing returns a failing diagnostic. Users can inspect their configuration and verify indirect commands manually; no configuration migration or automatic rewrite is performed.
Remaining limits
Readiness describes the inspected hook declaration and bounded agent probe. It does not establish hook execution or a live controller connection. Arbitrary shell scripts, regular expressions and Windows command interpretation require manual verification. Kimi's documented hook failure behavior remains fail-open.