Repository navigation
Fix Windows dev launchers and bound captured-output cleanup - #77
Merged
Merged
Conversation
Pitot coding-agent E2EIntelligence Flow is the verification source; Pitot's public README carries the latest
Runtime capabilities
Source commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change contract
When: A developer launches Codex or Qwen through
pitot devon Windows, or captures output from an agent that leaves a child holding its output pipe.Before: npm
.cmdlaunchers went directly to process execution, the dev integration tests skipped Windows, and inherited output pipes could delay cleanup and eventually report success.After: Supported npm launchers resolve to their declared Node entrypoints with unchanged arguments. Incomplete captured output returns an error after a two-second drain limit. Native helper tests exercise runtime decisions and cleanup on all three supported operating systems.
Boundaries preserved
node.exeprecedence, direct executable invocation and the distinction between--execfield splitting and explicit argv.Evidence
Failure and recovery
Unsupported wrappers explain how to invoke the trusted Node entrypoint explicitly. Revert this change to restore prior launch behavior if a compatibility regression appears.
Remaining limits
Only the supported plain-Node npm wrapper is recognized. Package metadata checks do not authenticate installed code. The output drain limit does not terminate arbitrary descendant processes. Tests use local helpers and replay infrastructure without model calls.