Skip to content

Add Lixray account-token sharing and update workspace integration - #277

Merged
samuelstroschein merged 12 commits into
mainfrom
codex/share-lixray
Sep 26, 2026
Merged

samuelstroschein merged 12 commits into
mainfrom
codex/share-lixray

Conversation

@samuelstroschein

Copy link
Copy Markdown
Member

Add a Share button for the active file. Users initialize persistent history if needed, create an account API token in Lixray settings, paste it into Flashtype, and confirm private repository sync plus publication of the selected file. The token is validated before storage and encrypted with Electron safeStorage; no desktop OAuth or repository-token compatibility path remains.

The initial upload preserves repository history and uses a durable snapshot for safe retries. Saved connections resume on reopen, bind to the local repository and account, and retain local editing when authentication or sync is unavailable. Publication waits for the chosen file to reach the server. Requires the Lixray gateway/account-token implementation in https://github.com/opral/lixray/pull/356.

Also completes the Lix 0.16 / Atelier integration: use Atelier's editors and review intent, remove unused duplicate editors, expose history context and review actions, add CSV default opening, enforce the 1 GB initialization limit, and recover safely from stalled or crashed repository opens. Updated E2E expectations follow the current Atelier Files and review UI.

Validation: subagent security and integration reviews addressed; 241 unit tests and production build pass. Native Share, CSV opening, recovery, history, workspace windows, and editor fuzz tests pass locally. CI additionally validates the packaged macOS application.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 9, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-09T19:46:32.534604Z 7b2acdc PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7b2acdc255

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread electron/share-service.mjs Outdated
Comment on lines +124 to +130
const lix = await getLix(window);
const result = await lix.execute(
"SELECT id, content FROM lix_file WHERE path = $1",
[filePath],
);
if (!result.rows.length)
throw new Error(

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Allow deleted files to be unpublished

When a published file is subsequently deleted locally while its document view remains open, clicking Unpublish file always fails because this existence check runs for both publishing and unpublishing. The DELETE request does not need local content or synchronization verification, so the missing-file check should apply only when publish is true; otherwise users cannot revoke the publication through the advertised Share action without first recreating the file.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in b21a691. Unpublish now bypasses local repository/content access and sync verification; the regression test revokes a deleted file while local storage is unavailable and sync is offline.

@blacksmith-sh

This comment has been minimized.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Sep 9, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
flashtype-website a8adeeb Commit Preview URL

Branch Preview URL
Sep 26 2026, 12:34 AM

samuelstroschein and others added 5 commits September 9, 2026 13:21
0.18.1 fixes Undo leaving agent edits in place. It also removes the zero-
and one-argument lix_create_checkpoint calls, so the metadata checkpoint
passes NULL title and comment, and Atelier moves to the dev-25-09 commit
that uses the (title, comment) form.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@samuelstroschein
samuelstroschein enabled auto-merge (squash) September 25, 2026 23:30
Atelier #196 merged; main has the same tree as the dev-25-09 commit
this branch was tested against.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
samuelstroschein and others added 2 commits September 26, 2026 00:04
Atelier dev-25-09 keeps the agent's terminal tab when a review reveals a
file (opral/atelier#197). Re-pin to Atelier main once that merges.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Atelier #197 merged the review-reveal tab fix together with markdown
caret and keyboard fixes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@samuelstroschein
samuelstroschein merged commit ea7f148 into main Sep 26, 2026
4 checks passed
@samuelstroschein
samuelstroschein deleted the codex/share-lixray branch September 26, 2026 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant