Skip to content

PR #137 review-leftover: the details list says "the added prop" for MessagesTimeline.tsx, but the line passes an existing prop to the row builder #138

Open

Description

@orbitingflea

[review-leftover] #137

  • PR feat(fork): hide Working and Thinking rows outside Normal display mode #137 body, details list: MessagesTimeline.tsx +2 −1 (the added prop, …) says the commit adds a prop, but repliesChosen was already a prop of MessagesTimeline. The added line, apps/web/src/components/chat/MessagesTimeline.tsx:668, passes repliesChosen into the input of useIncrementalTimelineRows(...). Better wording: "passing the flag to the row builder". The line counts are correct.

Non-blocking wording note from a passed review round; no code change.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions