Skip to content

PR #156 review-leftover: The seen ref starts as undefined, which is also the value every Normal row e [e44df46492a6] #157

Open

Description

@orbitingflea

[review-leftover] #156

  • apps/server/src/fork/displayModeWrap/NewThreadDisplayMode.test.ts:103 The seen ref starts as undefined, which is also the value every Normal row expects, so those rows would pass even if the wrapper skipped the launch. In particular, "a failed thread lookup still runs the launch in Normal" (line 78) does not verify that the launch actually runs; add an assertion that the launch was called.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions