Skip to content

fix(fork): display modes load only the history they show #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
orbitingflea merged 2 commits into from
Nov 13, 2026
Merged

fix(fork): display modes load only the history they show #140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be66f94
test(fork): display modes must open on shown messages in bot-heavy th…
orbitingflea Nov 13, 2026
bea4716
fix(fork): display modes load only the history they show
orbitingflea Nov 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions apps/server/src/environment/ServerEnvironment.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,7 @@ export const make = Effect.gen(function* () {
usagePriceOverrides: true,
usageModelAliases: true,
threadDisplayModes: true,
threadShownHistory: true,
threadPinning: true,
threadPinReorder: true,
threadActiveReorder: true,
Expand Down
5 changes: 2 additions & 3 deletions apps/server/src/fork/displayModeWrap/DisplayModeWrap.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ import {
NORMAL_DISPLAY_MODE,
resolveDisplayMode,
foldCores,
SEND_TO_USER_PAYLOAD_LIKE,
SUB_THREAD_WINDOW_CORES,
subThreadCores,
subThreadOfRecords,
Expand All @@ -34,6 +33,7 @@ import type * as SqlError from "effect/sql/SqlError";
import * as ProjectionStore from "../../orchestration-v2/ProjectionStore.ts";
import * as ProviderRegistry from "../../provider/ProviderRegistry.ts";
import * as ServerSettings from "../../serverSettings.ts";
import { sendCallSql } from "../shownHistory/ShownHistory.ts";
import * as SubThreads from "../subThreads/SubThreads.ts";
import { createToldTable } from "./DisplayModeCompactionNote.ts";

Expand Down Expand Up @@ -251,8 +251,7 @@ export const layer: Layer.Layer<
}

// The screen shows only user messages and send_to_user calls, so the query steps over other rows.
const shownOnly = sql`(item.type = 'user_message' OR (item.type = 'dynamic_tool'
AND item.payload_json LIKE ${SEND_TO_USER_PAYLOAD_LIKE}))`;
const shownOnly = sql`(item.type = 'user_message' OR ${sendCallSql(sql)})`;
const found: OrchestrationV2TurnItem[] = [];
let cores = 0;
let passedTyped = before !== null;
Expand Down
Loading
Loading