Skip to content

Show a Board button when the whiteboard collapses its board panel - #15

Merged
orbitingflea merged 2 commits into
wbfrom
wb-board-button
Oct 10, 2026
Merged

orbitingflea merged 2 commits into
wbfrom
wb-board-button

Conversation

@orbitingflea

Copy link
Copy Markdown
Owner

Chat-only half of the whiteboard's collapsible split (the whiteboard PR bumps the submodule to this commit).

  • The whiteboard page posts wb-layout { boardHidden }; the chat asks for it once on mount with wb-layout-get, since the first report can arrive before React listens.
  • While the board is collapsed, a ghost Board button sits before the sidebar trigger and posts wb-show-board. The header content shifts right by the button's width.
  • Standalone /chat/ (no parent frame) never shows the button.

🤖 Generated with Claude Code

Inside the whiteboard iframe, the parent page reports the split layout.
While the board is collapsed, a Board button before the sidebar trigger
asks the parent to restore the split.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings October 10, 2026 11:26

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-10T11:31:36.621087Z 87b3da7 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions github-actions Bot added vouch:trusted Author is trusted by repo permissions or the VOUCHED list. size:M labels Oct 10, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 87b3da7118

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

>
{boardHidden && (
<Button
className="pointer-events-auto mr-2 w-18"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Move Board-button layout to a wrapper

The shared Button is resized and spaced directly with w-18 and mr-2. This repository requires app code to choose a Button variant/size and place width and margin on a parent, so wrap this control in the five-rem layout container and leave the primitive’s appearance to size="sm" and variant="ghost"; otherwise the titlebar geometry depends on an unsupported restyle of the UI primitive.

AGENTS.md reference: AGENTS.md:L155-L155

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 2d8fcc7: width and margin now sit on a wrapper div; the Button keeps only size and variant.

Comment on lines +92 to +97
if (event.source === window.parent && event.data?.type === "wb-layout") {
setBoardHidden(event.data.boardHidden === true);
}
};
window.addEventListener("message", receive);
window.parent.postMessage({ type: "wb-layout-get" }, "*");

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Update the embedding protocol checklist

The existing run-t3.md embedding checklist says it must remain current for upstream ports, but its parent-window entry still enumerates only wb-project and wb-insert-ref. Without recording the new wb-layout, wb-layout-get, and wb-show-board protocol and collapsed-board control in the affected bullets, a future routine update can silently omit this cross-repository behavior; update the existing documentation rather than leaving the contract discoverable only in this component.

AGENTS.md reference: AGENTS.md:L123-L124

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 2d8fcc7: the parent-window bullet in run-t3.md now lists wb-layout-get, wb-layout and wb-show-board, and names AppSidebarLayout.tsx.

Comment on lines +169 to +170
variant="ghost"
onClick={() => window.parent.postMessage({ type: "wb-show-board" }, "*")}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Give the Board button backdrop-aware contrast

When the board is hidden while the thread sidebar is open in a Dev or Nightly environment using artwork identification, this fixed control sits over SidebarStageBackdrop. The adjacent sidebar trigger switches to media-navigation and resets that variant’s positioning for readable white-on-artwork contrast, but the Board control remains a foreground-colored ghost button, leaving its label and icon low-contrast or effectively invisible against the dark artwork; apply the same backdrop-aware visual treatment to this control.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not changing. The artwork only shows when the stage label is Dev or Nightly. This copy runs as a production build with a non-nightly server version, so its label is Alpha and the backdrop never renders.

…un-t3.md

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@orbitingflea
orbitingflea merged commit 8d34c97 into wb Oct 10, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M vouch:trusted Author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants