Repository navigation
fix(ci): pin unenv so release smoke installs resolve its exact peer - #152
Merged
Merged
Conversation
Release smoke deletes the lockfile and resolves from the registry. @alchemy.run/cloudflare-runtime asks for unenv ^2.0.0-rc.24, so once unenv 2.0.0-rc.25 passed the one-day release-age gate, that install picked rc.25. @cloudflare/unenv-preset 2.16.2 peers on exactly 2.0.0-rc.24, and strictPeerDependencies fails the install. Port of upstream pingdotgg#36638. (cherry picked from commit 8a072ca) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Other scenariosAll 64 scenario measurements match All 64 scenario measurements
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request pins unenv to 2.0.0-rc.24 so that Release Smoke, and with it the required Check job, passes again.
改了什么行为
Behaviour change: no. The committed lockfile already resolves unenv 2.0.0-rc.24, so installs from the lockfile do not change.
Cause and fix
Release Smoke deletes the lockfile in a temporary copy of the workspace and resolves every package again from the registry. The Cloudflare runtime package of alchemy asks for unenv
^2.0.0-rc.24. Once unenv 2.0.0-rc.25 passed the one-day release-age gate, that resolve took rc.25.@cloudflare/unenv-preset2.16.2 asks for exactly 2.0.0-rc.24 as a peer, andstrictPeerDependenciesfails the install.The fix adds
unenv: 2.0.0-rc.24tooverridesinpnpm-workspace.yaml, with the matching line inpnpm-lock.yaml. It is a port of upstream pingdotgg#36638, unchanged.Verification
node scripts/release-smoke.tsfails on the base with the unmet unenv peer, and passes with this change.pnpm install --frozen-lockfilereports the lockfile up to date.vp run check:changedpasses.Scope
check:changed.@cloudflare/unenv-presetto a newer unenv, the next upstream catch-up takes upstream's version of this line.