Skip to content

Twelve cgn patch 1 #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
twelve-cgn wants to merge 2 commits into from
Closed

Twelve cgn patch 1 #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c63046
Fix assignment of AppUpdateSuccessListener and ResumeSuccessListener
twelve-cgn Oct 15, 2026
ae3c4a6
Check activity state in OnSuccess method
twelve-cgn Oct 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/libs/Maui.Android.InAppUpdates/Platforms/Android/AppUpdateSuccessListener.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,11 @@ public class AppUpdateSuccessListener(

public void OnSuccess(Java.Lang.Object? result)
{
if (activity.IsFinishing || activity.IsDestroyed)
{
return;
}

if (result is not AppUpdateInfo info)
{
return;
Expand Down Expand Up @@ -69,4 +74,4 @@ public void OnSuccess(Java.Lang.Object? result)
break;
}
}
}
}
8 changes: 5 additions & 3 deletions src/libs/Maui.Android.InAppUpdates/Platforms/Android/Handler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,11 @@ public static void HandleCreate(Activity activity, Bundle? savedInstanceState)
AppUpdateManager = Options.UseFakeAppUpdateManager
? new FakeAppUpdateManager(activity)
: AppUpdateManagerFactory.Create(activity);
AppUpdateSuccessListener ??= new AppUpdateSuccessListener(
AppUpdateSuccessListener = new AppUpdateSuccessListener(
appUpdateManager: AppUpdateManager,
activity: activity,
updateRequest: Options.RequestCode);

AppUpdateManager.GetAppUpdateInfo().AddOnSuccessListener(AppUpdateSuccessListener);
}

Expand All @@ -58,10 +59,11 @@ public static void HandleResume(Activity activity)
return;
}

ResumeSuccessListener ??= new ResumeSuccessListener(
ResumeSuccessListener = new ResumeSuccessListener(
appUpdateManager: AppUpdateManager,
activity: activity,
updateRequest: Options.RequestCode);

AppUpdateManager.GetAppUpdateInfo().AddOnSuccessListener(ResumeSuccessListener);
}

Expand Down Expand Up @@ -99,4 +101,4 @@ public static void HandleActivityResult(
break;
}
}
}
}