Sb/2d load and render - #109
Merged
Merged
Conversation
added 2 commits
September 29, 2026 18:11
… sheet drawn from its definition Definition format gains `sheet` (systemBuilder/sheet.js): tabs, header and sections of text/number/textarea/select fields with visibility, combat sensitivity, max pairs and token/bank links, checked like the rest; a system with no sheet gets a starter one. systemBuilder/runtime.js loads PUBLISHED systems (never drafts) into memory, compiled into the meta the built-in templates carry, and sheets/templates.js reaches it through a hook (a require would be circular). Built-ins are always found first, so they cannot change. Publish and delete reload it; the picker lists published systems and can switch to them; GET /api/systems/render/:id gives browsers layout and words, never formulas. Frontend: sheets/customTemplates.ts turns the render copy into a SheetTemplate for the ordinary SheetRenderer; getTemplate answers for custom systems; a hook redraws when one arrives. Tests mutation-checked (render leak, drafts, reload, writable links, fetch dedupe). Verified end to end on a throwaway secure-mode server: create, publish, switch, a player's socket edit saved with derived values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Pre-merge checklist
Code quality:
Version & Release:
frontend/package.jsonversiondocker-compose.ymlAPP_VERSIONCHANGELOG.mdwith release notesBefore merging to main:
Related issues