feat: custom systems mark fields as the GM's to set, and give NPCs th… - #111
Merged
Merged
Conversation
…eir own layout and tiers A sheet field can say edit: 'gm' (XP, awarded items): its owner sees it and cannot change it, by a single edit, a batch edit or an upload, while the GM, a granted admin and the GM's own sheet window still can. Derived values stay locked by the recompute, as on the built-ins. A system's npc section gives NPCs a stat-block layout of their own and GENERATE_SHEET tiers (label, token HP and defense, starting values, derived values worked out). Both layouts share the system's rules, so a field on both must be linked the same way; only the character sheet says what players may see. A tier that leaves out HP or defense keeps the token's own. Built-in systems mark no GM fields and keep their code tiers, looked up first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…eir own layout and tiers
A sheet field can say edit: 'gm' (XP, awarded items): its owner sees it and cannot change it, by a single edit, a batch edit or an upload, while the GM, a granted admin and the GM's own sheet window still can. Derived values stay locked by the recompute, as on the built-ins.
A system's npc section gives NPCs a stat-block layout of their own and GENERATE_SHEET tiers (label, token HP and defense, starting values, derived values worked out). Both layouts share the system's rules, so a field on both must be linked the same way; only the character sheet says what players may see. A tier that leaves out HP or defense keeps the token's own.
Built-in systems mark no GM fields and keep their code tiers, looked up first.
Summary
Test plan
Pre-merge checklist
Code quality:
Version & Release:
frontend/package.jsonversiondocker-compose.ymlAPP_VERSIONCHANGELOG.mdwith release notesBefore merging to main:
Related issues