feat: the heart monitor's beat follows how hurt someone is, not just … - #114
Merged
Merged
Conversation
…its color The monitor's color always changed with health; now its rhythm does too, on the same thresholds: steady over half, twice as fast at half or less, fast, uneven and weakening at a quarter or less, then the flatline. Still no numbers, in the HEALTH folder and on the stream overlay alike, which now share one band rather than two copies of the thresholds. With reduced motion the trace holds still but keeps its shape, and a screen reader hears how it looks. The steady beat is the trace the monitor has always drawn.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…its color
The monitor's color always changed with health; now its rhythm does too, on the same thresholds: steady over half, twice as fast at half or less, fast, uneven and weakening at a quarter or less, then the flatline. Still no numbers, in the HEALTH folder and on the stream overlay alike, which now share one band rather than two copies of the thresholds. With reduced motion the trace holds still but keeps its shape, and a screen reader hears how it looks.
The steady beat is the trace the monitor has always drawn.
Summary
Test plan
Pre-merge checklist
Code quality:
Version & Release:
frontend/package.jsonversiondocker-compose.ymlAPP_VERSIONCHANGELOG.mdwith release notesBefore merging to main:
Related issues