feat: what a token's HEALTH folder is sent under a custom health model - #115
Merged
Merged
Conversation
systemBuilder/healthView.js works out the view, and the socket's requestHealthView sends it to the asker alone. Whoever may change the token's health (the GM, a player granted editing, the token's owner) gets the full detail: a second track's numbers, box marks, harm notes, the wound penalty, location notes. Everyone else gets a description only: a fill, light against heavy, the worst harm's name, WOUNDED, which locations are hurt. An NPC's owner field never grants the full view. Over the socket because that is where a player's identity is known in every mode. Actions also report what the window needs to say: how many boxes turned heavier, and which level harm landed on. A second track's maximum is set on the sheet; every other SET MAX stays on the token as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
systemBuilder/healthView.js works out the view, and the socket's requestHealthView sends it to the asker alone. Whoever may change the token's health (the GM, a player granted editing, the token's owner) gets the full detail: a second track's numbers, box marks, harm notes, the wound penalty, location notes. Everyone else gets a description only: a fill, light against heavy, the worst harm's name, WOUNDED, which locations are hurt. An NPC's owner field never grants the full view. Over the socket because that is where a player's identity is known in every mode.
Actions also report what the window needs to say: how many boxes turned heavier, and which level harm landed on. A second track's maximum is set on the sheet; every other SET MAX stays on the token as before.
Summary
Test plan
Pre-merge checklist
Code quality:
Version & Release:
frontend/package.jsonversiondocker-compose.ymlAPP_VERSIONCHANGELOG.mdwith release notesBefore merging to main:
Related issues