feat: a custom system's words in the shops and the bank button - #120
Merged
Merged
Conversation
The shop window's messages, its receipt and the server's refusals (data/shopRules refusalText), the steps for stocking an empty shop, and the SHOP, VIEW_BANK and SHOP_CATALOGUES buttons ask for their words with the text they show today. A custom system that calls its shops MERCHANTS reads 'NOTHING HERE THIS MERCHANT WOULD BUY' and 'THE MERCHANT PAYS YOU'; one that renamed nothing, and every built-in system, reads exactly as before. The admin's SHOP_CATALOGUES button moved into this piece because the shop's own text names it. Custom systems have no shops yet (shopsAvailable knows only the built-in systems), so none of this shows until shops are turned on for them. Lines no custom system can reach yet - the cyberware notes, and placement into CWN's slots - keep today's text and are noted for the pieces that make them reachable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shop window's messages, its receipt and the server's refusals (data/shopRules refusalText), the steps for stocking an empty shop, and the SHOP, VIEW_BANK and SHOP_CATALOGUES buttons ask for their words with the text they show today. A custom system that calls its shops MERCHANTS reads 'NOTHING HERE THIS MERCHANT WOULD BUY' and 'THE MERCHANT PAYS YOU'; one that renamed nothing, and every built-in system, reads exactly as before. The admin's SHOP_CATALOGUES button moved into this piece because the shop's own text names it.
Custom systems have no shops yet (shopsAvailable knows only the built-in systems), so none of this shows until shops are turned on for them. Lines no custom system can reach yet - the cyberware notes, and placement into CWN's slots - keep today's text and are noted for the pieces that make them reachable.
Summary
Test plan
Pre-merge checklist
Code quality:
Version & Release:
frontend/package.jsonversiondocker-compose.ymlAPP_VERSIONCHANGELOG.mdwith release notesBefore merging to main:
Related issues