feat: a custom system's words in the building GM notes and the admin … - #123
Merged
Merged
Conversation
…GAME tab The building window's GM NOTES folder and header, the admin editor's label and its save messages, BANK SOUNDS and the INITIATIVE FOLLOWS BUILDING house rule (label and tooltip) ask for their words with the text they show today. The notes box's screen-reader label, shared with the token window, now names the GM in the system's word too; 3a3 had missed it. Built-in systems and a custom system that renamed nothing read exactly as before. The XP window, the vehicles window and the shop buy-back rate keep today's text: no custom system can reach them until its XP, vehicles and shops arrive (3b).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…GAME tab
The building window's GM NOTES folder and header, the admin editor's label and its save messages, BANK SOUNDS and the INITIATIVE FOLLOWS BUILDING house rule (label and tooltip) ask for their words with the text they show today. The notes box's screen-reader label, shared with the token window, now names the GM in the system's word too; 3a3 had missed it.
Built-in systems and a custom system that renamed nothing read exactly as before. The XP window, the vehicles window and the shop buy-back rate keep today's text: no custom system can reach them until its XP, vehicles and shops arrive (3b).
Summary
Test plan
Pre-merge checklist
Code quality:
Version & Release:
frontend/package.jsonversiondocker-compose.ymlAPP_VERSIONCHANGELOG.mdwith release notesBefore merging to main:
Related issues