Repository navigation
feat(system-builder): list problem counts and install names ahead (4a… - #166
Merged
Merged
Conversation
…1b1) listSystems gives each system's `problemCount` (store.problemsOf, shared with getSystem: a draft that can't be read counts as one), so SYSTEMS.EXE can badge problems without fetching every system. previewInstall gives `installsAs`, the name each install mode would use (store.installNames: null where the mode doesn't apply). installSystem now takes its name from the same function, so the preview and the install can't disagree. matchesFor also returns the systems in use. citysys.summarize counts currencies, for the preview's INSIDE badges.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…1b1)
listSystems gives each system's
problemCount(store.problemsOf, shared with getSystem: a draft that can't be read counts as one), so SYSTEMS.EXE can badge problems without fetching every system.previewInstall gives
installsAs, the name each install mode would use (store.installNames: null where the mode doesn't apply). installSystem now takes its name from the same function, so the preview and the install can't disagree. matchesFor also returns the systems in use.citysys.summarize counts currencies, for the preview's INSIDE badges.
Summary
Test plan
Pre-merge checklist
Code quality:
Version & Release:
frontend/package.jsonversiondocker-compose.ymlAPP_VERSIONCHANGELOG.mdwith release notesBefore merging to main:
Related issues