Repository navigation
feat(system-builder): CREATE refuses a taken name; UPDATE can replace… - #167
Merged
Merged
Conversation
… changes (4a1b1b)
createSystem refuses a name another system not deleted has (409, store.nameTaken, shared
with renameSystem).
installSystem takes { text, mode, replaceChanges }. An update over a system changed here since
it was installed is no longer refused outright: without `replaceChanges: true` it answers 409
with `changed: true`, so the window can warn and confirm; with it, it replaces. A file with
problems is still refused as an update. An update keeps the name the system has here
(installNames.update = its own name). The install route broadcasts customSystemChanged so
browsers fetch an updated system.
Decided with the user 2026-10-06; reverses the 2h rule that a system changed here could only
be kept both.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… changes (4a1b1b)
createSystem refuses a name another system not deleted has (409, store.nameTaken, shared with renameSystem).
installSystem takes { text, mode, replaceChanges }. An update over a system changed here since it was installed is no longer refused outright: without
replaceChanges: trueit answers 409 withchanged: true, so the window can warn and confirm; with it, it replaces. A file with problems is still refused as an update. An update keeps the name the system has here (installNames.update = its own name). The install route broadcasts customSystemChanged so browsers fetch an updated system.Decided with the user 2026-10-06; reverses the 2h rule that a system changed here could only be kept both.
Summary
Test plan
Pre-merge checklist
Code quality:
Version & Release:
frontend/package.jsonversiondocker-compose.ymlAPP_VERSIONCHANGELOG.mdwith release notesBefore merging to main:
Related issues