Skip to content

feat(system-builder): the SETUP page as logic (4a3a) - #177

Merged
over2take merged 1 commit into
feature/system-builderfrom
sb/4a3a-setup-logic
Oct 6, 2026
Merged

over2take merged 1 commit into
feature/system-builderfrom
sb/4a3a-setup-logic

Conversation

@over2take

Copy link
Copy Markdown
Owner

sheets/setup.ts: setupOf reads the cover fields and core answers with their defaults (one pool, no advancement, no dice, feet); withCover (blank left out) and withCore write them back; defaultHealth gives each model's usual shape; idFor makes ids for new entries; toggleAdvancement, toggleDie and addDie (up to 8, server's die pattern); healthLayout for the starter-sheet preview and tokenNote for what the monitor shows.

The test holds HEALTH_MODELS, ADVANCEMENT, DISTANCE, every default shape, the list limits, the dice and healthLayout (every model and edge case) to backend core.js and definition.js. Approved mockup builder-setup, 2026-10-06.

Summary

Test plan

  • Tested locally
  • Tests pass

Pre-merge checklist

Code quality:

  • Code follows project style
  • No breaking changes (or clearly documented)
  • No console errors or warnings

Version & Release:

  • Version bumped? If releasing to users, update:
    • frontend/package.json version
    • docker-compose.yml APP_VERSION
    • CHANGELOG.md with release notes
  • GitHub Actions will auto-tag Docker images with the new version

Before merging to main:

  • All tests passing
  • PR reviewed and approved
  • Branch is up to date with main
  • No merge conflicts

Related issues

sheets/setup.ts: setupOf reads the cover fields and core answers with their defaults (one pool, no advancement, no dice, feet); withCover (blank left out) and withCore write them back; defaultHealth gives each model's usual shape; idFor makes ids for new entries; toggleAdvancement, toggleDie and addDie (up to 8, server's die pattern); healthLayout for the starter-sheet preview and tokenNote for what the monitor shows.

The test holds HEALTH_MODELS, ADVANCEMENT, DISTANCE, every default shape, the list limits, the dice and healthLayout (every model and edge case) to backend core.js and definition.js. Approved mockup builder-setup, 2026-10-06.
@over2take
over2take merged commit 05629b6 into feature/system-builder Oct 6, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant