Skip to content

feat(system-builder): the SETUP page (4a3b) - #178

Merged
over2take merged 1 commit into
feature/system-builderfrom
sb/4a3b-setup-page
Oct 6, 2026
Merged

over2take merged 1 commit into
feature/system-builderfrom
sb/4a3b-setup-page

Conversation

@over2take

Copy link
Copy Markdown
Owner

components/SetupPage.tsx, from the approved mockup builder-setup (2026-10-06): five questions on one page, every change through the builder's edit (autosaved). 1 name (RENAME with its refusal kept in place; the builder's copy updated so the next save keeps it), description, author, license; 2 the health model cards, each model's settings (list editors within the server's limits, new entries given their own ids, numbers clamped), a live starter-sheet preview and what the token shows, and a warning when characters already play it; 3 advancement; 4 dice (toggles, a typed die, eight at most); 5 distance. Switching models and back keeps what was set.

BuilderScreen holds the definition the pages edit (edit = show + autosave.edit) and shows its name in the top bar. Tests now reach what 4a2b couldn't: unsaved status, SAVE, the browser tab asking, EXIT saving first, EXIT.EXE's STAY / TRY AGAIN / EXIT WITHOUT SAVING, PUBLISH stopping on a failed save.

Summary

Test plan

  • Tested locally
  • Tests pass

Pre-merge checklist

Code quality:

  • Code follows project style
  • No breaking changes (or clearly documented)
  • No console errors or warnings

Version & Release:

  • Version bumped? If releasing to users, update:
    • frontend/package.json version
    • docker-compose.yml APP_VERSION
    • CHANGELOG.md with release notes
  • GitHub Actions will auto-tag Docker images with the new version

Before merging to main:

  • All tests passing
  • PR reviewed and approved
  • Branch is up to date with main
  • No merge conflicts

Related issues

components/SetupPage.tsx, from the approved mockup builder-setup (2026-10-06): five questions on one page, every change through the builder's edit (autosaved). 1 name (RENAME with its refusal kept in place; the builder's copy updated so the next save keeps it), description, author, license; 2 the health model cards, each model's settings (list editors within the server's limits, new entries given their own ids, numbers clamped), a live starter-sheet preview and what the token shows, and a warning when characters already play it; 3 advancement; 4 dice (toggles, a typed die, eight at most); 5 distance. Switching models and back keeps what was set.

BuilderScreen holds the definition the pages edit (edit = show + autosave.edit) and shows its name in the top bar. Tests now reach what 4a2b couldn't: unsaved status, SAVE, the browser tab asking, EXIT saving first, EXIT.EXE's STAY / TRY AGAIN / EXIT WITHOUT SAVING, PUBLISH stopping on a failed save.
@over2take
over2take merged commit 7c5daef into feature/system-builder Oct 6, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant