Repository navigation
feat(system-builder): the SETUP page (4a3b) - #178
Merged
Merged
Conversation
components/SetupPage.tsx, from the approved mockup builder-setup (2026-10-06): five questions on one page, every change through the builder's edit (autosaved). 1 name (RENAME with its refusal kept in place; the builder's copy updated so the next save keeps it), description, author, license; 2 the health model cards, each model's settings (list editors within the server's limits, new entries given their own ids, numbers clamped), a live starter-sheet preview and what the token shows, and a warning when characters already play it; 3 advancement; 4 dice (toggles, a typed die, eight at most); 5 distance. Switching models and back keeps what was set. BuilderScreen holds the definition the pages edit (edit = show + autosave.edit) and shows its name in the top bar. Tests now reach what 4a2b couldn't: unsaved status, SAVE, the browser tab asking, EXIT saving first, EXIT.EXE's STAY / TRY AGAIN / EXIT WITHOUT SAVING, PUBLISH stopping on a failed save.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
components/SetupPage.tsx, from the approved mockup builder-setup (2026-10-06): five questions on one page, every change through the builder's edit (autosaved). 1 name (RENAME with its refusal kept in place; the builder's copy updated so the next save keeps it), description, author, license; 2 the health model cards, each model's settings (list editors within the server's limits, new entries given their own ids, numbers clamped), a live starter-sheet preview and what the token shows, and a warning when characters already play it; 3 advancement; 4 dice (toggles, a typed die, eight at most); 5 distance. Switching models and back keeps what was set.
BuilderScreen holds the definition the pages edit (edit = show + autosave.edit) and shows its name in the top bar. Tests now reach what 4a2b couldn't: unsaved status, SAVE, the browser tab asking, EXIT saving first, EXIT.EXE's STAY / TRY AGAIN / EXIT WITHOUT SAVING, PUBLISH stopping on a failed save.
Summary
Test plan
Pre-merge checklist
Code quality:
Version & Release:
frontend/package.jsonversiondocker-compose.ymlAPP_VERSIONCHANGELOG.mdwith release notesBefore merging to main:
Related issues