Repository navigation
feat(system-builder): live formula values from the sample character (… - #184
Merged
Merged
Conversation
…4b2b)
derived.previewDerived works out a draft's derived values from data (the sample character),
leaving out each value with a problem and everything that reads one, round by round, so one
unfinished formula doesn't blank the rest; it returns compileSystem's problems too. A problem
it can't pin to one named value (a broken table) gives no values, only the problems.
POST /api/systems/preview-values {definition}, main admin only: refuses what can't be a
definition, uses the draft's own samples, changes nothing. One engine for the builder and the
game, rather than a second copy in the browser (which would also need the code-backed $rules).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…4b2b)
derived.previewDerived works out a draft's derived values from data (the sample character), leaving out each value with a problem and everything that reads one, round by round, so one unfinished formula doesn't blank the rest; it returns compileSystem's problems too. A problem it can't pin to one named value (a broken table) gives no values, only the problems.
POST /api/systems/preview-values {definition}, main admin only: refuses what can't be a definition, uses the draft's own samples, changes nothing. One engine for the builder and the game, rather than a second copy in the browser (which would also need the code-backed $rules).
Summary
Test plan
Pre-merge checklist
Code quality:
Version & Release:
frontend/package.jsonversiondocker-compose.ymlAPP_VERSIONCHANGELOG.mdwith release notesBefore merging to main:
Related issues