Skip to content

feat(system-builder): live formula values from the sample character (… - #184

Merged
over2take merged 1 commit into
feature/system-builderfrom
sb/4b2b-stats-rules-logic
Oct 7, 2026
Merged

over2take merged 1 commit into
feature/system-builderfrom
sb/4b2b-stats-rules-logic

Conversation

@over2take

Copy link
Copy Markdown
Owner

…4b2b)

derived.previewDerived works out a draft's derived values from data (the sample character), leaving out each value with a problem and everything that reads one, round by round, so one unfinished formula doesn't blank the rest; it returns compileSystem's problems too. A problem it can't pin to one named value (a broken table) gives no values, only the problems.

POST /api/systems/preview-values {definition}, main admin only: refuses what can't be a definition, uses the draft's own samples, changes nothing. One engine for the builder and the game, rather than a second copy in the browser (which would also need the code-backed $rules).

Summary

Test plan

  • Tested locally
  • Tests pass

Pre-merge checklist

Code quality:

  • Code follows project style
  • No breaking changes (or clearly documented)
  • No console errors or warnings

Version & Release:

  • Version bumped? If releasing to users, update:
    • frontend/package.json version
    • docker-compose.yml APP_VERSION
    • CHANGELOG.md with release notes
  • GitHub Actions will auto-tag Docker images with the new version

Before merging to main:

  • All tests passing
  • PR reviewed and approved
  • Branch is up to date with main
  • No merge conflicts

Related issues

…4b2b)

derived.previewDerived works out a draft's derived values from data (the sample character),
leaving out each value with a problem and everything that reads one, round by round, so one
unfinished formula doesn't blank the rest; it returns compileSystem's problems too. A problem
it can't pin to one named value (a broken table) gives no values, only the problems.

POST /api/systems/preview-values {definition}, main admin only: refuses what can't be a
definition, uses the draft's own samples, changes nothing. One engine for the builder and the
game, rather than a second copy in the browser (which would also need the code-backed $rules).
@over2take
over2take merged commit 3302caf into feature/system-builder Oct 7, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant