Repository navigation
feat(system-builder): the STATS & RULES page as logic (4b2c) - #185
Merged
Merged
Conversation
sheets/statsRules.ts: stat groups and stats (withNewGroup / withGroupLabel / withoutGroup, withNewStat / withStat / withoutStat, with ranges and ties), the sample character (sampleOf / withSample), formulas (withNewFormula / withFormula / withoutFormula, usedBy, problemsByFormula, insertToken), tables (withNewTable / withTableLabel / withoutTable, withBands, lookupIn). Ids come from first names via setup.idFor and never take one already used (takenIds: the starter sheet's and health section's fields, groups, stats, formulas, tables, the engine's functions). Removing a stat takes its sample and ties to it; empty sections are removed. systemsApi gains previewValues (POST /api/systems/preview-values). Held to the server: every step passes definition.js's check, the built system works out through derived.previewDerived, FUNCTIONS matches expression.js BUILTINS. Approved mockup builder-stats-rules, 2026-10-06.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sheets/statsRules.ts: stat groups and stats (withNewGroup / withGroupLabel / withoutGroup, withNewStat / withStat / withoutStat, with ranges and ties), the sample character (sampleOf / withSample), formulas (withNewFormula / withFormula / withoutFormula, usedBy, problemsByFormula, insertToken), tables (withNewTable / withTableLabel / withoutTable, withBands, lookupIn). Ids come from first names via setup.idFor and never take one already used (takenIds: the starter sheet's and health section's fields, groups, stats, formulas, tables, the engine's functions). Removing a stat takes its sample and ties to it; empty sections are removed.
systemsApi gains previewValues (POST /api/systems/preview-values).
Held to the server: every step passes definition.js's check, the built system works out through derived.previewDerived, FUNCTIONS matches expression.js BUILTINS. Approved mockup builder-stats-rules, 2026-10-06.
Summary
Test plan
Pre-merge checklist
Code quality:
Version & Release:
frontend/package.jsonversiondocker-compose.ymlAPP_VERSIONCHANGELOG.mdwith release notesBefore merging to main:
Related issues