Repository navigation
feat(system-builder): CHARACTER SHEET page logic (4b3b) - #189
Merged
Merged
Conversation
frontend/src/sheets/sheetDesigner.ts: customize (copy the starter) and back to automatic; tabs added, renamed (refusing blank, long or repeated names), moved and removed (sections move to a chosen tab; the last tab makes a one-page sheet); sections and fields added, changed, moved and removed; the tray of starter fields not on a customized sheet; the header and max pairs forget fields that left; the name field stays; a formula's kind and editing are fixed; an attack number is never public. Every step is held to the server's checkDefinition in its tests. statsRules.takenIds also counts a customized sheet's own fields, so a new stat or formula never takes one's id.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
frontend/src/sheets/sheetDesigner.ts: customize (copy the starter) and back to automatic; tabs added, renamed (refusing blank, long or repeated names), moved and removed (sections move to a chosen tab; the last tab makes a one-page sheet); sections and fields added, changed, moved and removed; the tray of starter fields not on a customized sheet; the header and max pairs forget fields that left; the name field stays; a formula's kind and editing are fixed; an attack number is never public. Every step is held to the server's checkDefinition in its tests.
statsRules.takenIds also counts a customized sheet's own fields, so a new stat or formula never takes one's id.
Summary
Test plan
Pre-merge checklist
Code quality:
Version & Release:
frontend/package.jsonversiondocker-compose.ymlAPP_VERSIONCHANGELOG.mdwith release notesBefore merging to main:
Related issues