Repository navigation
Conversation
Spriz
changed the title
Spriz
force-pushed
the
php86-spl-object-id
branch
from
October 4, 2026 13:35
333d5eb to
e028bbb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disclosure: this change and description were written by an AI coding agent (Claude Code) and have not yet been reviewed by me.
PHP 8.6 emits "Function spl_object_hash() is deprecated since 8.6, consider using spl_object_id() instead" from CacheMap and WebonyxGraphQLSyncPromiseAdapter, both hit by the existing tests. The adapter's cancellers are now keyed by int; CacheMap formats the id as a 32-char hex string so object keys still cannot collide with integer keys.
CI now also runs on PHP 8.6 (highest dependencies only, like 8.5). The second commit fixes the deprecations the suite itself raised: single-argument ReflectionProperty::setValue() in tests/TestCase.php, and data provider keys (metrics/response) that did not match testExecute()'s parameter names. The suite is now deprecation-free on 8.5; on 8.6 the only one left is guzzlehttp/promises'
Isclass, fixed upstream in guzzle/promises#245.🤖 Generated with Claude Code