Repository navigation
Conversation
`flash_erase_range` assumes the caller to check the math. If the write lands on the block boundary, `flash_erase_range` gets called with an empty range, which calls `start_erase_range` with an inverted range, and the FlashSim gives `erase-inverted-range:`. The fix is to skip erasing an empty range.
imlvts
force-pushed
the
fix-stage0-promote-full-erase
branch
from
November 10, 2026 03:47
52a41a1 to
bcde0fe
Compare
Author
|
closing in favor of #2771 , which will get a combined fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
flash_erase_rangeassumes the caller to check the math.If the write lands on the block boundary,
flash_erase_rangegets called with an empty range, which callsstart_erase_rangewith an inverted range, and the FlashSim giveserase-inverted-range:.The fix is to skip erasing an empty range.