Skip to content

small output changes (mostly cosmetic) - #1071

Merged
ahl merged 2 commits into
mainfrom
typespace-nits
Sep 9, 2026
Merged

small output changes (mostly cosmetic)#1071
ahl merged 2 commits into
mainfrom
typespace-nits

Conversation

@ahl

@ahl ahl commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator
  • move mod error to the end of the file (sort mods alphabetically)
  • simplify mod #[doc] attributes
  • remove #[serde(default)] from Option types (it's a no-op)
  • add #[serde(deserialize_with = "Option::deserialize")] for Option
    fields that are required (without it, they may be absent)
  • minor re-ordering of trait impls for consistency

The change for the required Option serde annotation is the only functional change: code that was previously relying on the incorrect semantics will break.

ahl added 2 commits September 9, 2026 09:38
- move `mod error` to the end of the file (sort mods alphabetically)
- simplify mod #[doc] attributes
- remove #[serde(default)] from Option types (it's a no-op)
- add #[serde(deserialize_with = "Option::deserialize")] for Option
  fields that are required (without it, they may be absent)
- minor re-ordering of trait impls for consistency
@ahl
ahl merged commit 30b08a3 into main Sep 9, 2026
4 checks passed
@ahl
ahl deleted the typespace-nits branch September 9, 2026 16:51
ahl added a commit to danieleades/typify that referenced this pull request Sep 9, 2026
flatten-default.rs picks up the cosmetic output changes from oxidecomputer#1071

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AVbGbiJVfSyEkLG4VUZML1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant